From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B5BDC433E1 for ; Fri, 17 Jul 2020 00:37:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA898207BC for ; Fri, 17 Jul 2020 00:37:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LS08LWzi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726231AbgGQAhC (ORCPT ); Thu, 16 Jul 2020 20:37:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725958AbgGQAhB (ORCPT ); Thu, 16 Jul 2020 20:37:01 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FDE3C061755; Thu, 16 Jul 2020 17:37:01 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id m9so4532270pfh.0; Thu, 16 Jul 2020 17:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7Ia9lwKuYWAs1dXC9cpUp3o/54vZA86HM0tRpPSoBhY=; b=LS08LWzi1o9aP3ElA3bElXvlu6NsaQNQiRrry1+NmX+UHL8jAs7SrOpgseVgcnzJwk jDcxNJ19YgCcY68z3UaxFNndW3E/MMfUzvlVY3aW5JAkwyVzQaflllfKmNzE0kcUqJQh tkf4KgHUzyjmI91XFfPFDaxizrGxUNar//Z+5CDX7TOM5cYi2lhCXa2vB1iML36metOE fqYgADUckitKvVLU8Ngh8yH7Tn2EECGzAspqslLvAAMxBjRgfGEYVgIkOQ/4MKNGCrq2 GekNa9n1+SlXb3Pn682nItnByeXymFvOa1L9ESHdRww7hyI8C47CbzNwsEgZ5FdKtHHn kXUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7Ia9lwKuYWAs1dXC9cpUp3o/54vZA86HM0tRpPSoBhY=; b=dJm/+KQ+FzHrGpJHD0jgstU1e2o136bKQjKKcmceoBHqeTSgV3S7Ta0Ou25RTnjnG5 uvhTDwu0zAWb7HoRU4K635faNIYcXvdulkq9WbbSjmOET1ez/vuZcAKTsO0/MLVrWd7g AmBp8B3GiwiKG8iaaGW+iSkCrP13YlwSPT0WAh7zn4eL0aozKx3JrCInZJerEfMhO9/9 f8zhWA5NB7doJKVgaWzJuVU3nH6Y9/7XVp9bD87tmgafVSHBBEUv/7bfnbtVDCWpthlG YnxKMt4LwL4V2iyC9SebVPgBerJqjRePUQ1BMJRoPSyDd+F1siHl8pbhtq86s+iBd0fI QaZg== X-Gm-Message-State: AOAM533FoakqduZbIyCJsA34O3ILSUzJHjoSVqnlPdYUb7s93/FBUxxi xOCimQZsnPS7n7C496DJJJjtJSdw X-Google-Smtp-Source: ABdhPJzQ34WuLQgSuWRBH1xmAZO58VueCwA8XX9CHu0N86n7Hhl3X+y+k8fjqaQNlIaLFfspVAESBg== X-Received: by 2002:a63:541e:: with SMTP id i30mr6609471pgb.47.1594946220681; Thu, 16 Jul 2020 17:37:00 -0700 (PDT) Received: from ?IPv6:2001:470:67:5b9:5dec:e971:4cde:a128? ([2001:470:67:5b9:5dec:e971:4cde:a128]) by smtp.gmail.com with ESMTPSA id v11sm6291954pfc.108.2020.07.16.17.36.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2020 17:36:59 -0700 (PDT) Subject: Re: [PATCH net 1/3] net: bcmgenet: test MPD_EN when resuming To: Doug Berger , "David S. Miller" Cc: Jakub Kicinski , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1594942697-37954-1-git-send-email-opendmb@gmail.com> <1594942697-37954-2-git-send-email-opendmb@gmail.com> From: Florian Fainelli Message-ID: Date: Thu, 16 Jul 2020 17:36:57 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1594942697-37954-2-git-send-email-opendmb@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/16/2020 4:38 PM, Doug Berger wrote: > When the GENET driver resumes from deep sleep the UMAC_CMD > register may not be accessible and therefore should not be > accessed from bcmgenet_wol_power_up_cfg() if the GENET has > been reset. > > This commit adds a check of the MPD_EN flag when Wake on > Magic Packet is enabled. A clear flag indicates that the > GENET hardware must have been reset so the remainder of the > hardware programming is bypassed. > > Fixes: 1a1d5106c1e3 ("net: bcmgenet: move clk_wol management to bcmgenet_wol") > Signed-off-by: Doug Berger Acked-by: Florian Fainelli -- Florian