From: Liu Ying <victor.liu@nxp.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
mchehab@kernel.org, a.hajda@samsung.com, narmstrong@baylibre.com,
jonas@kwiboo.se, jernej.skrabec@siol.net, kishon@ti.com,
vkoul@kernel.org, robert.foss@linaro.org, lee.jones@linaro.org
Subject: Re: [PATCH v5 02/14] media: docs: Add some RGB bus formats for i.MX8qm/qxp pixel combiner
Date: Thu, 11 Mar 2021 13:26:51 +0800 [thread overview]
Message-ID: <d44708530dd0ef1d758dee6651779679a22c3dff.camel@nxp.com> (raw)
In-Reply-To: <YEjIf//ouB1wZss3@pendragon.ideasonboard.com>
Hi Laurent,
On Wed, 2021-03-10 at 15:24 +0200, Laurent Pinchart wrote:
> Hi Liu,
>
> Thank you for the patch.
Thanks for your review.
>
> On Wed, Mar 10, 2021 at 05:55:26PM +0800, Liu Ying wrote:
> > This patch adds documentations for RGB666_1X30_CPADLO, RGB888_1X30_CPADLO,
> > RGB666_1X36_CPADLO and RGB888_1X36_CPADLO bus formats used by i.MX8qm/qxp
> > pixel combiner. The RGB pixels with padding low per component are
> > transmitted on a 30-bit input bus(10-bit per component) from a display
> > controller or a 36-bit output bus(12-bit per component) to a pixel link.
> >
> > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > ---
> > v4->v5:
> > * Add Robert's R-b tag.
> >
> > v3->v4:
> > * No change.
> >
> > v2->v3:
> > * No change.
> >
> > v1->v2:
> > * No change.
> >
> > .../userspace-api/media/v4l/subdev-formats.rst | 156 +++++++++++++++++++++
> > 1 file changed, 156 insertions(+)
> >
> > diff --git a/Documentation/userspace-api/media/v4l/subdev-formats.rst b/Documentation/userspace-api/media/v4l/subdev-formats.rst
> > index 7f16cbe..201c16d 100644
> > --- a/Documentation/userspace-api/media/v4l/subdev-formats.rst
> > +++ b/Documentation/userspace-api/media/v4l/subdev-formats.rst
> > @@ -1488,6 +1488,80 @@ The following tables list existing packed RGB formats.
> > - b\ :sub:`2`
> > - b\ :sub:`1`
> > - b\ :sub:`0`
> > + * .. _MEDIA-BUS-FMT-RGB666-1X30-CPADLO:
> > +
> > + - MEDIA_BUS_FMT_RGB666_1X30-CPADLO
> > + - 0x101e
> > + -
> > + - 0
> > + - 0
>
> I count 32 bits here. Should these two 0 be replaced by spaces ? Same
> for MEDIA_BUS_FMT_RGB888_1X30-CPADLO.
Indeed, these two 0 should be spaces. Will fix them in next version.
I see the in-tree MEDIA_BUS_FMT_RGB101010_1X30 has the same issue.
I can send another patch to fix it.
Regards,
Liu Ying
>
> With this fixed,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > + - r\ :sub:`5`
> > + - r\ :sub:`4`
> > + - r\ :sub:`3`
> > + - r\ :sub:`2`
> > + - r\ :sub:`1`
> > + - r\ :sub:`0`
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - g\ :sub:`5`
> > + - g\ :sub:`4`
> > + - g\ :sub:`3`
> > + - g\ :sub:`2`
> > + - g\ :sub:`1`
> > + - g\ :sub:`0`
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - b\ :sub:`5`
> > + - b\ :sub:`4`
> > + - b\ :sub:`3`
> > + - b\ :sub:`2`
> > + - b\ :sub:`1`
> > + - b\ :sub:`0`
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + * .. _MEDIA-BUS-FMT-RGB888-1X30-CPADLO:
> > +
> > + - MEDIA_BUS_FMT_RGB888_1X30-CPADLO
> > + - 0x101f
> > + -
> > + - 0
> > + - 0
> > + - r\ :sub:`7`
> > + - r\ :sub:`6`
> > + - r\ :sub:`5`
> > + - r\ :sub:`4`
> > + - r\ :sub:`3`
> > + - r\ :sub:`2`
> > + - r\ :sub:`1`
> > + - r\ :sub:`0`
> > + - 0
> > + - 0
> > + - g\ :sub:`7`
> > + - g\ :sub:`6`
> > + - g\ :sub:`5`
> > + - g\ :sub:`4`
> > + - g\ :sub:`3`
> > + - g\ :sub:`2`
> > + - g\ :sub:`1`
> > + - g\ :sub:`0`
> > + - 0
> > + - 0
> > + - b\ :sub:`7`
> > + - b\ :sub:`6`
> > + - b\ :sub:`5`
> > + - b\ :sub:`4`
> > + - b\ :sub:`3`
> > + - b\ :sub:`2`
> > + - b\ :sub:`1`
> > + - b\ :sub:`0`
> > + - 0
> > + - 0
> > * .. _MEDIA-BUS-FMT-ARGB888-1X32:
> >
> > - MEDIA_BUS_FMT_ARGB888_1X32
> > @@ -1665,6 +1739,88 @@ The following table list existing packed 36bit wide RGB formats.
> > - 2
> > - 1
> > - 0
> > + * .. _MEDIA-BUS-FMT-RGB666-1X36-CPADLO:
> > +
> > + - MEDIA_BUS_FMT_RGB666_1X36_CPADLO
> > + - 0x1020
> > + -
> > + - r\ :sub:`5`
> > + - r\ :sub:`4`
> > + - r\ :sub:`3`
> > + - r\ :sub:`2`
> > + - r\ :sub:`1`
> > + - r\ :sub:`0`
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - g\ :sub:`5`
> > + - g\ :sub:`4`
> > + - g\ :sub:`3`
> > + - g\ :sub:`2`
> > + - g\ :sub:`1`
> > + - g\ :sub:`0`
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - b\ :sub:`5`
> > + - b\ :sub:`4`
> > + - b\ :sub:`3`
> > + - b\ :sub:`2`
> > + - b\ :sub:`1`
> > + - b\ :sub:`0`
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + * .. _MEDIA-BUS-FMT-RGB888-1X36-CPADLO:
> > +
> > + - MEDIA_BUS_FMT_RGB888_1X36_CPADLO
> > + - 0x1021
> > + -
> > + - r\ :sub:`7`
> > + - r\ :sub:`6`
> > + - r\ :sub:`5`
> > + - r\ :sub:`4`
> > + - r\ :sub:`3`
> > + - r\ :sub:`2`
> > + - r\ :sub:`1`
> > + - r\ :sub:`0`
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - g\ :sub:`7`
> > + - g\ :sub:`6`
> > + - g\ :sub:`5`
> > + - g\ :sub:`4`
> > + - g\ :sub:`3`
> > + - g\ :sub:`2`
> > + - g\ :sub:`1`
> > + - g\ :sub:`0`
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > + - b\ :sub:`7`
> > + - b\ :sub:`6`
> > + - b\ :sub:`5`
> > + - b\ :sub:`4`
> > + - b\ :sub:`3`
> > + - b\ :sub:`2`
> > + - b\ :sub:`1`
> > + - b\ :sub:`0`
> > + - 0
> > + - 0
> > + - 0
> > + - 0
> > * .. _MEDIA-BUS-FMT-RGB121212-1X36:
> >
> > - MEDIA_BUS_FMT_RGB121212_1X36
next prev parent reply other threads:[~2021-03-11 5:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 9:55 [PATCH v5 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs Liu Ying
2021-03-10 9:55 ` [PATCH v5 01/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner Liu Ying
2021-03-10 13:45 ` Laurent Pinchart
2021-03-10 9:55 ` [PATCH v5 02/14] media: docs: " Liu Ying
2021-03-10 13:24 ` Laurent Pinchart
2021-03-11 5:26 ` Liu Ying [this message]
2021-03-10 9:55 ` [PATCH v5 03/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding Liu Ying
2021-03-10 9:55 ` [PATCH v5 04/14] drm/bridge: imx: Add i.MX8qm/qxp pixel combiner support Liu Ying
2021-03-10 9:55 ` [PATCH v5 05/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding Liu Ying
2021-03-10 9:55 ` [PATCH v5 06/14] drm/bridge: imx: Add i.MX8qm/qxp display pixel link support Liu Ying
2021-03-10 9:55 ` [PATCH v5 07/14] dt-bindings: mfd: Add i.MX8qm/qxp Control and Status Registers module binding Liu Ying
2021-03-16 22:38 ` Rob Herring
2021-03-17 2:04 ` Liu Ying
2021-03-10 9:55 ` [PATCH v5 08/14] dt-bindings: display: bridge: Add i.MX8qxp pixel link to DPI binding Liu Ying
2021-03-16 22:40 ` Rob Herring
2021-03-10 9:55 ` [PATCH v5 09/14] drm/bridge: imx: Add i.MX8qxp pixel link to DPI support Liu Ying
2021-03-10 9:55 ` [PATCH v5 10/14] drm/bridge: imx: Add LDB driver helper support Liu Ying
2021-03-10 9:55 ` [PATCH v5 11/14] dt-bindings: display: bridge: Add i.MX8qm/qxp LVDS display bridge binding Liu Ying
2021-03-10 9:55 ` [PATCH v5 12/14] drm/bridge: imx: Add LDB support for i.MX8qxp Liu Ying
2021-03-10 12:16 ` kernel test robot
2021-03-10 19:38 ` kernel test robot
2021-03-10 9:55 ` [PATCH v5 13/14] drm/bridge: imx: Add LDB support for i.MX8qm Liu Ying
2021-03-10 13:25 ` kernel test robot
2021-03-10 9:55 ` [PATCH v5 14/14] MAINTAINERS: add maintainer for DRM bridge drivers for i.MX SoCs Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d44708530dd0ef1d758dee6651779679a22c3dff.camel@nxp.com \
--to=victor.liu@nxp.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=kishon@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox