From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BF1038911E for ; Thu, 6 Aug 2026 06:20:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785997218; cv=none; b=LMqE9EjvR8sFd9mm19C6pG65ZJ/g/4s0Fa5mJVdAp0QaL62wd0jcHHpSdAz86/i4/iZ+oIqVcr6QLMMNMUM/TX2q/ZjjQZGTH423e0ZIQt7aCvjYCf7HI2aizC8zn/I1SC6Y4Ye9PvECkFimqR2ndSsc2uVZogqyagk2mIxxR10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785997218; c=relaxed/simple; bh=2PkuKFijFt5PnR+9+/n9rpDdV1qG0cjoklALqhi6BGk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kiHXpycBgDkNnIp8lV2XVX4paYqcA7ViMAgjFtwzWWt7VdnNKN4ymnO1apDxs8zmACLOFNB09HLLjBmKc8k3waqlLQCz7xPa2+4lIbRdrK42gNwSsiVGAg8/BsW4Tc5la0Caryu1MhNEra9Rc3Z8GGx6WUyXH8ZTiaQrcgH2b0Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=TAEM9aek; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="TAEM9aek" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4956242332dso14015475e9.2 for ; Wed, 05 Aug 2026 23:20:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785997215; x=1786602015; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aAuvnCD1uphQa04NcpaDiUaJGfs6oUj2xypwAwI1W/U=; b=TAEM9aekW+ng+cco/r72XvoYFGf65omOyJzBU1Y5sAnvseVgKYyhiTm8lBTptcQPNx zfU3/nNmkxvStr4Bf7otHTyK2+lw7MH6XLEBxBVYLPEKbDuyR2pFEzOhPkgAZhTwTgpb uDEo391jgrkwNKYZKaJudE6RLusQpHVT3QVLIbOW2uVm0xtmt4pyUCOI1zEI8UQo9Ws2 OaVDSSGuU1YJjCHgC7UZqlm4scJ+HbzMIPns04UfXtuBxk+6KtVTQXerfPWrIpHKvz7O XsvhQ36kxQae4AJb7wppCMrVCVfN4OF53WDv66XFlbY1d1bMMG3DWCVIt/w1ocnX/6Cr yDeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785997215; x=1786602015; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aAuvnCD1uphQa04NcpaDiUaJGfs6oUj2xypwAwI1W/U=; b=DmO+W1WZlMd6To2F1YnWG4CD/a99mUur8GqzonoTHF+CmujKdgrTh3HAB97vDRF8W/ ftDZ01YBXyppJlIP3nei6HYyR74aPC18OaPqrVa6JKokEmeJmEFzxm7dXdRRSWyydBT2 43ssGGr0UXJrkdTJw2amdrgeZfaNMSLMe+HvA43LN8Zgi30NU3NyOzYde7Fr4gronRzK sIjngZG7WqHXLGOeYr5TGD9csmh6LLrKgfreB5ZoRFIriXw+IpWvBuewS04eQE4pIcSA 1bUt2gPii+Svh6YJeC1cAfLKzl1kei8cKVyUzm42xrqcx6xATP8lCIyU5pErEyUlVJ3n AbaQ== X-Forwarded-Encrypted: i=1; AHgh+Rr5hxd5D85dYUR00zCi1WdCY1ptIO+qJrPWNnsKW9Aka79qrFK8BGGMT0m9oRdwpjFWrerNTUvlBxjTqgs=@vger.kernel.org X-Gm-Message-State: AOJu0YxqBQIT3PqxApZ1W/+egWLCDi1LwzHUIbicum3ZtuTXfrMFqXmM aBuD8VRxnXKTaG6nP2CPiU4NZTFNA5lM25i0n079aKDz03Qu4LXf9bm25+f8sv7aUw== X-Gm-Gg: AR+sD11GB5RR+HIhDpwaRPcV32btAfpTz2TYmUGMZXnvcuukaIN9zKvIZEOIj9vhUkD 41e4fw0J3eYikvdz2sPWN8UxieSTvQWaj0g5KMHA424x+0ueaqXH6m9SV+cFbacUkB3ka2/W7Ta FceLqcGHAh4j/mpDOjsIauXXx7wbRN6JeWkpROnDRkPNBbAYuMO2YmAweedgvKqtrPKvbvc9xh4 BibKXewbd75BQLAC5vsyEOwmFH4V6ADUQ6GBiia5lxfeeO6KUpE1pwP8FSEZm723QQ81F1Xbve9 FS47p2/ikkGyOMlKj8Wmx07eI2+l0zA/Olh4gPGz3RioyrWJRGtM7vP8OjVphTIw3OvLUIFTIql yyPwVQf35Ib2KRGkeXDt74Ql5kLIe3fOCWLGyAtu4GSg71O+/YlJYK5uXDBXHHRdHcH7ws6wNk2 ys3FbwJwksshPW7Fpsu21OVpuwCjjC2EaUnQgl9HfmExphu4n7kSynj09zeffaKYMGUM3T9z2RC GtbwCuqS5yXO2yAVV6Llk4jVh+Ic0IjpZuejhwvS5Br999fv79c X-Received: by 2002:a05:600c:35c4:b0:499:4dca:aa4 with SMTP id 5b1f17b1804b1-4994e70ed73mr161340535e9.4.1785997214876; Wed, 05 Aug 2026 23:20:14 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499542241c4sm34174345e9.11.2026.08.05.23.20.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 23:20:14 -0700 (PDT) Message-ID: Date: Thu, 6 Aug 2026 08:20:13 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] xen/Kconfig: select XEN_PVHVM To: Jason Andryuk Cc: Andrew Cooper , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Stefano Stabellini , Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Jason Andryuk References: <20260806015233.202486-1-jason.andryuk@amd.com> <20260806015233.202486-3-jason.andryuk@amd.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260806015233.202486-3-jason.andryuk@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 06.08.2026 03:52, Jason Andryuk wrote: > --- a/arch/x86/xen/Kconfig > +++ b/arch/x86/xen/Kconfig > @@ -51,7 +51,7 @@ config XEN_PV_DOM0 > depends on XEN_PV && XEN_DOM0 > > config XEN_PVHVM > - def_bool y > + bool > depends on XEN && X86_LOCAL_APIC Imo "depends on" on prompt-less, default-off options are at best unhelpful in the common case. (Aiui it can be helpful when "imply" is used instead of "select".) Hence I think this dependency wants dropping right in this patch, justified further by ... > @@ -61,13 +61,15 @@ config XEN_PVHVM_SMP > config XEN_PVHVM_GUEST > bool "Xen PVHVM guest support" > default y > - depends on XEN_PVHVM && PCI > + depends on XEN && PCI > + select XEN_PVHVM > help > Support running as a Xen PVHVM guest. > > config XEN_PVH > bool "Xen PVH guest support" > - depends on XEN && XEN_PVHVM && ACPI > + depends on XEN && ACPI > + select XEN_PVHVM > select PVH > help > Support for running as a Xen PVH guest. ... the XEN dependency being in both of the options selecting XEN_PVHVM and, as per Jürgen's patch, X86_LOCAL_APIC being redundant anyway. Jan