public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Markus Armbruster <armbru@redhat.com>
Subject: [PATCH 4 of 5] xen pvfb: Zero unused bytes in events sent to backend
Date: Fri, 23 May 2008 14:06:24 +0100	[thread overview]
Message-ID: <d4519d6b15a1e1b9625e.1211547984@localhost> (raw)
In-Reply-To: <patchbomb.1211547980@localhost>

From: Markus Armbruster <armbru@redhat.com>

This isn't a security flaw (the backend can see all our memory
anyway).  But it's the right thing to do all the same.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
---
 drivers/video/xen-fbfront.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/xen-fbfront.c b/drivers/video/xen-fbfront.c
--- a/drivers/video/xen-fbfront.c
+++ b/drivers/video/xen-fbfront.c
@@ -61,6 +61,7 @@
 	union xenfb_out_event event;
 	u32 prod;
 
+	memset(&event, 0, sizeof(event));
 	event.type = XENFB_TYPE_UPDATE;
 	event.update.x = x;
 	event.update.y = y;



  parent reply	other threads:[~2008-05-23 13:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-23 13:06 [PATCH 0 of 5] xen: paravirt framebuffer updates Jeremy Fitzhardinge
2008-05-23 13:06 ` [PATCH 1 of 5] xen: Enable console tty by default in domU if it's not a dummy Jeremy Fitzhardinge
2008-05-23 13:06 ` [PATCH 2 of 5] xen pvfb: Pointer z-axis (mouse wheel) support Jeremy Fitzhardinge
2008-05-23 13:06 ` [PATCH 3 of 5] xen pvfb: Module aliases to support module autoloading Jeremy Fitzhardinge
2008-05-23 13:06 ` Jeremy Fitzhardinge [this message]
2008-05-23 13:06 ` [PATCH 5 of 5] xen pvfb: Dynamic mode support (screen resizing) Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4519d6b15a1e1b9625e.1211547984@localhost \
    --to=jeremy@goop.org \
    --cc=armbru@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox