From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECBC31E1A33 for ; Thu, 10 Oct 2024 21:19:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728595142; cv=none; b=Se+y9ruY9ZzkF7ZamHACLCnARygkc+G69LAizwAN2TayliRoCIHGHhXTcO2yOLNa/3sqXxSZ97FX0Hg+GXYzmKrafL6bJuL5h0k6NaFD3258R1zJe6Lb5wDV8Btr13doXoXhroxv4UH55yYhyrtG5nW4b+jidf6Mdujdlz8yHYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728595142; c=relaxed/simple; bh=XgFyRsRqIXnwJJtXgPqzhU6CtjwMWa+ou90c0icQbx0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=o2rgppnls+vc/eI8kdKQ13QE5uyOJosZ/LcMjLowv2pNqf7fMXcbaVwZmbyjISS/8elsf/HGlLv6sBi9Tx5NVf009nBHCDinAqxThnqmHXgYyCHb5sBS8NVsaifK/7368F0VP/hMdgmoF+F2pW3ii4XU8u+xkKp5pnQDuLcheZg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bNYWRJjc; arc=none smtp.client-ip=209.85.166.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bNYWRJjc" Received: by mail-io1-f43.google.com with SMTP id ca18e2360f4ac-8354c496c90so40827739f.3 for ; Thu, 10 Oct 2024 14:19:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1728595140; x=1729199940; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nBZbBlwQa7HT+/mui9xTJE7fZJhA2rmF/mcQQtgNOAo=; b=bNYWRJjc1UpZiY4Iip35UUkTTGmuanbWWaFqetgyZP3a4urjmfcRoli4PiZEWbbTPB IJLAlqfX8Uc/oAB0VM7+45RC7bIq7l7jjJJjHqbmSftZS2Fm9yoSJAyPxJzgHp23F0eG ZTpivwUPD1fUasmUYMKpr4bn78qOESMYRFy6M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728595140; x=1729199940; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nBZbBlwQa7HT+/mui9xTJE7fZJhA2rmF/mcQQtgNOAo=; b=RrinqIOtICUBapQ2kXJEgkw7hu6O283dIsxrGWk1y/taIkj4lI/C6SFvy4ZEraewmi fdpyRcpTXMi6r/5FeZjvQqtyyiuQnWPxPHDmT8GMXkVMyLU/+6r9TXA5SaBNTMY/V6M0 ImUSUmRKhQPCsLDqZ1meu/WF/q6xuNymdEovkpFRxby2shpnRnsvGNv66K/w+pe+Ttmo 5odWhREJs6sbtJpS1FC4OJwH8LiC6cBkympH+9Yd82uxo5thOwQlYJny0h+9z7tICrw5 rZ04i75HAL48kumc0vxKa3Trh0V1JHD9epbW4m3IInyn+aT/zNh3KUUIpdo2LnmX5KUY GHrg== X-Forwarded-Encrypted: i=1; AJvYcCUu/hr/TVk2b/JHKHe8UylY7N1uZDMAx/gjR2zjAVnEtOZTaZCCPNRokW2wF3G1IjwPvAiwQr/QKeMqz9Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yx98heIYSTwxleJp2eiT+xOQ3klH7jkG9+nisNt9Qr2OyURET+i 3KzG77Fw9PkpUI7Xwz6ueH+OaPLQYA/BPBWBfX4/nvj6a5tx6j/47QIjEQ3wlGw= X-Google-Smtp-Source: AGHT+IEYkeeNxtQt681in3Sz57PrDzHIA9l/kBVtyF0yM/0puYCqVuivQ2EI5A8y1bdIaBfyBVotKw== X-Received: by 2002:a05:6602:1341:b0:835:3ec0:9 with SMTP id ca18e2360f4ac-83794d44d5cmr28566839f.15.1728595139979; Thu, 10 Oct 2024 14:18:59 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4dbada841ebsm384083173.112.2024.10.10.14.18.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Oct 2024 14:18:59 -0700 (PDT) Message-ID: Date: Thu, 10 Oct 2024 15:18:58 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v20 01/14] mm: page_frag: add a test module for page_frag To: Yunsheng Lin , davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Duyck , Alexander Duyck , Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20241008112049.2279307-1-linyunsheng@huawei.com> <20241008112049.2279307-2-linyunsheng@huawei.com> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/8/24 21:59, Yunsheng Lin wrote: > On 2024/10/9 3:56, Shuah Khan wrote: >> On 10/8/24 05:20, Yunsheng Lin wrote: >>> The testing is done by ensuring that the fragment allocated >>> from a frag_frag_cache instance is pushed into a ptr_ring >>> instance in a kthread binded to a specified cpu, and a kthread >>> binded to a specified cpu will pop the fragment from the >>> ptr_ring and free the fragment. >>> >>> CC: Alexander Duyck >>> Signed-off-by: Yunsheng Lin >>> Reviewed-by: Alexander Duyck >> >> Signed-off-by should be last. Same comment on all the other > > Hi, Shuah > > I used 'git am' to collect those tag, it seems that is the order > the tool applied, and I checking other applied commit, it seems > only Signed-off-by from the committer is the last, like the below > recent mm commit: > 6901cf55de22 > ff7f5ad7bce4 > okay. >> patches in this series. When you have 4 patches, it is a good >> practice to add cover-letter. > > I guess the cover-letter meant below? > https://lore.kernel.org/all/20241008112049.2279307-1-linyunsheng@huawei.com/ Somehow this isn't in my Inbox. > >> [snip] > ... > >>> +function run_manual_check() >>> +{ >>> +    # >>> +    # Validate passed parameters. If there is wrong one, >>> +    # the script exists and does not execute further. >>> +    # >>> +    validate_passed_args $@ >>> + >>> +    echo "Run the test with following parameters: $@" >> >> Is this marker good enough to isolate the test results in the >> dmesg? Include the test name in the message. >> >> >>> +    insmod $DRIVER $@ > /dev/null 2>&1 >>> +    echo "Done." >> >> Is this marker good enough to isolate the test results in the >> dmesg? Include the test name in the message. >> >>> +    echo "Check the kernel ring buffer to see the summary." >> >> Usually the test would run dmesg and filter out the test results >> from the dmesg and include them in the test script output. >> >> You can refer to other tests that do that: powerpc/scripts/hmi.sh >> is one example. > > Thanks, will check that. thanks, -- Shuah