From: "Zanussi, Tom" <tom.zanussi@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: peterz@infradead.org, acme@kernel.org, mingo@kernel.org,
kan.liang@linux.intel.com, dave.jiang@intel.com,
tony.luck@intel.com, dan.j.williams@intel.com,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v3 0/2] dmaengine: idxd: IDXD pmu support
Date: Fri, 23 Apr 2021 13:15:02 -0500 [thread overview]
Message-ID: <d46d7b54-7d2f-4bdc-74f2-2077409f1996@linux.intel.com> (raw)
In-Reply-To: <YIMHzx6gerPEzbKJ@vkoul-mobl.Dlink>
Hi Vinod,
On 4/23/2021 12:45 PM, Vinod Koul wrote:
> On 21-04-21, 16:04, Tom Zanussi wrote:
>> Hi,
>>
>> This is v3 of the IDXD pmu support patch, which addresses the comments
>> from Vinod:
>>
>> - Removed the default line for INTEL_IDXD_PERFMON making it default 'n'
>>
>> - Replaced #ifdef CONFIG_INTEL_IDXD_PERFMON with IS_ENABLED()
>>
>> - Split the patch into two separate patches, the perfmon
>> implementation and the code that uses it in the IDXD driver.
>>
>> - Added a new file,
>> Documentation/ABI/testing/sysfs-bus-event_source-devices-dsa that
>> documents the new format and cpumask attributes, and added better
>> comments for those in the code.
>>
>> - Changed 'dogrp' to 'do_group' in perfmon_collect_events()
>>
>> - Moved 'int idx' inside the loop in perfmon_validate_group() to the
>> top of function.
>>
>> - In perfmon_pmu_read_counter(), return ioread64() directly and get
>> rid of cntrdata.
>>
>> I also fixed some erroneous code in perfmon_counter_overflow() that
>> because of my misreading of the spec caused unintended clearing of
>> wrong bits. According to the spec you need to write 1 rather than 0
>> to an OVFSTATUS bit to clear it.
>
> Applied, thanks
>
> This conflicted with Daves patches, I managed to resolve, pls check the
> end result
>
Thanks!
However, it looks like the new files in '[PATCH v3 1/2] dmaengine: idxd: Add
IDXD performance monitor support' didn't make it in, maybe didn't get 'added'
after resolving the conflicts...
+ create mode 100644 Documentation/ABI/testing/sysfs-bus-event_source-devices-dsa
+ create mode 100644 drivers/dma/idxd/perfmon.c
+ create mode 100644 drivers/dma/idxd/perfmon.h
Tom
next prev parent reply other threads:[~2021-04-23 18:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 21:04 [PATCH v3 0/2] dmaengine: idxd: IDXD pmu support Tom Zanussi
2021-04-21 21:04 ` [PATCH v3 1/2] dmaengine: idxd: Add IDXD performance monitor support Tom Zanussi
2021-04-21 21:04 ` [PATCH v3 2/2] dmaengine: idxd: Enable " Tom Zanussi
2021-04-23 17:45 ` [PATCH v3 0/2] dmaengine: idxd: IDXD pmu support Vinod Koul
2021-04-23 18:15 ` Zanussi, Tom [this message]
2021-04-23 18:23 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d46d7b54-7d2f-4bdc-74f2-2077409f1996@linux.intel.com \
--to=tom.zanussi@linux.intel.com \
--cc=acme@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tony.luck@intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox