From: Michal Simek <michal.simek@amd.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v1 2/3] spi: xilinx: Add necessary inclusion and forward declaration
Date: Fri, 8 Mar 2024 15:02:01 +0100 [thread overview]
Message-ID: <d479cda0-3c3f-4cf7-acee-bcacbb9cc5f5@amd.com> (raw)
In-Reply-To: <ZesZKbdIo6z-AfIT@smile.fi.intel.com>
On 3/8/24 14:56, Andy Shevchenko wrote:
> On Fri, Mar 08, 2024 at 09:21:32AM +0100, Michal Simek wrote:
>> On 3/7/24 16:43, Andy Shevchenko wrote:
>>> xilinx_spi.h is mnissing inclusion and forward declaration, add them.
>
> ...
>
>>> diff --git a/include/linux/spi/xilinx_spi.h b/include/linux/spi/xilinx_spi.h
>>> #define __LINUX_SPI_XILINX_SPI_H
>>> +#include <linux/types.h>
>>> +
>>> +struct spi_board_info;
>>> +
>>> /**
>>> * struct xspi_platform_data - Platform data of the Xilinx SPI driver
>>> * @num_chipselect: Number of chip select by the IP.
>>
>> Likely correct but forget how to check it with tools.
>
> I'm not sure which tools we have to check this.
>
> The types.h is needed for uXX
> The forward declaration for the pointer to the mentioned type.
>
> All this has been derived from reading the file.
No issue with it. But I am quite sure there was a tool which was able to find it
out and report it. But forgot which one was it.
M
next prev parent reply other threads:[~2024-03-08 14:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 15:43 [PATCH v1 0/3] spi: xilinx: Massage xilinx_spi.h Andy Shevchenko
2024-03-07 15:43 ` [PATCH v1 1/3] spi: xilinx: Fix kernel documentation in the xilinx_spi.h Andy Shevchenko
2024-03-08 8:22 ` Michal Simek
2024-03-07 15:43 ` [PATCH v1 2/3] spi: xilinx: Add necessary inclusion and forward declaration Andy Shevchenko
2024-03-08 8:21 ` Michal Simek
2024-03-08 13:56 ` Andy Shevchenko
2024-03-08 14:02 ` Michal Simek [this message]
2024-03-08 15:00 ` Andy Shevchenko
2024-03-08 15:27 ` Michal Simek
2024-03-07 15:43 ` [PATCH v1 3/3] spi: xilinx: Make num_chipselect 8-bit in the struct xspi_platform_data Andy Shevchenko
2024-03-08 8:20 ` Michal Simek
2024-03-08 13:31 ` Andy Shevchenko
2024-03-08 13:48 ` Michal Simek
2024-03-08 13:55 ` Andy Shevchenko
2024-03-08 14:00 ` Michal Simek
2024-03-08 15:01 ` Andy Shevchenko
2024-03-08 15:01 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d479cda0-3c3f-4cf7-acee-bcacbb9cc5f5@amd.com \
--to=michal.simek@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox