From: Jonathan Cameron <jic23@kernel.org>
To: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing flag register
Date: Mon, 13 Mar 2017 21:33:45 +0000 [thread overview]
Message-ID: <d4955577-9524-78b7-9afb-e1ebf1438ef7@kernel.org> (raw)
In-Reply-To: <20170313133319.GA3607@sophia>
On 13/03/17 13:33, William Breathitt Gray wrote:
> On Sat, Feb 11, 2017 at 09:37:35AM +0000, Jonathan Cameron wrote:
>> On 09/02/17 15:03, William Breathitt Gray wrote:
>>> The flag register is offset by 1 from the respective channel data
>>> register. This patch fixes an off-by-one error when attempting to read a
>>> channel flag register where the base address was not properly offset.
>>>
>>> Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
>>> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
>> Applied to the fixes-togreg-post-rc1 branch of iio.git
>> Clue to when this will go upstream is in the name ;)
>>
>> Thanks,
>>
>> Jonathan
>
> Hi Jonathan,
>
> I see that this fix made it into 4.11-rc1 but not the 4.10.2 release.
> Is this patch on track to appear in stable, or should I explicitly CC
> stable@vger.kernel.org to pick this up?
I was half asleep and failed to tag this in the first place.
Send an email to stable@vger.kernel.org with the commit ID and a request
that it is picked up. Cc me.
Jonathan
>
> Thanks,
>
> William Breathitt Gray
>
>>> ---
>>> drivers/iio/counter/104-quad-8.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c
>>> index a5913e97945e..f9b8fc9ae13f 100644
>>> --- a/drivers/iio/counter/104-quad-8.c
>>> +++ b/drivers/iio/counter/104-quad-8.c
>>> @@ -76,7 +76,7 @@ static int quad8_read_raw(struct iio_dev *indio_dev,
>>> return IIO_VAL_INT;
>>> }
>>>
>>> - flags = inb(base_offset);
>>> + flags = inb(base_offset + 1);
>>> borrow = flags & BIT(0);
>>> carry = !!(flags & BIT(1));
>>>
>>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2017-03-13 21:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 15:03 [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing flag register William Breathitt Gray
2017-02-11 9:37 ` Jonathan Cameron
2017-03-13 13:33 ` William Breathitt Gray
2017-03-13 21:33 ` Jonathan Cameron [this message]
2017-03-14 15:00 ` William Breathitt Gray
2017-03-15 5:33 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4955577-9524-78b7-9afb-e1ebf1438ef7@kernel.org \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox