From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752462AbdIVOvJ (ORCPT <rfc822;w@1wt.eu>);
        Fri, 22 Sep 2017 10:51:09 -0400
Received: from mout.web.de ([212.227.17.12]:60814 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751873AbdIVOvH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 22 Sep 2017 10:51:07 -0400
Subject: Re: [PATCH 2/4] [media] usbvision-core: Use common error handling
 code in usbvision_set_compress_params()
To: Dan Carpenter <dan.carpenter@oracle.com>, linux-media@vger.kernel.org
Cc: Davidlohr Bueso <dave@stgolabs.net>, Hans Verkuil <hverkuil@xs4all.nl>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <c0e6e8e7-e47d-dc88-3317-2e46eaa51dc6@users.sourceforge.net>
 <52c09836-83d7-c509-6e85-c7af16160302@users.sourceforge.net>
 <20170922114432.x4e2ao22spbyek7n@mwanda>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <d4ab8049-0be4-6183-3cbd-5bc03968c2a4@users.sourceforge.net>
Date: Fri, 22 Sep 2017 16:50:07 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170922114432.x4e2ao22spbyek7n@mwanda>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:zaKD1Dk1Ds2vaW+IidW6PU0a1o/BqWMuUu2huIwEW61Sb6n3dK7
 4oeY0OylWG1BNZJ6oglmJncFVEi6fNb1oWA4mVHTTiiOWKP1edeeZawH3abr4dfdDc74wvR
 gnXAaKMOlujfPdxmSpEqZhZmSfKkBxIzRDqZNiEH9bff9j3Hp/jiDnY/Z18ojhr3EYg9BzU
 RcOYroHbYkM5SdmNXiuRg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:bBrLgUSXpug=:zyy+d5kSbrpLk6On0nw2TP
 Jr7G6MGDGjUWNM4B8VaJ68itobsTNOcxzsKKzGMcLcBXY0HqWZhf9/26JDO279J5PxojXPF+2
 nct/4I27fETcLEUyHLVb6UkBF/syARm4462i5k0a5stJ3YXm8AAsx+am0ABOZNIUXlTsTA5Wv
 V0zhEyaGUX/usWErfBnsY/Y+nl7HxwOwnywMHL1Ir9LCLcS2XOP+4TsNG+yqWuTtJGhKQE8sy
 /kbN3gzjhMIW5HnZQ/vlDS0oyE0AthIHgTOf212tr5PieVN7xPRsQxQc+JkNnqnjm9iOjDdnC
 llaZFp+G1ssRDsJEcyuJdAY8ejkw6s8/ZlM/yG4chc5jS832u8erLli6AHflipPfIM3ffFob+
 5PiH9U0Bu7wPeJi44DgeaJTSnZ7Ea2I617hVguBJdzQjkhnygJg8v8w+9mBo+75mWoJK7S9nN
 c2oGV6evecgclMeCle4p1ZzF5fkUmdgAfz2lP4Hcu8KV/sFmsiK1kMnYDYSmbXSegnJa9suHD
 L1wEN1KPPbnjPxR4LkKyEHHBqEF9oH8gEf57yTZUJR4IqOroCKtycwVQ55xSg7lbMi4W+oNHb
 +wTVgx7q9PPlGana7ps8pBHXFuWi7D/tuLsPaYfLrO47JVmCbDSZSaEZ4XQktdQ0A8wk1VIeY
 10G0zHhwttOrDi07h6yJXBG9N/uqbczjE2e0tWbKjbNE89zXHnME3PT8T36b65D4iJbct1sI+
 MyM2BNwG+CkcL9oRIHtIoOrf9m3uvrJWv9/daZdsP3Z4UUmzDWcVByiZ9Jb7fKDhXbaREu3Fi
 XduyVtjTjsoDyFXv4K6kFIaWWhOgsvfHL86YOZ0XqtVwD4Kkxs=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -1913,11 +1908,12 @@ static int usbvision_set_compress_params(struct usb_usbvision *usbvision)
>>  			     USB_DIR_OUT | USB_TYPE_VENDOR |
>>  			     USB_RECIP_ENDPOINT, 0,
>>  			     (__u16) USBVISION_PCM_THR1, value, 6, HZ);
>> +	if (rc < 0)
>> +report_failure:
>> +		dev_err(&usbvision->dev->dev,
>> +			"%s: ERROR=%d. USBVISION stopped - reconnect or reload driver.\n",
>> +			__func__, rc);
> 
> You've been asked several times not to write code like this.

This suggestion occurred a few times.

Do you prefer to move this place to the end together with a duplicated statement “return rc;”?


> You do it later in the patch series as well.

To which update step do you refer here?

Regards,
Markus