From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 979A126A0D0; Mon, 16 Jun 2025 08:41:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750063273; cv=none; b=i+4CmqEhK1ocJPlnrNEOEEv2JH5mr09EGCJzvkN0OlozMJYH1Q9qlhGMh4folvbPEqAmu6PJIsBD9OD5J0redp6P9icd0xvsbngXM7wGKf6IaA6Mj9931kJnyhL781qnksH6dlcrwn02N1/TKNhRriOENvRTL37g5/BOMfpIe+w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750063273; c=relaxed/simple; bh=lUTBn9nVP14ZgUwJZjdfYcXIiimg5PSNeqjhn/Mf/Mk=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=n2jrctwEqWYuoDsIADGyjd2C864mSbJoW0bBG05tEhzYbkUl5FoA3cxPLFK8SLMFQE1/arEXX85b3wC9DGoucZgj1mfj1q4g/fJasKyPjTTrYzn7MAKj6dMtTucI3i3JgYUJfSonKMyP1TMeCJ2WA+gpgk7VyXyrbK2zxM9UF3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=oEpep69V; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="oEpep69V" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55G8SCWE010944; Mon, 16 Jun 2025 08:41:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GcaXA6aB85PzCjRP4tvAHFHa54YRrnAuJaIwm6JHCRc=; b=oEpep69VUw6phu/7 Evh1Dp1hq1pAqYGE4ejRaBhmiMUrFkNXZdLUcymyWNM0LAqCWoMhOvnIod8DA+vl +xZ6QKMCzHInuD16Tn6gKrUVenBLLieAPWLB1U00sda8qfeoeufkbWem2yxc+lw5 NivSAxhtYUBSZcV2PupTArnH4Hp91YIhx72U6FV+70KfmBNXx/z6Cml3KRbACCE9 6NXHRKDc7BriBPGhIKfWFkNXfvMumihZ+tNiLFRh2t35FTGHmMGZWYkRo1PNQGGo BHEupfuTKpCkiQ/ddmNY6CXUc6vPGwsrnZbMIqep5AMgym5Ne/SsjrW3EDjmYr/W Y7XqAQ== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 479qp5jcyc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Jun 2025 08:41:05 +0000 (GMT) Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 55G8f5Gq015236 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Jun 2025 08:41:05 GMT Received: from [10.218.32.171] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 16 Jun 2025 01:40:24 -0700 Message-ID: Date: Mon, 16 Jun 2025 14:10:21 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 3/8] soc: qcom: geni-se: Enable QUPs on SA8255p Qualcomm platforms To: Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , , , , , "Bryan O'Donoghue" CC: , , , , , , References: <20250606172114.6618-1-quic_ptalari@quicinc.com> <20250606172114.6618-4-quic_ptalari@quicinc.com> Content-Language: en-US From: Praveen Talari In-Reply-To: <20250606172114.6618-4-quic_ptalari@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: DFnzH0vnnRKyPiwfYK5whr4pyn5qPuMJ X-Proofpoint-ORIG-GUID: DFnzH0vnnRKyPiwfYK5whr4pyn5qPuMJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjE2MDA1NiBTYWx0ZWRfXyu4JYWNJkCWh +PYjHkkloWskcOaKFlkvMtgS5YgY24s+RLLPsrEd3DLc0rD/I9dTcuoaqQvoS1y/9m9e3610Xr4 sveF7eISNXUi+1mdIz77ryhWydkGpAT1quk53oN33oWxE3WoQPz1FA2MfyZlbpN4GteopNjO21O Rf545lLPYsFhRrvdYcxNZ6XhXhOGtsmLLSq3MUdeClritwtW2QbhwAiGix+jIMEC9OhwsDtHfSB dm5WeA0LBdXbRupKyQekiUrMWPFxsNYYTvWHhd3QItPaGY+Mu9kJli0SfUFtprKvwqZBVlSlW9v JOcIORHHkG/yyIu7HQesRbVcSzX1v3YMX24zcif19Se8ScnTmSukwkV3OEUJ8fAyECcmBK7fVPL QRCCYWLmeRBn+pOEfHWIaEpwDyfQU+Q+p8D6+qvj7GFx65AR4eYyfnHq0fQ4nYqLkKgBAG9m X-Authority-Analysis: v=2.4 cv=fMc53Yae c=1 sm=1 tr=0 ts=684fd8a1 cx=c_pps a=JYp8KDb2vCoCEuGobkYCKw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=COk6AnOGAAAA:8 a=_oO_JE4s1IoPHfOlYPIA:9 a=QEXdDO2ut3YA:10 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-16_03,2025-06-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 bulkscore=0 clxscore=1015 malwarescore=0 mlxlogscore=999 spamscore=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 priorityscore=1501 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506160056 Hi Bryan, Gentle reminder!! Thanks, Praveen talari On 6/6/2025 10:51 PM, Praveen Talari wrote: > On the sa8255p platform, resources such as clocks,interconnects > and TLMM (GPIO) configurations are managed by firmware. > > Introduce a platform data function callback to distinguish whether > resource control is performed by firmware or directly by the driver > in linux. > > The refactor ensures clear differentiation of resource > management mechanisms, improving maintainability and flexibility > in handling platform-specific configurations. > > Signed-off-by: Praveen Talari > --- > v5 -> v6 > - replaced dev_err with dev_err_probe > - added a check for desc->num_clks with MAX_CLKS, an error if > the specified num_clks in descriptor exceeds defined MAX_CLKS. > - removed min_t which is not necessary. > - renamed callback function names to resources_init. > - resolved kernel bot warning error by documenting function > pointer in geni_se_desc structure. > > v3 -> v4 > - declared an empty struct for sa8255p and added check as num clks. > - Added version log after --- > > v1 -> v2 > - changed datatype of i from int to unsigned int as per comment. > --- > drivers/soc/qcom/qcom-geni-se.c | 77 +++++++++++++++++++++------------ > 1 file changed, 49 insertions(+), 28 deletions(-) > > diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c > index 4cb959106efa..5c727b9a17e9 100644 > --- a/drivers/soc/qcom/qcom-geni-se.c > +++ b/drivers/soc/qcom/qcom-geni-se.c > @@ -101,10 +101,13 @@ struct geni_wrapper { > * struct geni_se_desc - Data structure to represent the QUP Wrapper resources > * @clks: Name of the primary & optional secondary AHB clocks > * @num_clks: Count of clock names > + * @resources_init: Function pointer for initializing QUP Wrapper resources > */ > struct geni_se_desc { > unsigned int num_clks; > const char * const *clks; > + int (*resources_init)(struct geni_wrapper *wrapper, > + const struct geni_se_desc *desc); > }; > > static const char * const icc_path_names[] = {"qup-core", "qup-config", > @@ -891,10 +894,47 @@ int geni_icc_disable(struct geni_se *se) > } > EXPORT_SYMBOL_GPL(geni_icc_disable); > > +static int geni_se_resource_init(struct geni_wrapper *wrapper, > + const struct geni_se_desc *desc) > +{ > + struct device *dev = wrapper->dev; > + int ret; > + unsigned int i; > + > + if (desc->num_clks > MAX_CLKS) > + return dev_err_probe(dev, -EINVAL, > + "Too many clocks specified in descriptor:%u (max allowed: %u)\n", > + desc->num_clks, MAX_CLKS); > + > + wrapper->num_clks = desc->num_clks; > + > + for (i = 0; i < wrapper->num_clks; ++i) > + wrapper->clks[i].id = desc->clks[i]; > + > + ret = of_count_phandle_with_args(dev->of_node, "clocks", "#clock-cells"); > + if (ret < 0) > + return dev_err_probe(dev, ret, "invalid clocks property at %pOF\n", dev->of_node); > + > + if (ret < wrapper->num_clks) { > + dev_err(dev, "invalid clocks count at %pOF, expected %d entries\n", > + dev->of_node, wrapper->num_clks); > + return -EINVAL; > + } > + > + ret = devm_clk_bulk_get(dev, wrapper->num_clks, wrapper->clks); > + if (ret) { > + dev_err(dev, "Err getting clks %d\n", ret); > + return ret; > + } > + > + return ret; > +} > + > static int geni_se_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct geni_wrapper *wrapper; > + const struct geni_se_desc *desc; > int ret; > > wrapper = devm_kzalloc(dev, sizeof(*wrapper), GFP_KERNEL); > @@ -906,36 +946,12 @@ static int geni_se_probe(struct platform_device *pdev) > if (IS_ERR(wrapper->base)) > return PTR_ERR(wrapper->base); > > - if (!has_acpi_companion(&pdev->dev)) { > - const struct geni_se_desc *desc; > - int i; > - > - desc = device_get_match_data(&pdev->dev); > - if (!desc) > - return -EINVAL; > - > - wrapper->num_clks = min_t(unsigned int, desc->num_clks, MAX_CLKS); > - > - for (i = 0; i < wrapper->num_clks; ++i) > - wrapper->clks[i].id = desc->clks[i]; > - > - ret = of_count_phandle_with_args(dev->of_node, "clocks", "#clock-cells"); > - if (ret < 0) { > - dev_err(dev, "invalid clocks property at %pOF\n", dev->of_node); > - return ret; > - } > + desc = device_get_match_data(&pdev->dev); > > - if (ret < wrapper->num_clks) { > - dev_err(dev, "invalid clocks count at %pOF, expected %d entries\n", > - dev->of_node, wrapper->num_clks); > + if (!has_acpi_companion(&pdev->dev) && desc->num_clks) { > + ret = desc->resources_init(wrapper, desc); > + if (ret) > return -EINVAL; > - } > - > - ret = devm_clk_bulk_get(dev, wrapper->num_clks, wrapper->clks); > - if (ret) { > - dev_err(dev, "Err getting clks %d\n", ret); > - return ret; > - } > } > > dev_set_drvdata(dev, wrapper); > @@ -951,8 +967,11 @@ static const char * const qup_clks[] = { > static const struct geni_se_desc qup_desc = { > .clks = qup_clks, > .num_clks = ARRAY_SIZE(qup_clks), > + .resources_init = geni_se_resource_init, > }; > > +static const struct geni_se_desc sa8255p_qup_desc; > + > static const char * const i2c_master_hub_clks[] = { > "s-ahb", > }; > @@ -960,11 +979,13 @@ static const char * const i2c_master_hub_clks[] = { > static const struct geni_se_desc i2c_master_hub_desc = { > .clks = i2c_master_hub_clks, > .num_clks = ARRAY_SIZE(i2c_master_hub_clks), > + .resources_init = geni_se_resource_init, > }; > > static const struct of_device_id geni_se_dt_match[] = { > { .compatible = "qcom,geni-se-qup", .data = &qup_desc }, > { .compatible = "qcom,geni-se-i2c-master-hub", .data = &i2c_master_hub_desc }, > + { .compatible = "qcom,sa8255p-geni-se-qup", .data = &sa8255p_qup_desc }, > {} > }; > MODULE_DEVICE_TABLE(of, geni_se_dt_match);