From: Saito Hideo <hsaito.ppc@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: can't flush tlb on e500
Date: Wed, 20 May 2009 19:12:29 +0900 [thread overview]
Message-ID: <d50492d40905200312r729608a3nf244b153892ac257@mail.gmail.com> (raw)
It seems that the code for powerpc with e500 on linux-2.6.29 has an
regression, because I can't execute hackbench on my platform. I
apologize if already reported.
For example, following message was asserted, however the command is
done successfully if the number given to hackbench is small.
% ./hackbench 20
SERVER: read (error: Bad file descriptor)
% ./hackbench 4
%
I think that the tlb should be cleared before mm->context.id is set
MMU_NO_CONTEXT.
--- arch/powerpc/mm/mmu_context_nohash.c.orig 2009-03-24
08:12:14.000000000 +0900
+++ arch/powerpc/mm/mmu_context_nohash.c 2009-05-20 18:33:53.000000000 +0900
@@ -122,22 +122,22 @@ static unsigned int steal_context_up(uns
struct mm_struct *mm;
int cpu = smp_processor_id();
/* Pick up the victim mm */
mm = context_mm[id];
pr_debug("[%d] steal context %d from mm @%p\n", cpu, id, mm);
- /* Mark this mm has having no context anymore */
- mm->context.id = MMU_NO_CONTEXT;
-
/* Flush the TLB for that context */
local_flush_tlb_mm(mm);
+ /* Mark this mm has having no context anymore */
+ mm->context.id = MMU_NO_CONTEXT;
+
/* XXX This clear should ultimately be part of local_flush_tlb_mm */
__clear_bit(id, stale_map[cpu]);
return id;
}
#ifdef DEBUG_MAP_CONSISTENCY
static void context_check_map(void)
next reply other threads:[~2009-05-20 10:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 10:12 Saito Hideo [this message]
2009-05-22 0:57 ` can't flush tlb on e500 Hideo Saito
2009-05-22 9:20 ` Benjamin Herrenschmidt
2009-05-22 9:27 ` Benjamin Herrenschmidt
2009-05-22 9:42 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d50492d40905200312r729608a3nf244b153892ac257@mail.gmail.com \
--to=hsaito.ppc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).