From: Frank Rowand <frowand.list@gmail.com>
To: Vaishnav M A <vaishnav@beagleboard.org>,
greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, arnd@arndb.de, johan@kernel.org,
elder@kernel.org, Frank Rowand <frowand.list@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: robh@kernel.org, mchehab+huawei@kernel.org, davem@davemloft.net,
jkridner@beagleboard.org, drew@beagleboard.org,
robertcnelson@beagleboard.org, rajkovic@mikroe.com,
chrisfriedt@gmail.com, zoran.stojsavljevic@gmail.com
Subject: Re: [RFC PATCH v2 0/3] mikroBUS driver for add-on boards
Date: Tue, 18 Aug 2020 15:38:00 -0500 [thread overview]
Message-ID: <d53f0014-db7c-902c-70c7-eacac41cc6ed@gmail.com> (raw)
In-Reply-To: <20200818124815.11029-1-vaishnav@beagleboard.org>
Hi Vaishnav,
+me +devicetree
Please add these two recipients to future versions.
I will comment more after reading the first version and v2.
-Frank
On 2020-08-18 07:48, Vaishnav M A wrote:
> Hi,
>
> This Patch series is an update to the mikroBUS driver
> RFC v1 Patch : https://lkml.org/lkml/2020/7/24/518 .
> The mikrobus driver is updated to add mikrobus ports from device-tree
> overlays, the debug interfaces for adding mikrobus ports through sysFS
> is removed, and the driver considers the extended usage of mikrobus
> port pins from their standard purposes.
>
> change log:
> v2: support for adding mikroBUS ports from DT overlays,
> remove debug sysFS interface for adding mikrobus ports,
> consider extended pin usage/deviations from mikrobus standard
> specifications,
> use greybus CPort protocol enum instead of new protcol enums
> Fix cases of wrong indendation, ignoring return values, freeing
> allocated resources in case of errors and other style suggestions
> in v1 review.
>
> Vaishnav M A (3):
> add mikrobus descriptors to greybus_manifest
> mikroBUS driver for add-on boards on mikrobus ports
> Add Device Tree Bindings for mikroBUS port
>
> .../bindings/misc/linux,mikrobus.txt | 81 ++
> MAINTAINERS | 6 +
> drivers/misc/Kconfig | 1 +
> drivers/misc/Makefile | 1 +
> drivers/misc/mikrobus/Kconfig | 16 +
> drivers/misc/mikrobus/Makefile | 7 +
> drivers/misc/mikrobus/mikrobus_core.c | 692 ++++++++++++++++++
> drivers/misc/mikrobus/mikrobus_core.h | 191 +++++
> drivers/misc/mikrobus/mikrobus_manifest.c | 444 +++++++++++
> drivers/misc/mikrobus/mikrobus_manifest.h | 21 +
> drivers/misc/mikrobus/mikrobus_port.c | 171 +++++
> include/linux/greybus/greybus_manifest.h | 47 ++
> 12 files changed, 1678 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/misc/linux,mikrobus.txt
> create mode 100644 drivers/misc/mikrobus/Kconfig
> create mode 100644 drivers/misc/mikrobus/Makefile
> create mode 100644 drivers/misc/mikrobus/mikrobus_core.c
> create mode 100644 drivers/misc/mikrobus/mikrobus_core.h
> create mode 100644 drivers/misc/mikrobus/mikrobus_manifest.c
> create mode 100644 drivers/misc/mikrobus/mikrobus_manifest.h
> create mode 100644 drivers/misc/mikrobus/mikrobus_port.c
>
next prev parent reply other threads:[~2020-08-18 20:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 12:48 [RFC PATCH v2 0/3] mikroBUS driver for add-on boards Vaishnav M A
2020-08-18 12:48 ` [RFC PATCH v2 1/3] add mikrobus descriptors to greybus_manifest Vaishnav M A
2020-08-20 0:49 ` Vaishnav M A
2020-08-31 6:26 ` Zoran Stojsavljevic
2020-09-01 8:33 ` Vaishnav M A
2020-08-18 12:48 ` [RFC PATCH v2 2/3] mikroBUS driver for add-on boards on mikrobus ports Vaishnav M A
2020-08-18 12:48 ` [RFC PATCH v2 3/3] Add Device Tree Bindings for mikroBUS port Vaishnav M A
2020-08-18 13:35 ` [greybus-dev] " Laurent Pinchart
2020-08-18 21:22 ` Vaishnav M A
2020-08-27 15:45 ` Rob Herring
2020-08-18 15:24 ` [RFC PATCH v2 0/3] mikroBUS driver for add-on boards Greg KH
2020-08-18 21:52 ` Vaishnav M A
2020-08-19 5:54 ` Greg KH
2020-08-18 20:38 ` Frank Rowand [this message]
2020-08-18 21:56 ` Vaishnav M A
2020-08-25 1:44 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d53f0014-db7c-902c-70c7-eacac41cc6ed@gmail.com \
--to=frowand.list@gmail.com \
--cc=arnd@arndb.de \
--cc=chrisfriedt@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=drew@beagleboard.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=jkridner@beagleboard.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=rajkovic@mikroe.com \
--cc=robertcnelson@beagleboard.org \
--cc=robh@kernel.org \
--cc=vaishnav@beagleboard.org \
--cc=zoran.stojsavljevic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox