public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@linux.intel.com>
To: "Christian König" <christian.koenig@amd.com>,
	amd-gfx@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amdgpu: fix zero-size GDS range init on RDNA4
Date: Tue, 21 Apr 2026 04:54:24 -0700	[thread overview]
Message-ID: <d551bc50-e14d-4664-8df3-8fdd377e09c8@linux.intel.com> (raw)
In-Reply-To: <34718f21-712a-4161-98e0-079dd9390ae6@amd.com>

On 4/20/2026 11:42 PM, Christian König wrote:
> On 4/20/26 23:57, arjan@linux.intel.com wrote:
>>
>> RDNA4 (GFX 12) hardware removes the GDS, GWS, and OA on-chip memory
>> resources. The gfx_v12_0 initialisation code correctly leaves
>> adev->gds.gds_size, adev->gds.gws_size, and adev->gds.oa_size at
>> zero to reflect this.
>>
>> amdgpu_ttm_init() unconditionally calls amdgpu_ttm_init_on_chip() for
>> each of these resources regardless of size. When the size is zero,
>> amdgpu_ttm_init_on_chip() forwards the call to ttm_range_man_init(),
>> which calls drm_mm_init(mm, 0, 0). drm_mm_init() immediately fires
>> DRM_MM_BUG_ON(start + size <= start) -- trivially true when size is
>> zero -- crashing the kernel during modprobe of amdgpu on an RX 9070 XT.
> 
> Mhm in general not a bad idea, but we are having tons of GFX 12 systems in our test machines and nothing is crashing there.
> 
> We are clearly missing something here. Is that on an upstream kernel or something backported?
> 

the reported oops/etc say 6.18.22 so that does not sound like something crazy backported

(https://bugzilla.kernel.org/show_bug.cgi?id=221376)



  reply	other threads:[~2026-04-21 11:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-221376-2300@https.bugzilla.kernel.org/>
2026-04-20 21:57 ` [PATCH] drm/amdgpu: fix zero-size GDS range init on RDNA4 arjan
2026-04-21  6:42   ` Christian König
2026-04-21 11:54     ` Arjan van de Ven [this message]
2026-04-21 13:42     ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d551bc50-e14d-4664-8df3-8fdd377e09c8@linux.intel.com \
    --to=arjan@linux.intel.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox