From: Jacob Keller <jacob.e.keller@intel.com>
To: Michael Chan <michael.chan@broadcom.com>,
Arnd Bergmann <arnd@kernel.org>
Cc: Pavan Chebbi <pavan.chebbi@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,
"Andy Gospodarek" <andrew.gospodarek@broadcom.com>,
Arnd Bergmann <arnd@arndb.de>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Simon Horman <horms@kernel.org>, Taehee Yoo <ap420073@gmail.com>,
David Wei <dw@davidwei.uk>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bnxt_en: hide CONFIG_DETECT_HUNG_TASK specific code
Date: Wed, 23 Apr 2025 15:10:55 -0700 [thread overview]
Message-ID: <d554487a-a328-42af-8dc3-16dcac127663@intel.com> (raw)
In-Reply-To: <CACKFLimF7defCWyxtRs1x+jtSD7O-+nBq+tQHUMpQ8GK=48tWA@mail.gmail.com>
On 4/23/2025 10:28 AM, Michael Chan wrote:
> On Wed, Apr 23, 2025 at 9:28 AM Arnd Bergmann <arnd@kernel.org> wrote:
>>
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The CONFIG_DEFAULT_HUNG_TASK_TIMEOUT setting is only available when the
>> hung task detection is enabled, otherwise the code now produces a build
>> failure:
>>
>> drivers/net/ethernet/broadcom/bnxt/bnxt.c:10188:21: error: use of undeclared identifier 'CONFIG_DEFAULT_HUNG_TASK_TIMEOUT'
>> 10188 | max_tmo_secs > CONFIG_DEFAULT_HUNG_TASK_TIMEOUT) {
>>
>> Enclose this warning logic in an #ifdef to ensure this builds.
>>
>> Fixes: 0fcad44a86bd ("bnxt_en: Change FW message timeout warning")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> I also cannot think of a better way, so this looks fine to me. Thanks.
> Reviewed-by: Michael Chan <michael.chan@broadcom.com>
I ran into this just now, and this fixed compilation for me.
Tested-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2025-04-23 22:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 16:28 [PATCH] bnxt_en: hide CONFIG_DETECT_HUNG_TASK specific code Arnd Bergmann
2025-04-23 17:28 ` Michael Chan
2025-04-23 22:10 ` Jacob Keller [this message]
2025-04-23 22:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d554487a-a328-42af-8dc3-16dcac127663@intel.com \
--to=jacob.e.keller@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew.gospodarek@broadcom.com \
--cc=ap420073@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox