Re: [PATCH v4 2/4] KVM: s390: vsie: Fix length of facility list shadowed

Janosch Frank
2023-12-20T10:45:07Z

On 12/19/23 15:08, Nina Schoetterl-Glausch wrote:
> The length of the facility list accessed when interpretively executing
> STFLE is the same as the hosts facility list (in case of format-0)
> The memory following the facility list doesn't need to be accessible.
> The current VSIE implementation accesses a fixed length that exceeds the
> guest/host facility list length and can therefore wrongly inject a
> validity intercept.
> Instead, find out the host facility list length by running STFLE and
> copy only as much as necessary when shadowing.
>
> Acked-by: David Hildenbrand <david@redhat.com>
> Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> Acked-by: Heiko Carstens <hca@linux.ibm.com>
> Signed-off-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>

Reviewed-by: Janosch Frank <frankja@linux.ibm.com>