Re: [PATCH 2/3] PCI/IDE: Add Address Association Register setup for RP

dan.j.williams
2025-10-02T15:58:48Z

Ilpo Järvinen wrote:
[..]
> > > @@ -206,6 +210,24 @@ struct pci_ide *pci_ide_stream_alloc(struct pci_dev *pdev)
> > > else
> > > rid_end = pci_dev_id(pdev);
> > >
> > > + br = pci_upstream_bridge(pdev);
> > > + if (!br)
> > > + return NULL;
> > > +
> > > + res = &br->resource[PCI_BRIDGE_MEM_WINDOW];
> > > + if (res->flags & IORESOURCE_MEM) {
> >
> > Per Ilpo this can now just be a size check.
>
> I don't know why you said this about size as you implemented it below
> correctly using res->parent check (inside resource_assigned()).

Oh, stale comment. I wrote this, then read your suggestion about
resource_assigned(), updated the proposed patch, but failed to come back
and adjust this stale comment.

Sorry for the confusion.