From: Florian Eckert <fe@dev.tdt.de>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Lee Jones <lee@kernel.org>,
Eckert.Florian@googlemail.com, gregkh@linuxfoundation.org,
pavel@ucw.cz, kabel@kernel.org, u.kleine-koenig@pengutronix.de,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-leds@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2 3/4] trigger: ledtrig-tty: move variable definition to the top
Date: Wed, 04 Oct 2023 10:36:09 +0200 [thread overview]
Message-ID: <d59855493baa936485a2b00aa29d0449@dev.tdt.de> (raw)
In-Reply-To: <05b03f3e-5863-4d33-8c70-03be7d7e972f@kernel.org>
>> I decided to move the variable definition with a separate commit
>> to the top of the function, to make the build robot happy. After that
>> I made my changes for v2 to the ledtrig-tty to add the feature.
>>
>>> Ah, lkp, then also the Closes: line as it suggests.
>>
>> Sorry I do not understand your statement
>
> The link you pasted above states:
> =======
> If you fix the issue in a separate patch/commit (i.e. not just a new
> version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes:
> https://lore.kernel.org/oe-kbuild-all/202309270440.IJB24Xap-lkp@intel.com/
> =======
>
> So please follow that suggestion ;).
Ok, I understand, thanks will to this on a v3 patchset.
I will now wait for the comments of my changes in ledtrig-tty from the
led subsystem.
And then I will send a new patch set with the requested changes.
Sorry for the silly question. But do I have to send this patch again for
a v3?
https://lore.kernel.org/linux-leds/f41dc1e1-6d34-48b2-97dd-ba67df6003c6@kernel.org/T/#u
It was already marked by you with a `Reviewed-by:` from you?
--
Best regards
Florian
next prev parent reply other threads:[~2023-10-04 8:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 13:26 [PATCH v2 0/4] ledtrig-tty: add new state evaluation Florian Eckert
2023-09-28 13:26 ` [PATCH v2 1/4] tty: whitespaces in descriptions corrected by replacing tabs with spaces Florian Eckert
2023-10-02 9:21 ` Jiri Slaby
2023-09-28 13:26 ` [PATCH v2 2/4] tty: add new helper function tty_get_tiocm Florian Eckert
2023-09-28 13:26 ` [PATCH v2 3/4] trigger: ledtrig-tty: move variable definition to the top Florian Eckert
2023-10-02 10:26 ` Jiri Slaby
2023-10-02 14:05 ` Lee Jones
2023-10-03 5:00 ` Jiri Slaby
2023-10-04 6:37 ` Florian Eckert
2023-10-04 8:23 ` Jiri Slaby
2023-10-04 8:36 ` Florian Eckert [this message]
2023-10-04 8:43 ` Jiri Slaby
2023-10-05 7:38 ` Greg KH
2023-10-05 10:13 ` Lee Jones
2023-10-05 10:40 ` Greg KH
2023-10-05 10:41 ` Lee Jones
2023-10-11 6:58 ` Florian Eckert
2023-10-12 9:21 ` Lee Jones
2023-09-28 13:26 ` [PATCH v2 4/4] trigger: ledtrig-tty: add new line mode to triggers Florian Eckert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d59855493baa936485a2b00aa29d0449@dev.tdt.de \
--to=fe@dev.tdt.de \
--cc=Eckert.Florian@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kabel@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox