From: "Kuppuswamy, Sathyanarayanan" <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Sinan Kaya <okaya@kernel.org>, Bjorn Helgaas <helgaas@kernel.org>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, ashok.raj@intel.com,
Jay Vosburgh <jay.vosburgh@canonical.com>
Subject: Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call
Date: Wed, 23 Sep 2020 19:04:37 -0700 [thread overview]
Message-ID: <d5aa53dc-0c94-e57a-689a-1c1f89787af1@linux.intel.com> (raw)
In-Reply-To: <3d27d0a4-2115-fa72-8990-a84910e4215f@kernel.org>
On 9/23/20 6:15 PM, Sinan Kaya wrote:
> On 9/22/2020 7:44 PM, Kuppuswamy, Sathyanarayanan wrote:
>>> here does the restore happen here? I.e., what function does this?
>>
>> DLLSC link down event will remove affected devices/drivers. And link up
>> event
>> will re-create all devices.
>>
>> on DLLSC link down event
>> ->pciehp_ist()
>> ->pciehp_handle_presence_or_link_change()
>> ->pciehp_disable_slot()
>> ->__pciehp_disable_slot()
>> ->remove_board()
>> ->pciehp_unconfigure_device()
>>
>> on DLLSC link up event
>> ->pciehp_ist()
>> ->pciehp_handle_presence_or_link_change()
>> ->pciehp_enable_slot()
>> ->__pciehp_enable_slot()
>> ->board_added()
>> ->pciehp_configure_device()
>
> AFAIK, DLLSC is a requirement not optional. Why is this not supported by
> non-hotplug ports?
Its required for hotplug capable ports. Please check PCIe spec v5.0 sec 6.7.3.3.
The Data Link Layer State Changed event provides an indication that the state of
the Data Link Layer Link Active bit in the Link Status Register has changed.
Support for Data Link Layer State Changed events and software notification of these
events are required for hot-plug capable Downstream Ports.
>
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
next prev parent reply other threads:[~2020-09-24 2:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3cad1a07-509b-ef51-f635-71def2ff8293@linux.intel.com>
2020-09-22 23:33 ` [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call Bjorn Helgaas
2020-09-22 23:44 ` Kuppuswamy, Sathyanarayanan
2020-09-24 1:15 ` Sinan Kaya
2020-09-24 2:04 ` Kuppuswamy, Sathyanarayanan [this message]
2020-09-24 2:16 ` Sinan Kaya
2020-09-24 2:51 ` Kuppuswamy, Sathyanarayanan
2020-09-24 3:13 ` Sinan Kaya
2020-09-24 4:06 ` Kuppuswamy, Sathyanarayanan
2020-09-24 20:52 ` Sinan Kaya
2020-09-25 5:11 ` Kuppuswamy, Sathyanarayanan
2020-09-25 16:55 ` Sinan Kaya
2020-09-25 17:11 ` Kuppuswamy, Sathyanarayanan
2020-09-25 17:47 ` Sinan Kaya
2020-09-25 18:16 ` Kuppuswamy, Sathyanarayanan
2020-09-25 18:30 ` Sinan Kaya
2020-09-28 2:43 ` Kuppuswamy, Sathyanarayanan
2020-09-28 8:41 ` Ethan Zhao
2020-09-28 11:17 ` Sinan Kaya
2020-09-28 12:16 ` Sinan Kaya
2020-09-28 17:15 ` Kuppuswamy, Sathyanarayanan
2020-09-28 18:02 ` Sinan Kaya
2020-09-28 18:25 ` Sinan Kaya
2020-09-28 18:32 ` Kuppuswamy, Sathyanarayanan
2020-10-12 5:13 ` Kuppuswamy, Sathyanarayanan
2020-10-12 14:51 ` Sinan Kaya
2020-09-28 12:11 ` Sinan Kaya
2020-09-25 23:50 ` Sinan Kaya
2020-07-24 19:07 sathyanarayanan.kuppuswamy
2020-09-01 5:41 ` Kuppuswamy, Sathyanarayanan
2020-09-22 18:52 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5aa53dc-0c94-e57a-689a-1c1f89787af1@linux.intel.com \
--to=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jay.vosburgh@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox