public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: hanyu001@208suo.com
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] myri10ge: Prefer unsigned int to bare use of unsigned
Date: Mon, 17 Jul 2023 10:27:56 +0800	[thread overview]
Message-ID: <d5ac1bb7a79b43c8349cf9012671791d@208suo.com> (raw)
In-Reply-To: <tencent_6D5BA78E96792524AFC51045DB50A6203907@qq.com>

Fix checkpatch warnings:

./drivers/net/ethernet/myricom/myri10ge/myri10ge.c:572: WARNING: Prefer 
'unsigned int' to bare use of 'unsigned'
./drivers/net/ethernet/myricom/myri10ge/myri10ge.c:579: WARNING: Prefer 
'unsigned int' to bare use of 'unsigned'
./drivers/net/ethernet/myricom/myri10ge/myri10ge.c:614: WARNING: Prefer 
'unsigned int' to bare use of 'unsigned'

Signed-off-by: maqimei <2433033762@qq.com>
---
  drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c 
b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
index 65d7057..8de2e5e 100644
--- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
+++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
@@ -569,14 +569,14 @@ static void myri10ge_dummy_rdma(struct 
myri10ge_priv *mgp, int enable)

  static int myri10ge_load_hotplug_firmware(struct myri10ge_priv *mgp, 
u32 * size)
  {
-    unsigned crc, reread_crc;
+    unsigned int crc, reread_crc;
      const struct firmware *fw;
      struct device *dev = &mgp->pdev->dev;
      unsigned char *fw_readback;
      struct mcp_gen_header *hdr;
      size_t hdr_offset;
      int status;
-    unsigned i;
+    unsigned int i;

      if (request_firmware(&fw, mgp->fw_name, dev) < 0) {
          dev_err(dev, "Unable to load %s firmware image via hotplug\n",
@@ -611,7 +611,7 @@ static int myri10ge_load_hotplug_firmware(struct 
myri10ge_priv *mgp, u32 * size)
      for (i = 0; i < fw->size; i += 256) {
          myri10ge_pio_copy(mgp->sram + MYRI10GE_FW_OFFSET + i,
                    fw->data + i,
-                  min(256U, (unsigned)(fw->size - i)));
+                  min(256U, (unsigned int)(fw->size - i)));
          mb();
          readb(mgp->sram);
      }

       reply	other threads:[~2023-07-17  2:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tencent_6D5BA78E96792524AFC51045DB50A6203907@qq.com>
2023-07-17  2:27 ` hanyu001 [this message]
     [not found] <tencent_3CB61C1D0FF3B148608B138A6CA1C3414B08@qq.com>
2023-07-17  2:39 ` [PATCH] myri10ge: Prefer unsigned int to bare use of unsigned hanyu001
2023-07-17  5:54   ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5ac1bb7a79b43c8349cf9012671791d@208suo.com \
    --to=hanyu001@208suo.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox