From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751826AbdEVFKf (ORCPT ); Mon, 22 May 2017 01:10:35 -0400 Received: from mout.web.de ([212.227.15.3]:49252 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751749AbdEVFK3 (ORCPT ); Mon, 22 May 2017 01:10:29 -0400 Subject: [PATCH 2/2] usbnet: Improve a size determination in usbnet_write_cmd_async() From: SF Markus Elfring To: linux-usb@vger.kernel.org, netdev@vger.kernel.org, Oliver Neukum Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Mon, 22 May 2017 07:10:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:BnIUsNS2GqCfjuygbvtrjAg5JZ8YmYP5K9dZOup0pQ7xTBjZvN0 5KRiq/htLKmNAlEloF69vhhhL+GJ4LbgOMieRxjFjTjSizm2CrP2TPgHarq49TAYvL+rW3F 7JoOxPMWQDVIlCih3f2Mq8svDeBqwWzxAc979B4HbKw7XIlvujEy3oxoIXyM1LzfGzv8LzV yl4x3dDGCe5Bp2oMGDgFg== X-UI-Out-Filterresults: notjunk:1;V01:K0:t1vWtG3o5J4=:4mMFkDBwIQCvMIhB2Uq9Dd ICAWctymf1xjh8WO47AJAqS5UPejTttwV6hevRg3MVygbtBkKMU9hVYCs4dW+ncinaX19vPiC nkgXEqCrj+kf3ziwZT5YIh59aPP4EpUm0tDoONoyCpFF562vB8UrTyF3Tsl9XdlLWZnzI+Dtu GLOQIQCey024sbWUIf/EJ9y5yXyXZ9OTZ3bEZrk3rg9Y02W74wNTCSu4nnDG5WmT5BO902P3R uTp+Je/XZSGeYdWV6VTFh1XuGVmMpJCJMJxuNxgHWyc6LNWZq66otNEijO/gSf4LwMlbeEz6v aNNIW1ykw1OSKedKC5Z4UPJQNDk9KDdkM/FfEb5e08MOc1SdXBihljIp4xlIsTtWnjaquMuX1 UpsnRkE1JwzzbRXhazj2n3pZ3phM7XrxI7oorGSwxo5Z3gYj1v+i/QCYnBN6EsXePO2zEMYQ5 cMi2lyPJe/UjuhS4M+UcnRanfsXmxZ6eCAUeFxVVyKPUdQHNaeAoncTfg5OgG9ZkLZb/9+Zgi d94178WzU/XjJ+gJcZam4GHcMqqaBZkbozXCVEPhuu1+9cgIYcw+d21ziCKIVCvAFsbT3eIeZ HZJlbqhWX9+GGI+TnmfcSnhcla5dj/kMM6RJyvZ0wnOapUHOmhmwZBl8V2rEMdE76SVyiyM8C xUUytEnF1pca4sCOjRFjspwLU7k+KEHrlJOeB5EC/UxcZJxcSQvOacdWhV3McZGqzCgqbTGkQ iK00dMPbyhYzapHOatyZcVRAyJgXO1zs1qJbgq5HvC9ckJ+BxhhOMhhjUkuUN408RhLXs1mkT p40HMOJ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 22 May 2017 06:42:33 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/net/usb/usbnet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 802ba68d37d1..b73c2a40501c 100644 --- a/drivers/net/usb/usbnet.c +++ b/drivers/net/usb/usbnet.c @@ -2129,6 +2129,6 @@ int usbnet_write_cmd_async(struct usbnet *dev, u8 cmd, u8 reqtype, } - req = kmalloc(sizeof(struct usb_ctrlrequest), GFP_ATOMIC); + req = kmalloc(sizeof(*req), GFP_ATOMIC); if (!req) goto fail_free_buf; -- 2.13.0