From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755408AbcKYPlm (ORCPT ); Fri, 25 Nov 2016 10:41:42 -0500 Received: from mail.kernel.org ([198.145.29.136]:45082 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755100AbcKYPlT (ORCPT ); Fri, 25 Nov 2016 10:41:19 -0500 Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: fix wrong AUTO_RECOVER condition To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20161117232958.10931-1-jaegeuk@kernel.org> <20161117232958.10931-2-jaegeuk@kernel.org> From: Chao Yu Message-ID: Date: Fri, 25 Nov 2016 23:40:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <20161117232958.10931-2-jaegeuk@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, isize AUTO_RECOVER still be corrupted..., try below case: 1. xfs_io -f /mnt/f2fs/file -c "pwrite 0 4096" -c "fsync" 2. xfs_io -f /mnt/f2fs/file -c "falloc -k 4096 4096" -c "fsync" 3. md5sum /mnt/f2fs/file; 4. godown /mnt/f2fs/ 5. umount /mnt/f2fs/ 6. mount -t f2fs /dev/sdx /mnt/f2fs 7. md5sum /mnt/f2fs/file It's hard to deside to recover isize or not when current recovered block is fallocated, as we can allocate block inside or outside of isize. Any thoughts? Thanks, On 2016/11/18 7:29, Jaegeuk Kim wrote: > If i_size is not aligned to the f2fs's block size, we should not skip inode > update during fsync. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/f2fs.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index f7b986c..68f4887 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -1741,7 +1741,8 @@ static inline bool f2fs_skip_inode_update(struct inode *inode, int dsync) > spin_unlock(&sbi->inode_lock[DIRTY_META]); > return ret; > } > - if (!is_inode_flag_set(inode, FI_AUTO_RECOVER)) > + if (!is_inode_flag_set(inode, FI_AUTO_RECOVER) || > + i_size_read(inode) & PAGE_MASK) > return false; > return F2FS_I(inode)->last_disk_size == i_size_read(inode); > } >