From: Jens Axboe <axboe@kernel.dk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Eric Biggers <ebiggers@kernel.org>
Cc: stable@vger.kernel.org, Sasha Levin <sashal@kernel.org>,
Mike Cloaked <mike.cloaked@gmail.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Yu Kuai <yukuai3@huawei.com>, Genes Lists <lists@sapience.com>
Subject: Re: Possible kernel fs block code regression in 6.2.3 umounting usb drives
Date: Sat, 11 Mar 2023 09:40:10 -0700 [thread overview]
Message-ID: <d5b5e99f-78c0-6340-4a2f-86ea593c4fab@kernel.dk> (raw)
In-Reply-To: <ZAxKq+Czx1dQjl6M@kroah.com>
n 3/11/23 2:32?AM, Greg Kroah-Hartman wrote:
> On Fri, Mar 10, 2023 at 02:53:19PM -0800, Eric Biggers wrote:
>> On Fri, Mar 10, 2023 at 04:08:21PM -0500, Genes Lists wrote:
>>> On 3/10/23 15:23, Jens Axboe wrote:
>>>> On 3/10/23 1:16?PM, Eric Biggers wrote:
>>> ...
>>>> But I would revert:
>>>>
>>>> bfe46d2efe46c5c952f982e2ca94fe2ec5e58e2a
>>>> 57a425badc05c2e87e9f25713e5c3c0298e4202c
>>>>
>>>> in that order from 6.2.3 and see if that helps. Adding Yu.
>>>>
>>> Confirm the 2 Reverts fixed in my tests as well (nvme + sata drives).
>>> Nasty crash - some needed to be power cycled as they hung on shutdown.
>>>
>>> Thank you!
>>>
>>> gene
>>>
>>>
>>
>> Great, thanks. BTW, 6.1 is also affected. A simple reproducer is to run:
>>
>> dmsetup create dev --table "0 128 zero"
>> dmsetup remove dev
>>
>> The following kconfigs are needed for the bug to be hit:
>>
>> CONFIG_BLK_CGROUP=y
>> CONFIG_BLK_DEV_THROTTLING=y
>> CONFIG_BLK_DEV_THROTTLING_LOW=y
>>
>> Sasha or Greg, can you please revert the indicated commits from 6.1 and 6.2?
>
> Yes, will go do that right now, thanks for debugging this so quickly!
The issue here is that parts of a series was auto-selected. That seems
like a bad idea to do for stable. Just because something applies without
other parts of the series doesn't mean it's sane to backport by itself.
How do we prevent that from happening? Maybe we just need to default
to "if whole series doesn't pick cleanly, don't grab any parts of it
in auto-selection"? Exception being if it's explicitly marked for stable,
not uncommon to have a series that starts with a fix or two which should
go to stable, then the feature bits.
--
Jens Axboe
next prev parent reply other threads:[~2023-03-11 16:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAOCAAm7AEY9tkZpu2j+Of91fCE4UuE_PqR0UqNv2p2mZM9kqKw@mail.gmail.com>
2023-03-10 19:33 ` Possible kernel fs block code regression in 6.2.3 umounting usb drives Mike Cloaked
2023-03-10 20:14 ` Eric Biggers
2023-03-10 20:16 ` Eric Biggers
2023-03-10 20:23 ` Jens Axboe
2023-03-10 21:08 ` Genes Lists
2023-03-10 22:53 ` Eric Biggers
2023-03-11 9:32 ` Greg Kroah-Hartman
2023-03-11 16:40 ` Jens Axboe [this message]
2023-03-11 2:07 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5b5e99f-78c0-6340-4a2f-86ea593c4fab@kernel.dk \
--to=axboe@kernel.dk \
--cc=ebiggers@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@sapience.com \
--cc=mike.cloaked@gmail.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox