From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751830AbdJCLW0 (ORCPT ); Tue, 3 Oct 2017 07:22:26 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:18690 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751164AbdJCLWY (ORCPT ); Tue, 3 Oct 2017 07:22:24 -0400 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Tue, 03 Oct 2017 04:22:03 -0700 Subject: Re: [PATCH V2] firmware: tegra: add BPMP debugfs support To: Jonathan Hunter , "thierry.reding@gmail.com" CC: "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <1507011133-21817-1-git-send-email-talho@nvidia.com> <7fecddd5-f676-83b9-5e6e-6b3cd652e947@nvidia.com> From: Timo Alho X-Nvconfidentiality: public Message-ID: Date: Tue, 3 Oct 2017 14:21:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <7fecddd5-f676-83b9-5e6e-6b3cd652e947@nvidia.com> X-Originating-IP: [10.21.24.139] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jon, thanks for reviewing On 03.10.2017 13:55, Jonathan Hunter wrote: >> +static int create_debugfs_mirror(struct tegra_bpmp *bpmp, void *buf, >> + size_t bufsize, struct dentry *root) >> +{ >> + struct seqbuf seqbuf; >> + int err; >> + >> + bpmp->debugfs_mirror = debugfs_create_dir("debug", root); >> + if (!bpmp->debugfs_mirror) >> + return -ENOMEM; > > Is this extra level needed? Do you plan to have other sub-directories > under the main bpmp directory? Yes, the downstream driver has few files under main directory (e.g. 'ping' to check that firmware is alive, or 'tag' to read the firmware version). BR, Timo