From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: David Miller <davem@davemloft.net>
Cc: liuhangbin@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] macvlan: Mark expected switch fall-through
Date: Mon, 20 May 2019 13:48:04 -0500 [thread overview]
Message-ID: <d623aa39-4c5c-addb-0cf7-d0c8aed63515@embeddedor.com> (raw)
In-Reply-To: <20190520.113812.944855298869290023.davem@davemloft.net>
On 5/20/19 1:38 PM, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
> Date: Mon, 20 May 2019 09:44:49 -0500
>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/net/macvlan.c: In function ‘macvlan_do_ioctl’:
>> drivers/net/macvlan.c:839:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> if (!net_eq(dev_net(dev), &init_net))
>> ^
>> drivers/net/macvlan.c:841:2: note: here
>> case SIOCGHWTSTAMP:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> I'll apply this to 'net' since it was introduced actually by arecent
> change.
>
OK, great. :)
Thank you.
--
Gsutavo
prev parent reply other threads:[~2019-05-20 18:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 14:44 [PATCH net-next] macvlan: Mark expected switch fall-through Gustavo A. R. Silva
2019-05-20 18:38 ` David Miller
2019-05-20 18:48 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d623aa39-4c5c-addb-0cf7-d0c8aed63515@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox