From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012059.outbound.protection.outlook.com [40.107.200.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 396C439DBC3 for ; Wed, 22 Apr 2026 03:36:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.59 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776829018; cv=fail; b=NC7MDKJ7Jg7hS8D0vTNrGC1j7+VKpnZdmmT+bADRznvzDKYaL/tzEWuqaw5lc9O4tL0T8lzlMqzxdSE6u1XoCq8bt6SuPWncsRLoNP4P5kqWS3yZH+EXWeR5QtljF1BCd9LY78/5j8neGGsOLZUdLdIS1md6Va+1MphVQE1pHQA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776829018; c=relaxed/simple; bh=cZZAc5hN/lCE+H7niuLcBhnAekYD0oY3G7eytl4YJ2w=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=nkpv2c5x+f6vlLNJNOEi4kOmUgkjRHI7UXq9eFXIjWpTqL9Ql6JUyFs6lx/VIxLo157OhzftlHOMysjdk4DYmk6FgiqTTxsW+v51VCTJi4E+GTz56aak4wJzQluRQkZnIOs0lANjl2t23X9LyDO3H8RRXO5OAxOY1YoqlnoZWV4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=jBlpOYh6; arc=fail smtp.client-ip=40.107.200.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="jBlpOYh6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=doU2aNJoGEyp4I5rOeQPflrEP1KvwwvfA2hzLTrAgbJ6Lhu4bdqefi0AvKwutqfVmggZmV9eYcYvYR5ucS1WN0s7gQYBlxKuYACX7rK+D/6RpgbaPEvK1fgaYFYrgpMV47SVKB7T4ELVwHcTsFpBexR8VQA8vejF+D4Ee55wUP9M+iM4LOYLy2gKbvhUGPGyjozYVTK5JLiXr1ykunK/xawLBa4Ij8UjSlxoSrH7pfwVwQ8N1416CXJ2iJLNJ1nOCS5EYZzFKwZbgzxby1SQII1P2SBcQCflSSnxZEvzRE8k4ppWo0ZNupgxbB2k8CIeJB+HXmq6tGV4WdUDkFsMtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JjD0U1eyXUD0puYUr5mVpJWAOoY0zOrujHP1xpvwYz4=; b=ad0dQvPmsnFveGZ3zCg/oddv6wJqpyvP8VbWRF4C2T6WJ2S7cPNKA0tGYHNMsLrRuaiC3Ni+Bs2DKcoQWkA3Wvuf9nhVsxXfFZllhWnpMWtJgfppycXq9vQ6bKen2aQZ63BqTNBXWZBrk18qRE26gSEnOGYLS9g0LnZw3WH4ZLc1Gwa1pBfPiPvstm7HejOXbpEs0c7fcqa0jcACfg1c24uMQvnBRqy+gPn5ywNpk8VN/fLz/oHYaRWI6SKA5Fc0Fc50tUI+4pf7+YC4eZ6MvPufhCeQnejDwyDS5oG13o82EgRX2HsF1hK5GzmmRLlus/h/WPtvnsVjfGUIkfgbvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nvidia.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JjD0U1eyXUD0puYUr5mVpJWAOoY0zOrujHP1xpvwYz4=; b=jBlpOYh6Do6Ms4VkT87j4m8RtqiBUZUWVz7/TmduQveLbUno0nL+ECz3TU+5i34PZH8BvFyRL2ERF/8Oi/nmGqygW/7fykLZDicTzlQalRwmQdOHvEkV5u9t0cM6uhwKvvJmO9WfTE78L1ZyOWTFpWQ6XefpuMBVKKOda/BYlr4= Received: from BYAPR07CA0055.namprd07.prod.outlook.com (2603:10b6:a03:60::32) by CY8PR12MB7415.namprd12.prod.outlook.com (2603:10b6:930:5d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.15; Wed, 22 Apr 2026 03:36:46 +0000 Received: from SJ1PEPF00001CEB.namprd03.prod.outlook.com (2603:10b6:a03:60:cafe::37) by BYAPR07CA0055.outlook.office365.com (2603:10b6:a03:60::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9791.48 via Frontend Transport; Wed, 22 Apr 2026 03:36:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by SJ1PEPF00001CEB.mail.protection.outlook.com (10.167.242.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.18 via Frontend Transport; Wed, 22 Apr 2026 03:36:45 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.17; Tue, 21 Apr 2026 22:36:45 -0500 Received: from satlexmb07.amd.com (10.181.42.216) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 21 Apr 2026 22:36:45 -0500 Received: from [10.136.34.119] (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Tue, 21 Apr 2026 22:36:41 -0500 Message-ID: Date: Wed, 22 Apr 2026 09:06:40 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] sched/fair: Prefer fully-idle SMT cores in asym-capacity idle selection To: Andrea Righi CC: Dietmar Eggemann , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , "Steven Rostedt" , Ben Segall , Mel Gorman , Valentin Schneider , Christian Loehle , Koba Ko , Felix Abecassis , Balbir Singh , Shrikanth Hegde , References: <20260403053654.1559142-2-arighi@nvidia.com> <64fe32e0-d428-42bb-beb4-2656d8781b0f@arm.com> <7313ba07-7b87-447c-9c48-2f6b2b53ac94@amd.com> <1230f5df-470a-4e59-8c8e-fa159a6fc093@amd.com> <3cc4d887-f44d-4fe8-a57a-73f595647eab@amd.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Received-SPF: None (SATLEXMB04.amd.com: kprateek.nayak@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CEB:EE_|CY8PR12MB7415:EE_ X-MS-Office365-Filtering-Correlation-Id: d9a3a138-0778-431c-312a-08dea020610d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|36860700016|82310400026|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: 0G/rMP5LItA2kyVnxvdc5nmBud/gDCTYTVJJtYtZbU0lnM3QCbrjnau9ISnMMcso/mRyHPpyH4T8A020Bq+QYaPVJMr8C6qBspaFBwUXFkmwNjuX1qiojJGROpt9hXB/LbCmT/MPcResblLa9KsDnD1DU1jdoOQfr9JlEPjdSbJyOC/dm3kNwz2Anx4G1gys/vLPJX6nrcPaggO6WUwAtdtNymAMSXNu/MqpjPXy6046CQIjH6hFKOkRaxOes/Plf8+6ymvzvhM8uZQZ69OgSX244ZclFJ3rBGo7OV2U3Puc2k9dCBqOgvAt84GqagYG+UxMRDhV/3eoTKRDZ8D3rzEBWZ085LMCEFGDm9hBkMRQ8jA0J1Lbf4OTpaSGr2Jcd871uHGQs1nYvyEy8IOp7alST5LT7NptwKSdirRlqhWOJaHpVZ0G+cR+z1/zSp9pHjDNUgZf4teeUoX1gCWesJVht4CB0BothOe4o2Bn9Wofbq+wk6VpYo5/4CD4X1OKTN8EEqMW1l7JXxsUYqO5fHznYTI0aexmF7TOYh4H5lsN9ZQGtyymLQatGd3r2dIerbOKOgtI0+Jo4udKy80+2S9a40+xTqquyUl22cSbkT+VIA4gzNuUIfOvEwe5myVTR3Os2+HhGofoCsJXYamGmNayvbzFyktjnHmzT4epswYxzA7S2LphxoUPD9Gajtv/pQMtvcRVo9aTi5ZAtKz0Ui0ZT3Pwr61Vrg1qWQmqtBPFpTR+S6tgPYlVE/DvOQKzEgXgu2ZmXZ8Qow6NtPHg2w== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(36860700016)(82310400026)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: TCs2dU2dgN9OOWJMgGYxUCK23Icp/rF3XasKCXf4hDQHJdJIS8sFzwZdQiMuuSJ71XgNYZ+tPUVdxE2xtIG6yAm16v6R4/2fHkn+yBx2f+brI50ghJwMJVhHzzQmf+l7ZJQEVhtq2uiwPlac4UbA9ko5Y/L0FNRR6u/WnSyzEnTrOIL7JzrN4n3HTkbzXSIFUrNGryJRxsW61grypIkhzWtkMF+wLhswP3pM3bNRM9ZyLckyB3BRpBG+GYNd+ZP/S8g+gBSpsV9vQlHaa2OAcqYTB9b9z4bfWnfQ5LXeoLiyB/a/h8Ca61/2U/M+n4/VDMnqCij9LvgT4TOtL8QMXESMMiEyqhhkVtzlQp4lHXansx9juWdQWHJPHTfyM62MP3PrQeBVd/35YAN+M01OBY0TvTBcvOB1Ldtz17WRP2mOPN8CUaV6n4Gzbwj0sV8f X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2026 03:36:45.9502 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d9a3a138-0778-431c-312a-08dea020610d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CEB.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7415 Hello Andrea, On 4/21/2026 7:08 PM, Andrea Righi wrote: >> You can also try "best_fits <= -3" in that last bailout condition and >> see if that help. > > For the bailout condition I don't see much difference using either <= -3 or > == -4. In general, I see a small but consistent improvement with the SIS_UTIL > logic, especially when the system is close to saturation (as expected). Thank you for testing! I guess == -4 is safer then. It is probably best to add an enum of sorts to help distinguish these states rather than the magic numbers. Perhaps something like: enum asym_fits_state { /* In descending order of preference */ ASYM_IDLE_CORE_UCLAMP_MISFIT = -4, ASYM_IDLE_CORE_COMPLETE_MISFIT, ASYM_IDLE_THREAD_FITS, ASYM_IDLE_THREAD_UCLAMP_MISFIT, ASYM_IDLE_COMPLETE_MISFIT, /* asym_fits_cpu() bias for an idle core. */ ASYM_IDLE_CORE_BIAS = -3, }; > > So, this looks good to me! Do you want me to include also this one in the new > SMT-aware asym cpu capacity patch series (keeping your authorship of course) or > do you prefer to route this separately? I think you can send it as a part of your series for easy review. I'll be happy to help reworking those bits based on the comments if folks aren't happy with them ;-) -- Thanks and Regards, Prateek