* [PATCH next] drm/bridge: analogix_dp: Fix a NULL vs IS_ERR() bug
@ 2025-07-15 22:59 Dan Carpenter
2025-07-16 8:31 ` Luca Ceresoli
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2025-07-15 22:59 UTC (permalink / raw)
To: Marek Szyprowski
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Dmitry Baryshkov,
Douglas Anderson, Damon Ding, Luca Ceresoli, dri-devel,
linux-kernel, kernel-janitors
The devm_drm_bridge_alloc() function returns error pointers on error. It
never returns NULL.
Fixes: 48f05c3b4b70 ("drm/bridge: analogix_dp: Use devm_drm_bridge_alloc() API")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index ed35e567d117..4b9b444bd249 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1474,8 +1474,8 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
dp = devm_drm_bridge_alloc(dev, struct analogix_dp_device, bridge,
&analogix_dp_bridge_funcs);
- if (!dp)
- return ERR_PTR(-ENOMEM);
+ if (IS_ERR(dp))
+ return dp;
dp->dev = &pdev->dev;
dp->dpms_mode = DRM_MODE_DPMS_OFF;
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH next] drm/bridge: analogix_dp: Fix a NULL vs IS_ERR() bug
2025-07-15 22:59 [PATCH next] drm/bridge: analogix_dp: Fix a NULL vs IS_ERR() bug Dan Carpenter
@ 2025-07-16 8:31 ` Luca Ceresoli
0 siblings, 0 replies; 2+ messages in thread
From: Luca Ceresoli @ 2025-07-16 8:31 UTC (permalink / raw)
To: Dan Carpenter
Cc: Marek Szyprowski, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Dmitry Baryshkov, Douglas Anderson, Damon Ding,
dri-devel, linux-kernel, kernel-janitors
Hello Dan,
On Tue, 15 Jul 2025 17:59:06 -0500
Dan Carpenter <dan.carpenter@linaro.org> wrote:
> The devm_drm_bridge_alloc() function returns error pointers on error. It
> never returns NULL.
>
> Fixes: 48f05c3b4b70 ("drm/bridge: analogix_dp: Use devm_drm_bridge_alloc() API")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index ed35e567d117..4b9b444bd249 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1474,8 +1474,8 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
>
> dp = devm_drm_bridge_alloc(dev, struct analogix_dp_device, bridge,
> &analogix_dp_bridge_funcs);
> - if (!dp)
> - return ERR_PTR(-ENOMEM);
> + if (IS_ERR(dp))
> + return dp;
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Thanks!
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-16 8:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-15 22:59 [PATCH next] drm/bridge: analogix_dp: Fix a NULL vs IS_ERR() bug Dan Carpenter
2025-07-16 8:31 ` Luca Ceresoli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).