From: 王贇 <yun.wang@linux.alibaba.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: "Ingo Molnar" <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Juri Lelli" <juri.lelli@redhat.com>,
"Michal Koutný" <mkoutny@suse.com>,
"Mel Gorman" <mgorman@suse.de>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND] sched/numa: expose per-task pages-migration-failure
Date: Tue, 3 Dec 2019 17:25:49 +0800 [thread overview]
Message-ID: <d67d273c-41e7-d046-cdd1-0b2faae2ed07@linux.alibaba.com> (raw)
In-Reply-To: <20191203071615.GD115767@gmail.com>
On 2019/12/3 下午3:16, Ingo Molnar wrote:
[snip]
>> kernel/sched/debug.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
>> index f7e4579e746c..73c4809c8f37 100644
>> --- a/kernel/sched/debug.c
>> +++ b/kernel/sched/debug.c
>> @@ -848,6 +848,7 @@ static void sched_show_numa(struct task_struct *p, struct seq_file *m)
>> P(total_numa_faults);
>> SEQ_printf(m, "current_node=%d, numa_group_id=%d\n",
>> task_node(p), task_numa_group_id(p));
>> + SEQ_printf(m, "migfailed=%lu\n", p->numa_faults_locality[2]);
>
> Any reason not to expose the other 2 fields of this array as well, which
> show remote/local migrations?
The rest are local/remote faults counter, AFAIK not related to
migration, when the CPU triggered PF is from the same node of page
(before migration), local faults increased.
Regards,
Michael Wang
>
> Thanks,
>
> Ingo
>
prev parent reply other threads:[~2019-12-03 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 2:18 [PATCH RESEND] sched/numa: expose per-task pages-migration-failure 王贇
2019-12-03 7:16 ` Ingo Molnar
2019-12-03 9:25 ` 王贇 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d67d273c-41e7-d046-cdd1-0b2faae2ed07@linux.alibaba.com \
--to=yun.wang@linux.alibaba.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox