From: Jack Stone <jwjstone@fastmail.fm>
To: Andrew Morton <akpm@linux-foundation.org>,
Shawn Bohrer <shawn.bohrer@gmail.com>
Cc: Viresh Kumar <viresh.kumar@st.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH resend] fs/eventpoll.c: fix compilation warning
Date: Sat, 15 Jan 2011 11:10:19 +0000 [thread overview]
Message-ID: <d67da8d3-b7fd-4fef-8490-a028fe41cf43@email.android.com> (raw)
In-Reply-To: <20110114160508.41105533.akpm@linux-foundation.org>
"Andrew Morton" <akpm@linux-foundation.org> wrote:
>I've looked at this warning several times - the code is non-buggy and
>it's a bit sad to add extra instructions unnecessarily. It would be
>better to make this warning go away by cleaning up or restructuring the
>code.
>
>And the code _is_ pretty stupid. If timed_out is set to 1 then the
>function does a great pile of useless junk. I had a quick tinkle, made
>things worse and gave up:
[snip]
>I think the attempt to munge the "timeout==0" spacial case into the
>main body of the polling loop was a mistake, and that the code would be
>better/cleaner if that special case was handled quite separately.
I can have a go at a patch later on today if you wish.
Thanks,
Jack
--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
next prev parent reply other threads:[~2011-01-15 11:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 11:52 [PATCH resend] fs/eventpoll.c: fix compilation warning Viresh Kumar
2011-01-14 13:07 ` Jack Stone
2011-01-14 14:48 ` Shawn Bohrer
2011-01-14 15:21 ` Davide Libenzi
2011-01-15 0:05 ` Andrew Morton
2011-01-15 11:10 ` Jack Stone [this message]
2011-01-15 16:20 ` Shawn Bohrer
2011-01-15 17:00 ` [PATCH 1/3] epoll: initialize slack for negative timeout values Shawn Bohrer
2011-01-15 19:06 ` Davide Libenzi
2011-03-18 7:38 ` Mike Frysinger
2011-01-15 17:00 ` [PATCH 2/3] epoll: short circuit the timeout==0 case Shawn Bohrer
2011-01-15 17:00 ` [PATCH 3/3] epoll: remove unnecessary test of ep->ovflist for available events Shawn Bohrer
2011-01-15 19:03 ` Davide Libenzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d67da8d3-b7fd-4fef-8490-a028fe41cf43@email.android.com \
--to=jwjstone@fastmail.fm \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.bohrer@gmail.com \
--cc=viresh.kumar@st.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox