public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Andy Yan" <andyshrk@163.com>
To: heiko@sntech.de
Cc: hjc@rock-chips.com, krzk+dt@kernel.org, s.hauer@pengutronix.de,
	 devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	 linux-rockchip@lists.infradead.org, derek.foreman@collabora.com,
	 detlev.casanova@collabora.com,
	"Andy Yan" <andy.yan@rock-chips.com>
Subject: Re:[PATCH] drm/rockchip: vop2: Setup delay cycle for Esmart2/3
Date: Mon, 9 Dec 2024 20:37:59 +0800 (CST)	[thread overview]
Message-ID: <d6e7dee.ba96.193ab6d2e3f.Coremail.andyshrk@163.com> (raw)
In-Reply-To: <20241209122943.2781431-5-andyshrk@163.com>


Sorry, please ignore this patch.

At 2024-12-09 20:29:14, "Andy Yan" <andyshrk@163.com> wrote:
>From: Andy Yan <andy.yan@rock-chips.com>
>
>Each layer needs to set the correct delay cycle to display properly
>without unexpected offset on screen.
>
>Fixes: 5a028e8f062f ("drm/rockchip: vop2: Add support for rk3588")
>Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>---
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
>index c3a572b1c8704..7dc8be7d61184 100644
>--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
>+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
>@@ -2526,9 +2526,11 @@ static void vop2_setup_dly_for_windows(struct vop2 *vop2)
> 			sdly |= FIELD_PREP(RK3568_SMART_DLY_NUM__ESMART1, dly);
> 			break;
> 		case ROCKCHIP_VOP2_SMART0:
>+		case ROCKCHIP_VOP2_ESMART2:
> 			sdly |= FIELD_PREP(RK3568_SMART_DLY_NUM__SMART0, dly);
> 			break;
> 		case ROCKCHIP_VOP2_SMART1:
>+		case ROCKCHIP_VOP2_ESMART3:
> 			sdly |= FIELD_PREP(RK3568_SMART_DLY_NUM__SMART1, dly);
> 			break;
> 		}
>-- 
>2.34.1

  reply	other threads:[~2024-12-09 12:38 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-09 12:29 [PATCH v5 00/18] VOP Support for rk3576 Andy Yan
2024-12-09 12:29 ` [PATCH] arm64: dts: rockchip: Add vop " Andy Yan
2024-12-09 12:36   ` Andy Yan
2024-12-09 12:29 ` [PATCH] arm64: dts: rockchip: Enable HDMI display for rk3588 Cool Pi GenBook Andy Yan
2024-12-09 12:37   ` Andy Yan
2024-12-09 12:29 ` [PATCH v5 01/18] drm/rockchip: vop2: Add debugfs support Andy Yan
2024-12-10 11:57   ` Heiko Stübner
2024-12-11  7:07     ` Andy Yan
2024-12-11  8:52       ` Heiko Stübner
2024-12-09 12:29 ` [PATCH] drm/rockchip: vop2: Setup delay cycle for Esmart2/3 Andy Yan
2024-12-09 12:37   ` Andy Yan [this message]
2024-12-09 12:29 ` [PATCH v5 02/18] drm/rockchip: vop2: Fix cluster windows alpha ctrl regsiters offset Andy Yan
2024-12-09 12:29 ` [PATCH v5 03/18] drm/rockchip: vop2: Fix the mixer alpha setup for layer 0 Andy Yan
2024-12-09 12:29 ` [PATCH v5 04/18] drm/rockchip: vop2: Fix the windows switch between different layers Andy Yan
2024-12-10 23:09   ` Heiko Stuebner
2024-12-09 12:29 ` [PATCH v5 05/18] drm/rockchip: vop2: Set AXI id for rk3588 Andy Yan
2024-12-10 18:40   ` Detlev Casanova
2024-12-11  6:34     ` Andy Yan
2024-12-11 15:45       ` Detlev Casanova
2024-12-12  7:52         ` Andy Yan
2024-12-13 18:34           ` Detlev Casanova
2024-12-14  8:01             ` Andy Yan
2024-12-09 12:29 ` [PATCH v5 06/18] drm/rockchip: vop2: Setup delay cycle for Esmart2/3 Andy Yan
2024-12-09 12:29 ` [PATCH v5 07/18] drm/rockchip: vop2: Check linear format for Cluster windows on rk3566/8 Andy Yan
2024-12-09 12:32 ` [PATCH v5 08/18] drm/rockchip: vop2: Add check for 32 bpp format Andy Yan
2024-12-09 17:06   ` Daniel Stone
2024-12-10  7:01     ` Andy Yan
2024-12-09 12:32 ` [PATCH v5 09/18] drm/rockchip: vop2: include rockchip_drm_drv.h Andy Yan
2024-12-09 12:32 ` [PATCH v5 10/18] drm/rockchip: vop2: Support 32x8 superblock afbc Andy Yan
2024-12-09 12:33 ` [PATCH v5 11/18] drm/rockchip: vop2: Add platform specific callback Andy Yan
2024-12-09 12:33 ` [PATCH v5 12/18] drm/rockchip: vop2: Support for different layer select configuration between VPs Andy Yan
2024-12-09 12:33 ` [PATCH v5 13/18] drm/rockchip: vop2: Introduce vop hardware version Andy Yan
2024-12-10 15:03   ` Heiko Stübner
2024-12-09 12:33 ` [PATCH v5 14/18] drm/rockchip: vop2: Register the primary plane and overlay plane separately Andy Yan
2024-12-09 12:33 ` [PATCH v5 15/18] drm/rockchip: vop2: Set plane possible crtcs by possible vp mask Andy Yan
2024-12-09 12:34 ` [PATCH v5 16/18] drm/rockchip: vop2: Add uv swap for cluster window Andy Yan
2024-12-09 12:34 ` [PATCH v5 17/18] dt-bindings: display: vop2: Add rk3576 support Andy Yan
2024-12-09 12:34 ` [PATCH v5 18/18] drm/rockchip: vop2: Add support for rk3576 Andy Yan
2024-12-10 23:12 ` (subset) [PATCH v5 00/18] VOP Support " Heiko Stuebner
2024-12-14  8:15 ` [PATCH v6 00/16] " Andy Yan
2024-12-14  8:15   ` [PATCH v6 01/16] drm/rockchip: vop2: Add debugfs support Andy Yan
2024-12-14  8:15   ` [PATCH v6 02/16] drm/rockchip: vop2: Fix the windows switch between different layers Andy Yan
2024-12-14  8:15   ` [PATCH v6 03/16] drm/rockchip: vop2: Set AXI id for rk3588 Andy Yan
2024-12-14  8:15   ` [PATCH v6 04/16] drm/rockchip: vop2: Setup delay cycle for Esmart2/3 Andy Yan
2024-12-14  8:15   ` [PATCH v6 05/16] drm/rockchip: vop2: Check linear format for Cluster windows on rk3566/8 Andy Yan
2024-12-14  8:15   ` [PATCH v6 06/16] drm/rockchip: vop2: Add check for 32 bpp format for rk3588 Andy Yan
2024-12-14  8:15   ` [PATCH v6 07/16] drm/rockchip: vop2: include rockchip_drm_drv.h Andy Yan
2024-12-14  8:15   ` [PATCH v6 08/16] drm/rockchip: vop2: Support 32x8 superblock afbc Andy Yan
2024-12-14  8:15   ` [PATCH v6 09/16] drm/rockchip: vop2: Add platform specific callback Andy Yan
2024-12-14  8:15   ` [PATCH v6 10/16] drm/rockchip: vop2: Support for different layer select configuration between VPs Andy Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6e7dee.ba96.193ab6d2e3f.Coremail.andyshrk@163.com \
    --to=andyshrk@163.com \
    --cc=andy.yan@rock-chips.com \
    --cc=derek.foreman@collabora.com \
    --cc=detlev.casanova@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox