From: Damien Le Moal <dlemoal@kernel.org>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>, axboe@kernel.dk
Cc: chaitanyak@nvidia.com, hare@suse.de, hch@lst.de,
john.g.garry@oracle.com, linux-block@vger.kernel.org,
linux-btrace@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, martin.petersen@oracle.com,
mathieu.desnoyers@efficios.com, mhiramat@kernel.org,
naohiro.aota@wdc.com, rostedt@goodmis.org,
shinichiro.kawasaki@wdc.com
Subject: Re: [PATCH v4 09/16] blktrace: add definitions for struct blk_io_trace2
Date: Wed, 22 Oct 2025 05:51:12 +0900 [thread overview]
Message-ID: <d703eb46-55a1-4e0a-9658-b1fce9111d04@kernel.org> (raw)
In-Reply-To: <20251020134123.119058-10-johannes.thumshirn@wdc.com>
On 10/20/25 22:41, Johannes Thumshirn wrote:
> Add definitions for the extended version of the blktrace protocol using a
> wider action type to be able to record new actions in the kernel.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
One nit below.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> +struct blk_io_trace2 {
> + __u32 magic; /* MAGIC << 8 | BLK_IO_TRACE2_VERSION */
> + __u32 sequence; /* event number */
> + __u64 time; /* in nanoseconds */
> + __u64 sector; /* disk offset */
> + __u32 bytes; /* transfer length */
> + __u32 pid; /* who did it */
> + __u64 action; /* what happened */
> + __u32 device; /* device number */
> + __u32 cpu; /* on what cpu did it happen */
> + __u16 error; /* completion error */
> + __u16 pdu_len; /* length of data after this trace */
> + __u8 pad[12];
> + /* cgroup id will be stored here if exists */
s/if exists/if it exists
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-10-21 20:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 13:41 [PATCH v4 00/16] block: add blktrace support for zoned block devies Johannes Thumshirn
2025-10-20 13:41 ` [PATCH v4 01/16] blktrace: only calculate trace length once Johannes Thumshirn
2025-10-20 13:41 ` [PATCH v4 02/16] blktrace: factor out recording a blktrace event Johannes Thumshirn
2025-10-20 13:41 ` [PATCH v4 03/16] blktrace: split out relaying " Johannes Thumshirn
2025-10-20 13:41 ` [PATCH v4 04/16] blktrace: untangle if/else sequence in __blk_add_trace Johannes Thumshirn
2025-10-20 13:41 ` [PATCH v4 05/16] blktrace: change the internal action to 64bit Johannes Thumshirn
2025-10-20 13:41 ` [PATCH v4 06/16] blktrace: split do_blk_trace_setup into two functions Johannes Thumshirn
2025-10-20 13:41 ` [PATCH v4 07/16] blktrace: add definitions for blk_user_trace_setup2 Johannes Thumshirn
2025-10-20 13:41 ` [PATCH v4 08/16] blktrace: pass blk_user_trace2 to setup functions Johannes Thumshirn
2025-10-20 13:41 ` [PATCH v4 09/16] blktrace: add definitions for struct blk_io_trace2 Johannes Thumshirn
2025-10-21 20:51 ` Damien Le Moal [this message]
2025-10-20 13:41 ` [PATCH v4 10/16] blktrace: differentiate between blk_io_trace versions Johannes Thumshirn
2025-10-21 20:54 ` Damien Le Moal
2025-10-20 13:41 ` [PATCH v4 11/16] blktrace: move trace_note to blk_io_trace2 Johannes Thumshirn
2025-10-21 20:55 ` Damien Le Moal
2025-10-20 13:41 ` [PATCH v4 12/16] blktrace: move ftrace blk_io_tracer " Johannes Thumshirn
2025-10-21 20:55 ` Damien Le Moal
2025-10-20 13:41 ` [PATCH v4 13/16] blktrace: add block trace commands for zone operations Johannes Thumshirn
2025-10-21 20:57 ` Damien Le Moal
2025-10-20 13:41 ` [PATCH v4 14/16] blktrace: expose ZONE APPEND completions to blktrace Johannes Thumshirn
2025-10-20 13:41 ` [PATCH v4 15/16] blktrace: trace zone write plugging operations Johannes Thumshirn
2025-10-20 13:41 ` [PATCH v4 16/16] blktrace: handle BLKTRACESETUP2 ioctl Johannes Thumshirn
2025-10-21 2:25 ` [PATCH v4 00/16] block: add blktrace support for zoned block devies Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d703eb46-55a1-4e0a-9658-b1fce9111d04@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=johannes.thumshirn@wdc.com \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrace@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=rostedt@goodmis.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox