From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADF0F2C11FB for ; Wed, 19 Nov 2025 15:14:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763565265; cv=none; b=lv6getgM+k7PQm99nKUbWXZTcyENRhUp3mwwywn731ZAhQ+4Kw4edqeI+xvshY/wyO/n4bPJtvrSfvzw9ryK9aOVP98LVEl7+ZqZiaAKw43/TC63bVLzH3VUKUlbPrQfLUpYdDgBWq/gOPu5uo/TzLucWHkFTFT1xG+6Bpyzw0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763565265; c=relaxed/simple; bh=qNw8Hvjti2vhKNQPTDLygaW6kBcKBm8gA1tE5YQjEZc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EZU+rR39pR4YcpVKaZveM3Lr9Pb8RPZhiSwJOt5kXD8eJ7UBbkqXy9KVK3KHm/vuqS4a2554se2DYSLJ2s9fDEQ+B5uzjMKmaZ2m+OqCVGd43RiTv+N+qLIlFm4XrSZL1qNVye7yFeaFcDCACdRqnU5fekky8+aN0L23ApTA8As= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SEy1eS+Z; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SEy1eS+Z" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-429c48e05aeso687638f8f.1 for ; Wed, 19 Nov 2025 07:14:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763565262; x=1764170062; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=lkHlND8AocQhZqckGnaaNO+3qDUjMRfPMX7RKCDl4Hs=; b=SEy1eS+ZccYNl7g4lxDGHh8fvaFd7rveu7XHObWbtyqEqeUwRGudBhvYIjBzMiNtkO 1nt3sYrbGCkBGhFL2EfO4tWfMjygi996yD1L8xqyqJWv52UD0uGj2pbZG0MfGq/co4fv jOJGyfnQwK/21zUzyFCFYWXE0QdWdzhPvosrTrAuemO+bBBpj+V1iCrHnXpFosmlQJ0n vYA3XiQ/9FXwdiaELgUMU8KpgND3oM08yX8gj1jyHxyrKCuayeziAPfH8s2CpkW2f8iR fd0LdUhw7d5NlwiNlGKiFJz8u57sC/23Usz2SMkHs5I9HC0jW7CGhfvaZ3C7CofZ2j98 6RjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763565262; x=1764170062; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lkHlND8AocQhZqckGnaaNO+3qDUjMRfPMX7RKCDl4Hs=; b=H1tbScW7zUcVf2O5YWwRUHy+uPPMkytKtnGoAMNdgx4Ka7kNbRrNUvnnmbaFkX1ZEt aHuOPc49S0iGP51zrFRo4SgoEQRPK6PbvTDxITzwuY24AZ7GbyEjgkebPinpfwJkEcqN VIdVhhFoKB1N4MDtnA16aILTtqWbLQMug/E9VnCU5WzyviNfOAjBrYrrmftWvH6YC/bR YgmmhV+WdtbHuZUBRTxgDuqpHS+njQ+6MvvzP2mOJOuuLQ1JA2dhFPxwRTkNUD03Qlar jWfo433lpPThn1sr9o2PiakddqmCELwVt14lFkEVO40umFTPSZ95frPwsOjw20hte6Sr r55Q== X-Forwarded-Encrypted: i=1; AJvYcCWfHCdXEngqWsBk50vv6rvV4DUBdrkdeSfNqep+WYLqRRPSvvMHPrSgicIoGIgEwIDU/0ANaFqw4nGd6uE=@vger.kernel.org X-Gm-Message-State: AOJu0YxGjgOD07012bIfH1Pnz3UYKWl2iyiWgpkojvMWhwbjJS9p+se1 QVJmA1QJGOCXOVlX80P9xjf8GkWVDgWdR8NH9kU+71Y9b5dtYs64FOXtsBhpTX+6I90= X-Gm-Gg: ASbGncsB5FzCOXFdCVQJ9xdrigbi3PUrswBLw4DSlMFTvHYjsC0P7bQBHtKiSrKEW4M GsoDEXU/K6X9OxIhJxTZYzmhI5coBuqDijV+t9IKPCDY5z0DY1RtOEgUtiL2dYe9IAjikSpZP0B gtqufEOWq4sA0lUIQ5xTJ2zSd3SSte+hbCa3r36S+81va7hK/cn/re5Ju1C4myecghXsByk7gzg OaR/qsW+huIIWv5z5C8Fz7epKpt1d2fLFMK13OuD0rmwaoyHe2PCP/aaNzXooDwh5ehBbf20u/S 6JybF3bhwg0A2DHosyCNnNbe9CYjQxxOcLWKTgOsFNpDEZE7FU7Idgipr2RB2f1lrdzAPAUEfNq BuYIrlzv7y9D+psBt4u5KAcQY0/w7ZeeR2arGSihXAntDDSajk6B1OpLXqppALS/WM8ysedLFku rlwTNy0sV6fO9ivPTCAEHhcW5RD+la7CkPc9kTviFOEYM8l9pjZvzh0Qh+cjZXubQPBcWWPnly+ g== X-Google-Smtp-Source: AGHT+IGrnkcaARv5IxTtNZ8mZofbwJq+G/I7rO36uq8AMERCsRXjwtLlV07M5eZa+gjQ6GroqAvyvQ== X-Received: by 2002:a05:6000:1ca:b0:429:b8c7:1848 with SMTP id ffacd0b85a97d-42cb220e976mr2816927f8f.19.1763565261828; Wed, 19 Nov 2025 07:14:21 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:263d:925b:a11f:ae36? ([2a01:e0a:3d9:2080:263d:925b:a11f:ae36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53e845bdsm37266810f8f.12.2025.11.19.07.14.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Nov 2025 07:14:21 -0800 (PST) Message-ID: Date: Wed, 19 Nov 2025 16:14:20 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Neil Armstrong Subject: Re: [PATCH] phy: cadence-torrent: restore parent clock for refclk during resume To: "Thomas Richard (TI.com)" , Vinod Koul , Kishon Vijay Abraham I Cc: Thomas Petazzoni , Gregory CLEMENT , Udit Kumar , Prasanth Mantena , Abhash Kumar , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20251110-phy-cadence-torrent-resume-restore-refclk-parent-v1-1-1be87af7d19e@bootlin.com> From: Neil Armstrong Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20251110-phy-cadence-torrent-resume-restore-refclk-parent-v1-1-1be87af7d19e@bootlin.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 11/10/25 15:07, Thomas Richard (TI.com) wrote: > While suspend and resume, parent clock config for refclk was getting lost. > So save and restore it in suspend and resume operations. > > Signed-off-by: Thomas Richard (TI.com) > --- > drivers/phy/cadence/phy-cadence-torrent.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/phy/cadence/phy-cadence-torrent.c b/drivers/phy/cadence/phy-cadence-torrent.c > index 37fa4bad6bd7..17d09e7d866d 100644 > --- a/drivers/phy/cadence/phy-cadence-torrent.c > +++ b/drivers/phy/cadence/phy-cadence-torrent.c > @@ -384,6 +384,7 @@ struct cdns_torrent_phy { > struct regmap_field *phy_reset_ctrl; > struct regmap_field *phy_pcs_iso_link_ctrl_1[MAX_NUM_LANES]; > struct clk_hw_onecell_data *clk_hw_data; > + int refclk_parent; Can't this be stored in struct cdns_torrent_refclk_driver ? > }; > > enum phy_powerstate { > @@ -3329,8 +3330,13 @@ static const struct cdns_torrent_vals sgmii_qsgmii_xcvr_diag_ln_vals = { > static int cdns_torrent_phy_suspend_noirq(struct device *dev) > { > struct cdns_torrent_phy *cdns_phy = dev_get_drvdata(dev); > + struct clk_hw *refclk_hw = cdns_phy->clk_hw_data->hws[CDNS_TORRENT_REFCLK_DRIVER]; > + struct cdns_torrent_refclk_driver *refclk_driver = to_cdns_torrent_refclk_driver(refclk_hw); > int i; > > + regmap_field_read(refclk_driver->cmn_fields[CMN_CDIAG_REFCLK_DRV0_CTRL_4], > + &cdns_phy->refclk_parent); Can't cdns_torrent_refclk_driver_get_parent()/set_parent() be used instead ? Or even better add cdns_torrent_refclk_driver_suspend/_resume() functions to handle that. Neil > + > reset_control_assert(cdns_phy->phy_rst); > reset_control_assert(cdns_phy->apb_rst); > for (i = 0; i < cdns_phy->nsubnodes; i++) > @@ -3349,9 +3355,14 @@ static int cdns_torrent_phy_suspend_noirq(struct device *dev) > static int cdns_torrent_phy_resume_noirq(struct device *dev) > { > struct cdns_torrent_phy *cdns_phy = dev_get_drvdata(dev); > + struct clk_hw *refclk_hw = cdns_phy->clk_hw_data->hws[CDNS_TORRENT_REFCLK_DRIVER]; > + struct cdns_torrent_refclk_driver *refclk_driver = to_cdns_torrent_refclk_driver(refclk_hw); > int node = cdns_phy->nsubnodes; > int ret, i; > > + regmap_field_write(refclk_driver->cmn_fields[CMN_CDIAG_REFCLK_DRV0_CTRL_4], > + cdns_phy->refclk_parent); > + > ret = cdns_torrent_clk(cdns_phy); > if (ret) > return ret; > > --- > base-commit: 415559c31bd4f19fde440f759d529a448743fc8c > change-id: 20251110-phy-cadence-torrent-resume-restore-refclk-parent-f59fb5fc69fa > > Best regards,