From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751484AbdAWRmc (ORCPT ); Mon, 23 Jan 2017 12:42:32 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:56845 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750950AbdAWRm3 (ORCPT ); Mon, 23 Jan 2017 12:42:29 -0500 Subject: Re: [PATCHSET v4] blk-mq-scheduling framework To: Paolo Valente References: <1481933536-12844-1-git-send-email-axboe@fb.com> <7A8A5078-E9B8-4EBF-BAB1-9E8EEBF3A043@linaro.org> <37570439-97C8-4009-B143-C5E78789A137@linaro.org> <2028A64C-40E5-403D-B5E9-05863E94B4C5@linaro.org> <59b134de-5d2d-5f16-3118-bdc16bc6e36b@fb.com> <22EDFDE7-71FF-4265-8DDE-B141D3FD26B2@linaro.org> CC: Jens Axboe , , Linux-Kernal , Omar Sandoval , Linus Walleij , Ulf Hansson , Mark Brown From: Jens Axboe Message-ID: Date: Mon, 23 Jan 2017 10:42:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <22EDFDE7-71FF-4265-8DDE-B141D3FD26B2@linaro.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: CO1PR15CA0028.namprd15.prod.outlook.com (10.166.26.166) To BN6PR15MB1185.namprd15.prod.outlook.com (10.172.205.139) X-MS-Office365-Filtering-Correlation-Id: de8730da-769c-4509-0179-08d443b72faa X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN6PR15MB1185; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;3:KWW6qtI5Cx55Y/KSP93S8UWxrnpVQFvqHlBnoAELgQwPb0gVrgLLvLK+jP7fhq29IJPva0+mJq6WGP/Yc1gtf+XzRjCbH+t+3KgAFvK4SlwUQAEJ/+OHk/hLkPK4wOs/Qo1ri0BjWmfWEKQRGuAO6lYARHRnCTqnzOxDjNowXwtNl/05eQUG34+mU9H/VIYGxiDIRsBS9wXQJ1YAzJg0NOYg7amYExIkg6Q62wXCqXkdzHqLf+0ZCfMfIAngxgB8k6swCSH0o6VQB5pDPMlcxA==;25:zIJdijCMC3izGwHUWqs178kKzUTTDuZS26B0oq8Uq4niKs98o+rhGQke5+v8uDVIpvuSr+8xPSiZBZuJPRy49D9uRe7I3yX/PqArSHkjCLL8aynooqNJsYCnx1LZOqDkkDwEhSD7YHBgQmNvBq+tIG1N1R5ArfHrcGfZcSQgUJF1PJfAZsYW7CtRzT6DKf4OfkJMPo4pgsFOtY/kmgxaoWIFxRo358hWON+aERxKhhSjMyzPDgNV15GO1YGy3sWrRBAd3Lx/9x2gopXm+EJcyHtY/ZG6Umf1tpcAEwVyLDO2qGo3mLxEa8VrJt1JWiE8c6JlxyplVlv+LZlFl0vF9wSt+RVo3oAM28HnC/3h6IuUXf1GzIOu6kB5vgUbHNCNJdZtjzGGGubeAT/vLDUcivmuepv4nbSJouT6NREhReWRynKzpiy8GPkJwfw0iqxk3b5ptj92O0wxDTVSLLvbHw== X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;31:5z6SlhVi4Y7tNqKWcRviDA85dgLhbWf8hyqQ1UfGL3PSM4rw5m2uOsSg6gkVHKkABEvK/bJn0PVFuEAn5RNM1sXvQoN4WOHP6q7pIVxgg5Er+JONyNPE1mS1T7MajwIH0Ta2gXsQQjk4/o3wCweGZO6g+zTIW57Wv4X6JyXxedIRLMYQny+H0+n2/zrkfK+luB1dbT5m7OxNmQOaoLwmqdefaDAQ9ND+FRv2CrPtd/E53+/4w+KV9RRYGKmX5BQy4T17/15BXTxySfMA9OwPjA==;20:XitQ2HOmYG9lS9TJauOYiJMlimfZhTIIpe65jA6qjwGZsXMQEimHeVm0yOtZKosGK0U8p8qwNcvUCCCf+X8HSzvnTGb3d+jIHwSE8Jg4k+opmF+k91UhxTe8Q6QBfsk78iAjwB18UNtMM7FeBxUMS6JDJTwFmhvp1VRPphhLXvUyhVyanqZ6E6GBvMASjqgr2P/rDsGgNFdSlszW90BGVxjqgCnPspHO1o1qILdJtJXXFJ6rYcpg1PvjGP1gwc5gshZTXYqe6Iby3NS/lSGkxJ8BRuxIRiN43pGgSgmes5ANNkEcNCtVZeFLUxUbbIJVgoxLINdTlsrmYhP4K0DeM5WL5hXc/jjK88ZGGTa3fzAGEkGy9nYUVNLUN4tUEbxHw3KbjXsi49H58eKSlZIt6MP7fZMHQnSTpkwXGorDVJ/JumvhWJLNd9FYeZCkyET0Rfu2484649YP5bHpkSamTyfOPvb994l985siH+iqoQaLbP459KVFIssywsR30Bxt X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(67672495146484); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148);SRVR:BN6PR15MB1185;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1185; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;4:6xuj+eFzMZNukQmNLWp6G3R6sYRpMrZffdw0kYRzVf+m6SLd/D5FbSXEPRSAsgg8f2y1uoThJMZrfRNPR6S29dfFWHzRVEZV7k83yhpUAwsao2SyVN5HJDRxmiUXROP2+jIDYYtcgHLrmObO1i2CE+Emj7RqKJs9+nN09eeV1LzHqoaV04PVnJ+aDlOZf5c4GC2TT6GK2pGCkuPVTxO02Z7i/QLIxrOqzSru1uZiXJuOFhy7SJ2G+8Xej8Ltv16UJboLT0+fK4ehCsDGaCrES2zntPx2PxQoLROAT3i4ViAXahpDF2hGv+xVHwNytpE/gpfZJuGvGWBVz6yFX0BgyXR7se2b4yhN8EMh6duUu71eBDv2mF1L6jBja+1Y64K+gqGIfzJqlUf3+opRaT2A/esZhIjt7MFNhiN857QewwwElAybwBITIeRJ9fXtjWi3HZtZzbtDt0HP/K5WyMAtxY4l9LC+3wdrGn/NIq51ukg9uS275FrF8PLjPMqezbMZ09OsT0SYHRPES1oX8kSQmNpj8HqMEMWrWKJA4lIVvrXKBaaLO3BTco6fejtZcWH73fTOmXuApEy1GFqn0Q+v1bo4Dtk4ffvjJtOeNO8LDCzCr2PKn/aOQP7piHikRrAL X-Forefront-PRVS: 0196A226D1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(39830400002)(39410400002)(39450400003)(377454003)(189002)(24454002)(199003)(81156014)(81166006)(8676002)(33646002)(90366009)(68736007)(38730400001)(117156001)(65826007)(6486002)(229853002)(77096006)(101416001)(5660300001)(23746002)(36756003)(4326007)(47776003)(3846002)(2906002)(6116002)(50466002)(93886004)(64126003)(92566002)(50986999)(7736002)(76176999)(230700001)(54356999)(305945005)(65806001)(65956001)(66066001)(6666003)(42186005)(83506001)(54906002)(31686004)(53936002)(230783001)(110136003)(105586002)(97736004)(4001350100001)(2950100002)(106356001)(6916009)(189998001)(25786008)(31696002)(86362001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1185;H:[192.168.1.154];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR15MB1185;23:Scp9UyhdnYnRXX9YXHMSBdvpN+vg8uQM+ujAg?= =?Windows-1252?Q?rAIF5EkDWpRSJUrhXtWOzMK0gVitNbcRAoGXGwhQdGholtWc/Xw4JHSy?= =?Windows-1252?Q?yyZk0AlzqUpTWvHAUoc0MMDFYoZiGMjycvNHnKay8v0jtwzmzsedKUy+?= =?Windows-1252?Q?TZ2lJ3+hXdm8nGZF474Am1qFp7fMg+wAp7eLqXNVPylO1msXF320XFtm?= =?Windows-1252?Q?XP/po4mGT8dhp/rPUcBCKasV2flJ6uREq5R6Vh8DaAwNMaqGGKuuXRP/?= =?Windows-1252?Q?WvAdgrYm3R27EFl2t717AM4rCZ4Ghy7CACCpufFYpqVftNt+1n/mE5hk?= =?Windows-1252?Q?S2cflnsUuYZgFi0r12x7c/v89Mf03l0+tsU0Dm2y6iPCcEP28l4R1ahl?= =?Windows-1252?Q?TjPua/mMUX8vaBBvyyJre7RM+Nymmh+xhO6UOz1Af19AptQCmwkfqJ7j?= =?Windows-1252?Q?MF0CXx6YgMKu6OInt8GVCZ1iqPNT5wiQQDG3IM7fv8QO2FymdkmRCi7E?= =?Windows-1252?Q?8Dt1/YFsEtsr1u8lwxfIA8oGEeord9+UFS2H5GWm+SAy9cyxAWF2PXnl?= =?Windows-1252?Q?FPAY/omfweXaTVoSOh1tg61iEUmiuMQWZx/pQxS15BYkktNzuO13162y?= =?Windows-1252?Q?uyH5J34b1/XZva2jsKMmprAib33SaoF7z9k5b2pBKzxCDAY58vjsUko3?= =?Windows-1252?Q?5gk2YByA54OzcBzVHtWCKu15JPhEUIA/VMYTznUw/H7eZo0iQreueLyN?= =?Windows-1252?Q?bRpqrm6vaa0aeT8smGosLX/BC7bLYVjM9vrVCp8aucOpnnJOZMidsxOV?= =?Windows-1252?Q?OoC5OORA0xFmQqcxNoKm6fqtmF1C4+km4JB8FXG0ZG5G9PStO2Y3CkJE?= =?Windows-1252?Q?hjvcNDLSPc6C6RRwXppNu0IPkSuCqMEQI7T1fehtbX+1k2ebADvL5Exz?= =?Windows-1252?Q?VNFT5XOrr/ZA4DRyzoaO9BXMAnHWjBVc8DXZMGjrZWgGeMi0tgCtwgsU?= =?Windows-1252?Q?lg3Mnf7LcgrjSR2IbdNAEZP+4kEXRlFvvrphWJ4dFpfDQwZ3ItaPPRkW?= =?Windows-1252?Q?G7pvRr8ObwaSvM1EfmW0VPxW/R2uNQl1Qpn35oV5qwRi2YYiMmW/Ox7O?= =?Windows-1252?Q?bKRSEvb++I2RepSTj8CrLyDaf/r+3l2JL6zcwJ6paCPaXOtKMJuRjYEK?= =?Windows-1252?Q?n6z6Q3o2Sn+tm7NIMAe9BGLkFAOKmKDCOcDALHSewNENNZpSkX4STd4W?= =?Windows-1252?Q?20XM6oxkZcTnwNroOuifM89Mn+BdwWHv+7NQP+xUHQyflQLAVVhHGxnu?= =?Windows-1252?Q?m1o95XJvgitudPorAgVg7Z0INog59JUEXuXiaAvwRLNZe+FnNGK7dlau?= =?Windows-1252?Q?4+0ta0tACF4ktNqWgqSvq45W11ecVpGI8w0+QgCKGVwIP0zBDFkOtXMo?= =?Windows-1252?Q?vY0JRHlCPqIIhFSxwy8z3P+bj69EpltACdmLcX1yLRSYRclNoUuNxAFG?= =?Windows-1252?Q?cDZanhAqY64oMjQnpVOSX0nIAeQZbWUMRm98kZuMlPZe5HhtprYKSMsH?= =?Windows-1252?Q?aNCWN3qtRANckp7O6BXWTAeZwrD8AngUEDzhqMIKiVNkAltmnYfoW3wl?= =?Windows-1252?Q?ZkxHGoDkSxz6wMph/UUj7w=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;6:cX+d6KRUWWBdCnDyhYK+AV18xRTmSQsFVLZAKoYfI8mxMxUv6kZfZqV3yiz6jP0XL3prkdPZwTpsGVeEdGqmjPBFLTokxu5gHRqSyypZBX3LKo133JW59brYliu7oHeu1/h6Y7C2ZS5q85oITNxu5eyvsKqRutwrAMrQfUzs17MF4eJjaegQn33Y2PwKrJvjM14tYI/K3PVj7TQqBfaA25pAr17uphC92WMCHu9AIViaubMbVIJmEhJOb//ssq50zttcY+ckPAE55kA2sZB3kQJEu7olsoqKfVVQcohuHQwjINiVqLx49QBvZO/XPjBYf2/xtsmlXVrs8/GFNjXEE8p0XeZQ+ol6WvbcdL1oIzhAustuuPxxDke1fnRF8ajqn3d/HM9XzQiSq0i6ovG0OlEi1SLqj8UJQXDGCtTdorg=;5:L2Vdys1krbZomCeayVwR1TDUBkWJ46sYDZmR23/MltNc1qrMjAAD48EQtjz+Xvl93sW0dmk4YZplqKLhec3IxCriOH0EDeeHSXk2NMg06bLGzONClOmgIkb/XCRXKrCLEKmj8jwAqyNrtk7pr2KlRg==;24:jGOvnjqBt9Bc/PXO3Ze1VhCmEb7BiFDv5579LY0TwTwZbqF59bPdpBZeaZEvuFyIgZGpvvBY9Ls8XBzZDe8KM/1UVWcsWbUbSPJiZf2ggC0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;7:RZmCICUQO/uTI9Lp4b6QSu1VRGNwueir4qsunOTSM7kiNQ+OzM8KwXSlFi0Tiq9dKDCS5/TYSjl6G1gD59LFjgS3hPNISA/Aiv2aFxO9zXXuBuQg0rP1Lw/RIJEaiys8kad4FjmzhEJ4BQjm9uWN6Sw6ldOCdNTiLMZ6USkm/dYBUQAk+myrg9CykbEBG2lsVsZGtIaiEHtdWrprvmQg5JvC0jU8kHk5xRek1NQwPqvNu2lRLMYs6mxCt4XSPour2qQguxLDoMvjR3/eymY07ENrT+NjS9/aLJbuXRtqoZwqqQuxIhs/80ulAw9nM7+rKrkDBCPCkToQfka4XwEFkpYRiZ6pW65uGZr/4p1/obBrqEplK+LW2fUeGNKNfAxLm35DAurKtikX1GPqlo/poeJy+pYPd4Y1SXCs1ZjqislJYAGHpjB9rUf/gkZH6xIOGu+++99Qy176sznu1xHnrg==;20:zAR8mU4l6Wu2g3bgPCqa3lkx9ODeF5T9zKFbAQ6VKZIDgW9qSlhRvXIbfqMxrMOH0yXCHJD5P0jux/dqGwEuDZVhN0H658NxoDMCbebJPIGF425MpR/Tx5gpZd45zxlLNaDGsUsT/NTyY7vnxfeiOIKgiNTAo7hf9BuRSh2jfdU= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2017 17:42:20.5703 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1185 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-23_15:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/23/2017 10:04 AM, Paolo Valente wrote: > >> Il giorno 18 gen 2017, alle ore 17:21, Jens Axboe ha scritto: >> >> On 01/18/2017 08:14 AM, Paolo Valente wrote: >>> according to the function blk_mq_sched_put_request, the >>> mq.completed_request hook seems to always be invoked (if set) for a >>> request for which the mq.put_rq_priv is invoked (if set). >> >> Correct, any request that came out of blk_mq_sched_get_request() >> will always have completed called on it, regardless of whether it >> had IO started on it or not. >> > > It seems that some request, after being dispatched, happens to have no > mq.put_rq_priv invoked on it now or then. Is it expected? If it is, > could you point me to the path through which the end of the life of > such a request is handled? I'm guessing that's a flush request. I added RQF_QUEUED to check for that, if RQF_QUEUED is set, you know it has come from your get_request handler. I'm assuming that is it, let me know. -- Jens Axboe