From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B2CCB2F6585 for ; Mon, 20 Oct 2025 10:16:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760955374; cv=none; b=c6xxxcn46romx5vLG5tAG2J9UsmaDELav6o1nse6KUQKWgVZyVzzbM5h70gDLOFmxqKov10rhJIwrN7QLlqyTF1xceGqmFuIgqGMxNKklKbXmjv2meNZ0HTnrBZaWQjQ2KfYXYqrInUnSJoGic+eogNbeaw5yJVZKvCwiKSuvJA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760955374; c=relaxed/simple; bh=CLUkAi1bAjNY/50j+64miftzFu18/7PwdxO7o5j+lUA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DaFLlucieP9xJczdeBotakgo8wv1LpPMvsiLZ8aNHhAne6/v/gusmXEAF+ranhHTC1MJzlrb78tABnVA8omr5+rKZEkSYZqHj5Jjmn7r3KiTcyN+73Zx21MpB4qB6rPEWMVKja5XuS+nA6wJYTxkXi58zc+GN3uznkogtdqmav0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 113321063; Mon, 20 Oct 2025 03:16:04 -0700 (PDT) Received: from [10.1.31.45] (e127648.arm.com [10.1.31.45]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E292C3F63F; Mon, 20 Oct 2025 03:16:10 -0700 (PDT) Message-ID: Date: Mon, 20 Oct 2025 11:16:09 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sched: Remove unused variable in mm_cid_get() To: Kevin Brodsky , linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com Cc: Mathieu Desnoyers , Ingo Molnar , Peter Zijlstra , Juri Lelli References: <20251017073050.2411988-1-kevin.brodsky@arm.com> Content-Language: en-US From: Christian Loehle In-Reply-To: <20251017073050.2411988-1-kevin.brodsky@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/17/25 08:30, Kevin Brodsky wrote: > The cpumask variable in mm_cid_get() has never been used, remove it. > > This fixes a -Wunused-but-set-variable warning when building with > W=1. > > Signed-off-by: Kevin Brodsky > --- > Cc: Mathieu Desnoyers > Cc: Ingo Molnar > Cc: Peter Zijlstra > Cc: Juri Lelli > --- > kernel/sched/sched.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h > index 1f5d07067f60..361f9101cef9 100644 > --- a/kernel/sched/sched.h > +++ b/kernel/sched/sched.h > @@ -3740,11 +3740,9 @@ static inline int mm_cid_get(struct rq *rq, struct task_struct *t, > struct mm_struct *mm) > { > struct mm_cid __percpu *pcpu_cid = mm->pcpu_cid; > - struct cpumask *cpumask; > int cid; > > lockdep_assert_rq_held(rq); > - cpumask = mm_cidmask(mm); > cid = __this_cpu_read(pcpu_cid->cid); > if (mm_cid_is_valid(cid)) { > mm_cid_snapshot_time(rq, mm); > > base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787 Andy also posted this: https://lore.kernel.org/lkml/20251015091935.2977229-1-andriy.shevchenko@linux.intel.com/