From: Andrew Davis <afd@ti.com>
To: Michael Walle <mwalle@kernel.org>,
Frank Binns <frank.binns@imgtec.com>,
Matt Coster <matt.coster@imgtec.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Nishanth Menon <nm@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>
Cc: <dri-devel@lists.freedesktop.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH 1/3] dt-bindings: gpu: img: Add AM62P SoC specific compatible
Date: Wed, 16 Jul 2025 11:17:26 -0500 [thread overview]
Message-ID: <d76c0299-a19d-4524-b026-79874fee10ee@ti.com> (raw)
In-Reply-To: <20250716134717.4085567-2-mwalle@kernel.org>
On 7/16/25 8:47 AM, Michael Walle wrote:
> The AM62P and the J722S features the same BXS-4 GPU as the J721S2. Add a
> new SoC specific compatible.
>
If the GPU is the same, and the integration is the same, do you really need
a new compatible?
> Signed-off-by: Michael Walle <mwalle@kernel.org>
> ---
> Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> index 4450e2e73b3c..bad3e412a168 100644
> --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> @@ -23,6 +23,7 @@ properties:
> - const: img,img-rogue
> - items:
> - enum:
> + - ti,am62p-gpu
There is a check below based on SoC compat:
> - if:
> properties:
> compatible:
> contains:
> enum:
> - ti,am62-gpu
> - ti,j721s2-gpu
> then:
> properties:
> clocks:
> maxItems: 1
If you do add a new SoC specific compatible does this check need updating?
Andrew
> - ti,j721s2-gpu
> - const: img,img-bxs-4-64
> - const: img,img-rogue
next prev parent reply other threads:[~2025-07-16 16:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 13:47 [RFC PATCH 0/3] drm/imagination: add AM62P/AM67A/J722S support Michael Walle
2025-07-16 13:47 ` [RFC PATCH 1/3] dt-bindings: gpu: img: Add AM62P SoC specific compatible Michael Walle
2025-07-16 16:17 ` Andrew Davis [this message]
2025-07-17 6:56 ` Michael Walle
2025-07-16 13:47 ` [RFC PATCH 2/3] drm/imagination: fix clock control on the J722S Michael Walle
2025-08-13 18:19 ` Krzysztof Kozlowski
2025-07-16 13:47 ` [RFC PATCH 3/3] arm64: dts: ti: add GPU node Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d76c0299-a19d-4524-b026-79874fee10ee@ti.com \
--to=afd@ti.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frank.binns@imgtec.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matt.coster@imgtec.com \
--cc=mripard@kernel.org \
--cc=mwalle@kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).