From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <poza@codeaurora.org>
X-Google-Smtp-Source: ACJfBotehL6C/rHXZAfyswsckM/pVJPAxSnfAS7FZwR21je5EzkL/mzCCl8wPpheHs8dOMTEmXpF
ARC-Seal: i=1; a=rsa-sha256; t=1516252967; cv=none;
        d=google.com; s=arc-20160816;
        b=ELSbJsXtz/+qsvOhmNZ8dIxISGKr2v+lGmnk7PmRk+nmfqO+YVD9G3QY5edFKuwEEx
         LE9DJV75iuWAAfxo5yVkUt74XdvDPNKp5MNlsGNdZaDCJAZLSqs2TnFA3kz+F2zwPo5k
         XEHNlia6Jq+sCGxlJ17XROUbOviDC0OBnQC9l3rSQj/RMx/nGm+8UlaJjjHeApjSGpjX
         pNmcxp6TWptuz/EOf3Ftk2PJM73FLeiHiXT3UZawzPJ45QBEhrVxXZnzbr3nYHjsUSO8
         ZaRK2xeeq7Od+K3vAblM6hFyCOkSw77v0QqMaPW/u+DRa4+z6UDcu9Tdb/fFZZbqhda6
         fhoQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=user-agent:message-id:references:in-reply-to:subject:cc:to:from
         :date:content-transfer-encoding:mime-version:dkim-signature
         :dkim-signature:arc-authentication-results;
        bh=sgT1/XpHMmcZroYq1H6IbqDIAPfrG9PvnilAG8J+zd8=;
        b=bHYJbrPq2oNPN7c0t3rLkgHKi61+E36FVJJzyx61CMR/cPAyOe2FFGz3/AHCHLWroK
         jqhymUSlvgkYagVoTCcOg4mW4fSP7S5SK8w6XaWpgcwVvnNSPx9b8ZWKLpi7OlLrHSzS
         W3lwQkjJqM0OVXbdHwwtJCoY0TlF0rlHYmrQlIc3oDSY8KDjYHOgnKkjMMf230SQsgj9
         8HRMNpPiH5xIqbk7Apu5V9mC9Vh7lKqvV0sDLBfBjHqW8/YkB+qLggeMITGRnoA21pvx
         n12qrOOGFU6ge7hsg0TyNDOjOX3H56fcG0NvDjTPr9NRv4cTZPLqnXcKAN0N6KEKyKjX
         7eyQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@codeaurora.org header.s=default header.b=EZxcTSHl;
       dkim=pass header.i=@codeaurora.org header.s=default header.b=EZxcTSHl;
       spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org
Authentication-Results: mx.google.com;
       dkim=pass header.i=@codeaurora.org header.s=default header.b=EZxcTSHl;
       dkim=pass header.i=@codeaurora.org header.s=default header.b=EZxcTSHl;
       spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Thu, 18 Jan 2018 10:52:46 +0530
From: poza@codeaurora.org
To: Sinan Kaya <okaya@codeaurora.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>, Philippe Ombredanne
 <pombredanne@nexb.com>, Thomas Gleixner <tglx@linutronix.de>, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, Kate Stewart
 <kstewart@linuxfoundation.org>, linux-pci@vger.kernel.org,
 linux-kernel@vger.kernel.org, Dongdong Liu <liudongdong3@huawei.com>, Keith
 Busch <keith.busch@intel.com>, Wei Zhang <wzhang@fb.com>, Timur Tabi
 <timur@codeaurora.org>
Subject: Re: [PATCH v5 3/4] PCI/DPC: Unify and plumb error handling into DPC
In-Reply-To: <298df660-1f7d-85ab-51db-11dc5d80cc75@codeaurora.org>
References: <1516185438-31556-1-git-send-email-poza@codeaurora.org>
 <1516185438-31556-4-git-send-email-poza@codeaurora.org>
 <298df660-1f7d-85ab-51db-11dc5d80cc75@codeaurora.org>
Message-ID: <d78da5a5465c7a1696db755385393519@codeaurora.org>
User-Agent: Roundcube Webmail/1.2.5
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: =?utf-8?q?1589835690475100377?=
X-GMAIL-MSGID: =?utf-8?q?1589906471315830303?=
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

On 2018-01-17 22:15, Sinan Kaya wrote:
> On 1/17/2018 5:37 AM, Oza Pawandeep wrote:
>> +		driver = pci_find_dpc_service(udev);
>> +#endif
>>  #if IS_ENABLED(CONFIG_PCIEAER)
>> -	/* Use the aer driver of the component firstly */
>> -	driver = pci_find_aer_service(udev);
> 
> I think we need a pci_find_service function that unifies these two.

Right now, find_xxx_service are in their respective file and exporting 
it.
which makes sense no less than having generic function.

If I have to change pci_find_service(...., int service_name) then it has 
to be somewhere in generic file.
probably portdrv_core.c

either way I am fine but just thinking out if its really required.

Regards,
Oza.