From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-media@vger.kernel.org,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Songjun Wu <songjun.wu@microchip.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 1/6] [media] atmel-isc: Delete an error message for a failed memory allocation in isc_formats_init()
Date: Mon, 4 Sep 2017 22:05:54 +0200 [thread overview]
Message-ID: <d79fe512-cd52-698f-e212-d987ba2cd533@users.sourceforge.net> (raw)
In-Reply-To: <88d0739c-fdc1-9d7d-fe53-b7c2eeed1849@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 4 Sep 2017 20:33:58 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/media/platform/atmel/atmel-isc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c
index d4df3d4ccd85..f1e635edef72 100644
--- a/drivers/media/platform/atmel/atmel-isc.c
+++ b/drivers/media/platform/atmel/atmel-isc.c
@@ -1510,7 +1510,5 @@ static int isc_formats_init(struct isc_device *isc)
- if (!isc->user_formats) {
- v4l2_err(&isc->v4l2_dev, "could not allocate memory\n");
+ if (!isc->user_formats)
return -ENOMEM;
- }
fmt = &isc_formats[0];
for (i = 0, j = 0; i < ARRAY_SIZE(isc_formats); i++) {
--
2.14.1
next prev parent reply other threads:[~2017-09-04 20:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 20:04 [PATCH 0/6] [media] Atmel: Adjustments for seven function implementations SF Markus Elfring
2017-09-04 20:05 ` SF Markus Elfring [this message]
2017-09-04 20:07 ` [PATCH 2/6] [media] atmel-isc: Improve a size determination in isc_formats_init() SF Markus Elfring
2017-09-04 20:08 ` [PATCH 3/6] [media] atmel-isc: Adjust three checks for null pointers SF Markus Elfring
2017-09-04 20:10 ` [PATCH 4/6] [media] atmel-isi: Delete an error message for a failed memory allocation in two functions SF Markus Elfring
2017-09-04 20:11 ` [PATCH 5/6] [media] atmel-isi: Improve three size determinations SF Markus Elfring
2017-09-04 20:12 ` [PATCH 6/6] [media] atmel-isi: Adjust a null pointer check in three functions SF Markus Elfring
2017-09-06 0:58 ` [PATCH 0/6] [media] Atmel: Adjustments for seven function implementations Yang, Wenyou
2017-09-06 5:59 ` Ludovic Desroches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d79fe512-cd52-698f-e212-d987ba2cd533@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=mchehab@kernel.org \
--cc=songjun.wu@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox