From: Jason Wang <jasowang@redhat.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Stefano Garzarella <sgarzare@redhat.com>
Cc: mst@redhat.com, virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, shahafs@mellanox.com
Subject: Re: [PATCH V2 19/19] vdpa: introduce virtio pci driver
Date: Mon, 7 Dec 2020 11:29:30 +0800 [thread overview]
Message-ID: <d7ae5645-9437-2f03-b0c8-35c1812747d2@redhat.com> (raw)
In-Reply-To: <73a1c314-7398-6182-146f-cd2012646736@infradead.org>
On 2020/12/5 上午1:12, Randy Dunlap wrote:
> On 12/4/20 7:20 AM, Stefano Garzarella wrote:
>> On Fri, Dec 04, 2020 at 12:03:53PM +0800, Jason Wang wrote:
>>> This patch introduce a vDPA driver for virtio-pci device. It bridges
>>> the virtio-pci control command to the vDPA bus. This will be used for
>>> features prototyping and testing.
>>>
>>> Note that get/restore virtqueue state is not supported which needs
>>> extension on the virtio specification.
>>>
>>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>>> ---
>>> drivers/vdpa/Kconfig | 6 +
>>> drivers/vdpa/Makefile | 1 +
>>> drivers/vdpa/virtio_pci/Makefile | 2 +
>>> drivers/vdpa/virtio_pci/vp_vdpa.c | 455 ++++++++++++++++++++++++++++++
>>> 4 files changed, 464 insertions(+)
>>> create mode 100644 drivers/vdpa/virtio_pci/Makefile
>>> create mode 100644 drivers/vdpa/virtio_pci/vp_vdpa.c
>>>
>>> diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig
>>> index 358f6048dd3c..18cad14f533e 100644
>>> --- a/drivers/vdpa/Kconfig
>>> +++ b/drivers/vdpa/Kconfig
>>> @@ -48,4 +48,10 @@ config MLX5_VDPA_NET
>>> be executed by the hardware. It also supports a variety of stateless
>>> offloads depending on the actual device used and firmware version.
>>>
>>> +config VP_VDPA
>>> + tristate "Virtio PCI bridge vDPA driver"
>>> + depends on PCI_MSI && VIRTIO_PCI_MODERN
>>> + help
>>> + This kernel module that bridges virtio PCI device to vDPA bus.
>> ^
>> Without 'that' maybe sound better, but I'm not a native speaker :-)
> Yes, drop 'that', please.
Will fix.
Thanks
>
>>> +
>>> endif # VDPA
next prev parent reply other threads:[~2020-12-07 3:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 4:03 [PATCH V2 00/19] vDPA driver for virtio-pci device Jason Wang
2020-12-04 4:03 ` [PATCH V2 01/19] virtio-pci: do not access iomem via struct virtio_pci_device directly Jason Wang
2020-12-04 4:03 ` [PATCH V2 02/19] virtio-pci: split out modern device Jason Wang
2020-12-04 4:03 ` [PATCH V2 03/19] virtio-pci-modern: factor out modern device initialization logic Jason Wang
2020-12-04 4:03 ` [PATCH V2 04/19] virtio-pci-modern: introduce vp_modern_remove() Jason Wang
2020-12-04 4:03 ` [PATCH V2 05/19] virtio-pci-modern: introduce helper to set config vector Jason Wang
2020-12-04 4:03 ` [PATCH V2 06/19] virtio-pci-modern: introduce helpers for setting and getting status Jason Wang
2020-12-04 4:03 ` [PATCH V2 07/19] virtio-pci-modern: introduce helpers for setting and getting features Jason Wang
2020-12-04 4:03 ` [PATCH V2 08/19] virtio-pci-modern: introduce vp_modern_generation() Jason Wang
2020-12-04 4:03 ` [PATCH V2 09/19] virtio-pci-modern: introduce vp_modern_set_queue_vector() Jason Wang
2020-12-04 4:03 ` [PATCH V2 10/19] virtio-pci-modern: introduce vp_modern_queue_address() Jason Wang
2020-12-04 4:03 ` [PATCH V2 11/19] virtio-pci-modern: introduce helper to set/get queue_enable Jason Wang
2020-12-04 4:03 ` [PATCH V2 12/19] virtio-pci-modern: introduce helper for setting/geting queue size Jason Wang
2020-12-04 4:03 ` [PATCH V2 13/19] virtio-pci-modern: introduce helper for getting queue nums Jason Wang
2020-12-04 4:03 ` [PATCH V2 14/19] virtio-pci-modern: introduce helper to get notification offset Jason Wang
2020-12-04 4:03 ` [PATCH V2 15/19] virito-pci-modern: rename map_capability() to vp_modern_map_capability() Jason Wang
2020-12-04 4:03 ` [PATCH V2 16/19] virtio-pci: introduce modern device module Jason Wang
2020-12-04 17:10 ` Randy Dunlap
2021-01-04 3:22 ` Jason Wang
2020-12-04 4:03 ` [PATCH V2 17/19] vdpa: set the virtqueue num during register Jason Wang
2020-12-04 14:30 ` Stefano Garzarella
2020-12-04 4:03 ` [PATCH V2 18/19] virtio_vdpa: don't warn when fail to disable vq Jason Wang
2020-12-04 4:03 ` [PATCH V2 19/19] vdpa: introduce virtio pci driver Jason Wang
2020-12-04 15:20 ` Stefano Garzarella
2020-12-04 17:12 ` Randy Dunlap
2020-12-07 3:29 ` Jason Wang [this message]
2021-01-04 3:28 ` Jason Wang
2020-12-31 3:52 ` [PATCH V2 00/19] vDPA driver for virtio-pci device Jason Wang
2021-01-03 12:37 ` Michael S. Tsirkin
2021-01-04 6:58 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7ae5645-9437-2f03-b0c8-35c1812747d2@redhat.com \
--to=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=rdunlap@infradead.org \
--cc=sgarzare@redhat.com \
--cc=shahafs@mellanox.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox