From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A405E32C937 for ; Thu, 2 Apr 2026 02:49:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775098180; cv=none; b=KHjYorjYLXJd6O9xAXXbT+wnrRkkb8voSufO4mdh7YLSFDiNZax9Tp1rbEPi5Waf7XHJftqxLFmaPpgJFHUqa6p4wiUyKZxAa/0Czv3P4rFLyVjP7JI+u4uqB0TcTofLaGQ59nR5o6PO4d0Ke/w7pUzqg6vYadOD3U60/lLyF0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775098180; c=relaxed/simple; bh=PWCLb79f++jP4a6gIbEzEcLLojpWQPTQXxqZizi7hZ0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ghd0YqRZq+PSKH9nMhsUDMwysU5G6JypG+32ThqT5jl2GJKAOQrFuoXgiw6cOStsgIvPK/jzrfA3jmpzeGoZqJ+cyYnibnvLAOZ7U0qMXk5iecKRYTpCiRpuTKocEQZbvN5ujgbWq/TwmfDRfyrwM7UYkAI+WeL6/9KoZTfkUQw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=DaQU0+fV; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="DaQU0+fV" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0F4171BCA; Wed, 1 Apr 2026 19:49:32 -0700 (PDT) Received: from [10.164.18.48] (J09HK2D2RT.blr.arm.com [10.164.18.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 21A883F7D8; Wed, 1 Apr 2026 19:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1775098177; bh=PWCLb79f++jP4a6gIbEzEcLLojpWQPTQXxqZizi7hZ0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DaQU0+fVeGSUmDt5Fvxa2+l6wILZfgQfNIvT6hHMixHx2D953BaGObCTjmwRNNadC z2V5eZzb/5X3Ore48kA9YUakoABWe0AR9UTaAkMe1lRMSUsbHT0OmKEXaadRcWS47n iaitu5wdvxFnaruc7ITfuIhlDNf62J170DIMhZ78= Message-ID: Date: Thu, 2 Apr 2026 08:19:30 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/thp: dead code cleanup in Kconfig To: Julian Braha , akpm@linux-foundation.org, vbabka@kernel.org, hannes@cmpxchg.org Cc: mhocko@suse.com, surenb@google.com, rppt@kernel.org, Liam.Howlett@oracle.com, ljs@kernel.org, david@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260331070730.33915-1-julianbraha@gmail.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20260331070730.33915-1-julianbraha@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 31/03/26 12:37 PM, Julian Braha wrote: > There is already an 'if TRANSPARENT_HUGEPAGE' condition wrapping several > config options e.g. 'READ_ONLY_THP_FOR_FS', making > the 'depends on' statement for each of these a duplicate dependency > (dead code). > > I propose leaving the outer 'if TRANSPARENT_HUGEPAGE...endif' and removing > the individual 'depends on TRANSPARENT_HUGEPAGE' statement from each > option. > > This dead code was found by kconfirm, a static analysis tool for Kconfig. > > Signed-off-by: Julian Braha Reviewed-by: Anshuman Khandual > --- > mm/Kconfig | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index e8bf1e9e6ad9..29d2de0d5c06 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -810,7 +810,6 @@ if TRANSPARENT_HUGEPAGE > > choice > prompt "Transparent Hugepage Support sysfs defaults" > - depends on TRANSPARENT_HUGEPAGE > default TRANSPARENT_HUGEPAGE_ALWAYS > help > Selects the sysfs defaults for Transparent Hugepage Support. > @@ -840,7 +839,6 @@ endchoice > > choice > prompt "Shmem hugepage allocation defaults" > - depends on TRANSPARENT_HUGEPAGE > default TRANSPARENT_HUGEPAGE_SHMEM_HUGE_NEVER > help > Selects the hugepage allocation policy defaults for > @@ -886,7 +884,6 @@ endchoice > > choice > prompt "Tmpfs hugepage allocation defaults" > - depends on TRANSPARENT_HUGEPAGE > default TRANSPARENT_HUGEPAGE_TMPFS_HUGE_NEVER > help > Selects the hugepage allocation policy defaults for > @@ -931,7 +928,7 @@ endchoice > > config THP_SWAP > def_bool y > - depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP && SWAP && 64BIT > + depends on ARCH_WANTS_THP_SWAP && SWAP && 64BIT > help > Swap transparent huge pages in one piece, without splitting. > XXX: For now, swap cluster backing transparent huge page > @@ -941,7 +938,6 @@ config THP_SWAP > > config READ_ONLY_THP_FOR_FS > bool "Read-only THP for filesystems (EXPERIMENTAL)" > - depends on TRANSPARENT_HUGEPAGE > > help > Allow khugepaged to put read-only file-backed pages in THP.