* [PATCH] clk: davinci: Add NULL check in davinci_lpsc_clk_register
@ 2024-11-14 9:14 Charles Han
2024-11-14 14:18 ` David Lechner
2024-11-14 20:32 ` Stephen Boyd
0 siblings, 2 replies; 5+ messages in thread
From: Charles Han @ 2024-11-14 9:14 UTC (permalink / raw)
To: david, mturquette, sboyd; +Cc: linux-clk, linux-kernel, Charles Han
devm_kasprintf() can return a NULL pointer on failure,but this
returned value in davinci_lpsc_clk_register() is not checked.
Add NULL check in davinci_lpsc_clk_register(), to handle kernel NULL
pointer dereference error.
Fixes: c6ed4d734bc7 ("clk: davinci: New driver for davinci PSC clocks")
Signed-off-by: Charles Han <hanchunchao@inspur.com>
---
drivers/clk/davinci/psc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/clk/davinci/psc.c b/drivers/clk/davinci/psc.c
index 355d1be0b5d8..bc271ea72721 100644
--- a/drivers/clk/davinci/psc.c
+++ b/drivers/clk/davinci/psc.c
@@ -277,6 +277,9 @@ davinci_lpsc_clk_register(struct device *dev, const char *name,
lpsc->pm_domain.name = devm_kasprintf(dev, GFP_KERNEL, "%s: %s",
best_dev_name(dev), name);
+ if (!lpsc->pm_domain.name)
+ return -ENOMEM;
+
lpsc->pm_domain.attach_dev = davinci_psc_genpd_attach_dev;
lpsc->pm_domain.detach_dev = davinci_psc_genpd_detach_dev;
lpsc->pm_domain.flags = GENPD_FLAG_PM_CLK;
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: davinci: Add NULL check in davinci_lpsc_clk_register
2024-11-14 9:14 [PATCH] clk: davinci: Add NULL check in davinci_lpsc_clk_register Charles Han
@ 2024-11-14 14:18 ` David Lechner
2024-11-14 20:32 ` Stephen Boyd
1 sibling, 0 replies; 5+ messages in thread
From: David Lechner @ 2024-11-14 14:18 UTC (permalink / raw)
To: Charles Han, mturquette, sboyd; +Cc: linux-clk, linux-kernel
On 11/14/24 3:14 AM, Charles Han wrote:
> devm_kasprintf() can return a NULL pointer on failure,but this
> returned value in davinci_lpsc_clk_register() is not checked.
> Add NULL check in davinci_lpsc_clk_register(), to handle kernel NULL
> pointer dereference error.
>
> Fixes: c6ed4d734bc7 ("clk: davinci: New driver for davinci PSC clocks")
> Signed-off-by: Charles Han <hanchunchao@inspur.com>
> ---
Reviewed-by: David Lechner <david@lechnology.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: davinci: Add NULL check in davinci_lpsc_clk_register
2024-11-14 9:14 [PATCH] clk: davinci: Add NULL check in davinci_lpsc_clk_register Charles Han
2024-11-14 14:18 ` David Lechner
@ 2024-11-14 20:32 ` Stephen Boyd
1 sibling, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2024-11-14 20:32 UTC (permalink / raw)
To: Charles Han, david, mturquette, sboyd
Cc: linux-clk, linux-kernel, Charles Han
Quoting Charles Han (2024-11-14 01:14:22)
> devm_kasprintf() can return a NULL pointer on failure,but this
> returned value in davinci_lpsc_clk_register() is not checked.
> Add NULL check in davinci_lpsc_clk_register(), to handle kernel NULL
> pointer dereference error.
>
> Fixes: c6ed4d734bc7 ("clk: davinci: New driver for davinci PSC clocks")
> Signed-off-by: Charles Han <hanchunchao@inspur.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] clk: davinci: Add NULL check in davinci_lpsc_clk_register
@ 2025-04-07 9:20 Charles Han
2025-04-08 14:14 ` David Lechner
0 siblings, 1 reply; 5+ messages in thread
From: Charles Han @ 2025-04-07 9:20 UTC (permalink / raw)
To: david, mturquette, sboyd; +Cc: linux-clk, linux-kernel, Charles Han
devm_kasprintf() can return a NULL pointer on failure,but this
returned value in davinci_lpsc_clk_register() is not checked.
Add NULL check in davinci_lpsc_clk_register(), to handle kernel
NULL pointer dereference error.
Fixes: c6ed4d734bc7 ("clk: davinci: New driver for davinci PSC clocks")
Signed-off-by: Charles Han <hanchunchao@inspur.com>
---
drivers/clk/davinci/psc.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/clk/davinci/psc.c b/drivers/clk/davinci/psc.c
index b48322176c21..872fed50dece 100644
--- a/drivers/clk/davinci/psc.c
+++ b/drivers/clk/davinci/psc.c
@@ -277,6 +277,11 @@ davinci_lpsc_clk_register(struct device *dev, const char *name,
lpsc->pm_domain.name = devm_kasprintf(dev, GFP_KERNEL, "%s: %s",
best_dev_name(dev), name);
+ if (!lpsc->pm_domain.name) {
+ kfree(lpsc);
+ return ERR_PTR(-ENOMEM);
+ }
+
lpsc->pm_domain.attach_dev = davinci_psc_genpd_attach_dev;
lpsc->pm_domain.detach_dev = davinci_psc_genpd_detach_dev;
lpsc->pm_domain.flags = GENPD_FLAG_PM_CLK;
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: davinci: Add NULL check in davinci_lpsc_clk_register
2025-04-07 9:20 Charles Han
@ 2025-04-08 14:14 ` David Lechner
0 siblings, 0 replies; 5+ messages in thread
From: David Lechner @ 2025-04-08 14:14 UTC (permalink / raw)
To: Charles Han, mturquette, sboyd; +Cc: linux-clk, linux-kernel
On 4/7/25 4:20 AM, Charles Han wrote:
> devm_kasprintf() can return a NULL pointer on failure,but this
> returned value in davinci_lpsc_clk_register() is not checked.
> Add NULL check in davinci_lpsc_clk_register(), to handle kernel
> NULL pointer dereference error.
>
> Fixes: c6ed4d734bc7 ("clk: davinci: New driver for davinci PSC clocks")
> Signed-off-by: Charles Han <hanchunchao@inspur.com>
> ---
Thanks, but this looks like a duplicate of [1].
[1]: https://lore.kernel.org/linux-clk/20250401131341.26800-1-bsdhenrymartin@gmail.com/
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-04-08 14:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-14 9:14 [PATCH] clk: davinci: Add NULL check in davinci_lpsc_clk_register Charles Han
2024-11-14 14:18 ` David Lechner
2024-11-14 20:32 ` Stephen Boyd
-- strict thread matches above, loose matches on Subject: below --
2025-04-07 9:20 Charles Han
2025-04-08 14:14 ` David Lechner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox