Re: [PATCH v2 2/8] dt-bindings: clock: document 8ULP's SIM LPAV

Frank Li
2025-10-17T14:33:27Z

On Fri, Oct 17, 2025 at 04:20:19AM -0700, Laurentiu Mihalcea wrote:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>
> Add documentation for i.MX8ULP's SIM LPAV module.
>
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> ---
> .../bindings/clock/fsl,imx8ulp-sim-lpav.yaml | 72 +++++++++++++++++++
> include/dt-bindings/clock/imx8ulp-clock.h | 5 ++
> .../dt-bindings/reset/fsl,imx8ulp-sim-lpav.h | 16 +++++
> 3 files changed, 93 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/fsl,imx8ulp-sim-lpav.yaml
> create mode 100644 include/dt-bindings/reset/fsl,imx8ulp-sim-lpav.h
>
> diff --git a/Documentation/devicetree/bindings/clock/fsl,imx8ulp-sim-lpav.yaml b/Documentation/devicetree/bindings/clock/fsl,imx8ulp-sim-lpav.yaml
> new file mode 100644
> index 000000000000..fb3b9028a4c3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/fsl,imx8ulp-sim-lpav.yaml
> @@ -0,0 +1,72 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/fsl,imx8ulp-sim-lpav.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP i.MX8ULP LPAV System Integration Module (SIM)
> +
> +maintainers:
> + - Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> +
> +description:
> + The i.MX8ULP LPAV subsystem contains a block control module known as
> + SIM LPAV, which offers functionalities such as clock gating or reset
> + line assertion/de-assertion.
> +
> +properties:
> + compatible:
> + const: fsl,imx8ulp-sim-lpav
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 3
> +
> + clock-names:
> + items:
> + - const: lpav_bus
> + - const: hifi_core
> + - const: hifi_plat
> +
> + '#clock-cells':
> + const: 1
> +
> + '#reset-cells':
> + const: 1
> +
> + mux-controller:
> + $ref: /schemas/mux/reg-mux.yaml#
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - '#clock-cells'
> + - '#reset-cells'
> + - mux-controller
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/imx8ulp-clock.h>
> +
> + clock-controller@2da50000 {

Maybe mfd is better, this is clock, reset and mux controller actually.

Frank Li

> + compatible = "fsl,imx8ulp-sim-lpav";
> + reg = <0x2da50000 0x10000>;
> + clocks = <&cgc2 IMX8ULP_CLK_LPAV_BUS_DIV>,
> + <&cgc2 IMX8ULP_CLK_HIFI_DIVCORE>,
> + <&cgc2 IMX8ULP_CLK_HIFI_DIVPLAT>;
> + clock-names = "lpav_bus", "hifi_core", "hifi_plat";
> + #clock-cells = <1>;
> + #reset-cells = <1>;
> +
> + mux-controller {
> + compatible = "reg-mux";
> + #mux-control-cells = <1>;
> + mux-reg-masks = <0x8 0x00000200>;
> + };
> + };
> diff --git a/include/dt-bindings/clock/imx8ulp-clock.h b/include/dt-bindings/clock/imx8ulp-clock.h
> index 827404fadf5c..c62d84d093a9 100644
> --- a/include/dt-bindings/clock/imx8ulp-clock.h
> +++ b/include/dt-bindings/clock/imx8ulp-clock.h
> @@ -255,4 +255,9 @@
>
> #define IMX8ULP_CLK_PCC5_END 56
>
> +/* LPAV SIM */
> +#define IMX8ULP_CLK_SIM_LPAV_HIFI_CORE 0
> +#define IMX8ULP_CLK_SIM_LPAV_HIFI_PBCLK 1
> +#define IMX8ULP_CLK_SIM_LPAV_HIFI_PLAT 2
> +
> #endif
> diff --git a/include/dt-bindings/reset/fsl,imx8ulp-sim-lpav.h b/include/dt-bindings/reset/fsl,imx8ulp-sim-lpav.h
> new file mode 100644
> index 000000000000..adf95bb26d21
> --- /dev/null
> +++ b/include/dt-bindings/reset/fsl,imx8ulp-sim-lpav.h
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * Copyright 2025 NXP
> + */
> +
> +#ifndef DT_BINDING_RESET_IMX8ULP_SIM_LPAV_H
> +#define DT_BINDING_RESET_IMX8ULP_SIM_LPAV_H
> +
> +#define IMX8ULP_SIM_LPAV_HIFI4_DSP_DBG_RST 0
> +#define IMX8ULP_SIM_LPAV_HIFI4_DSP_RST 1
> +#define IMX8ULP_SIM_LPAV_HIFI4_DSP_STALL 2
> +#define IMX8ULP_SIM_LPAV_DSI_RST_BYTE_N 3
> +#define IMX8ULP_SIM_LPAV_DSI_RST_ESC_N 4
> +#define IMX8ULP_SIM_LPAV_DSI_RST_DPI_N 5
> +
> +#endif /* DT_BINDING_RESET_IMX8ULP_SIM_LPAV_H */
> --
> 2.43.0
>