Re: [PATCH v2 2/8] dt-bindings: clock: document 8ULP's SIM LPAV

Krzysztof Kozlowski
2025-10-20T15:50:42Z

On 20/10/2025 17:22, Frank Li wrote:
> On Sun, Oct 19, 2025 at 12:05:27PM +0200, Krzysztof Kozlowski wrote:
>> On 17/10/2025 16:59, Frank Li wrote:
>>> On Fri, Oct 17, 2025 at 04:20:19AM -0700, Laurentiu Mihalcea wrote:
>>>> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>>>>
>>>> Add documentation for i.MX8ULP's SIM LPAV module.
>>>>
>>>> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>>>> ---
>>>> .../bindings/clock/fsl,imx8ulp-sim-lpav.yaml | 72 +++++++++++++++++++
>>>> include/dt-bindings/clock/imx8ulp-clock.h | 5 ++
>>>> .../dt-bindings/reset/fsl,imx8ulp-sim-lpav.h | 16 +++++
>>>> 3 files changed, 93 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/clock/fsl,imx8ulp-sim-lpav.yaml
>>>> create mode 100644 include/dt-bindings/reset/fsl,imx8ulp-sim-lpav.h
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/clock/fsl,imx8ulp-sim-lpav.yaml b/Documentation/devicetree/bindings/clock/fsl,imx8ulp-sim-lpav.yaml
>>>> new file mode 100644
>>>> index 000000000000..fb3b9028a4c3
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/clock/fsl,imx8ulp-sim-lpav.yaml
>>>> @@ -0,0 +1,72 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: http://devicetree.org/schemas/clock/fsl,imx8ulp-sim-lpav.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: NXP i.MX8ULP LPAV System Integration Module (SIM)
>>>> +
>>>> +maintainers:
>>>> + - Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>>>> +
>>>> +description:
>>>> + The i.MX8ULP LPAV subsystem contains a block control module known as
>>>> + SIM LPAV, which offers functionalities such as clock gating or reset
>>>> + line assertion/de-assertion.
>>>> +
>>>> +properties:
>>>> + compatible:
>>>> + const: fsl,imx8ulp-sim-lpav
>>>> +
>>>> + reg:
>>>> + maxItems: 1
>>>> +
>>>> + clocks:
>>>> + maxItems: 3
>>>> +
>>>> + clock-names:
>>>> + items:
>>>> + - const: lpav_bus
>>>> + - const: hifi_core
>>>> + - const: hifi_plat
>>>
>>> dt prefer use -
>>
>>
>> I don't think we ever expressed such preference. Where did you find it?
>
> It should come from review message when submit binding-doc patch. but I
> can't find it now. But at least, compatible string and node-name use "-".
>
> It'd better to add to writing-bindings.rst. It is hard to search whole
> linux-devicetree mail list or brain may cheat me. It is good to keep
> everything consistent.

Yeah, but please don't make up rules and suggest them if you cannot
justify them. I don't recall such rule and I don't have it in my notes,
so that's why I asked.

Best regards,
Krzysztof