Re: [PATCH v2 4/8] reset: imx8mp-audiomix: Drop unneeded macros

Frank Li
2025-10-17T14:44:44Z

On Fri, Oct 17, 2025 at 04:20:21AM -0700, Laurentiu Mihalcea wrote:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>
> The macros defining the mask values for the EARC, EARC PHY resets,
> and the DSP RUN_STALL signal can be dropped as they are not and will
> not be used anywhere else except to set the value of the "mask" field
> from "struct imx8mp_reset_map". In this particular case, based on the
> name of the "mask" field, you can already deduce what these values are
> for, which is why defining macros for them doesn't offer any new
> information, nor does it help with the code readability.
>
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> ---

Register define still prefer use macro.

So far const string, hexvalue prefer use value if only use once.

Frank

> drivers/reset/reset-imx8mp-audiomix.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-imx8mp-audiomix.c
> index eceb37ff5dc5..e9643365a62c 100644
> --- a/drivers/reset/reset-imx8mp-audiomix.c
> +++ b/drivers/reset/reset-imx8mp-audiomix.c
> @@ -14,11 +14,7 @@
> #include <linux/reset-controller.h>
>
> #define IMX8MP_AUDIOMIX_EARC_RESET_OFFSET 0x200
> -#define IMX8MP_AUDIOMIX_EARC_RESET_MASK BIT(0)
> -#define IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK BIT(1)
> -
> #define IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET 0x108
> -#define IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK BIT(5)
>
> struct imx8mp_reset_map {
> unsigned int offset;
> @@ -29,17 +25,17 @@ struct imx8mp_reset_map {
> static const struct imx8mp_reset_map reset_map[] = {
> [IMX8MP_AUDIOMIX_EARC_RESET] = {
> .offset = IMX8MP_AUDIOMIX_EARC_RESET_OFFSET,
> - .mask = IMX8MP_AUDIOMIX_EARC_RESET_MASK,
> + .mask = BIT(0),
> .active_low = true,
> },
> [IMX8MP_AUDIOMIX_EARC_PHY_RESET] = {
> .offset = IMX8MP_AUDIOMIX_EARC_RESET_OFFSET,
> - .mask = IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK,
> + .mask = BIT(1),
> .active_low = true,
> },
> [IMX8MP_AUDIOMIX_DSP_RUNSTALL] = {
> .offset = IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET,
> - .mask = IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK,
> + .mask = BIT(5),
> .active_low = false,
> },
> };
> --
> 2.43.0
>