The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Armin Wolf <W_Armin@gmx.de>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: hansg@kernel.org, ilpo.jarvinen@linux.intel.com,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/nls: Fix inconsistency between utf8_to_utf32() and utf32_to_utf8()
Date: Wed, 26 Nov 2025 23:47:22 +0100	[thread overview]
Message-ID: <d7eb63da-72c1-4716-b26d-e64b42c63064@gmx.de> (raw)
In-Reply-To: <aSdtxhgmFsjqERvl@smile.fi.intel.com>

Am 26.11.25 um 22:14 schrieb Andy Shevchenko:

> On Wed, Nov 26, 2025 at 11:13:50PM +0200, Andy Shevchenko wrote:
>> On Wed, Nov 26, 2025 at 09:43:55PM +0100, Armin Wolf wrote:
>>> After commit 25524b619029 ("fs/nls: Fix utf16 to utf8 conversion"),
>>> the return values of utf8_to_utf32() and utf32_to_utf8() are
>>> inconsistent when encountering an error: utf8_to_utf32() returns -1,
>>> while utf32_to_utf8() returns errno codes. Fix this inconsistency
>>> by modifying utf8_to_utf32() to return errno codes as well.
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>>
>> Thanks!
> Note, you might need a Fixes tag as the original one was marked as Fixes.
>
Alright, i will add it in the next patch revision.

Thanks,
Armin Wolf


      reply	other threads:[~2025-11-26 22:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-26 20:43 [PATCH] fs/nls: Fix inconsistency between utf8_to_utf32() and utf32_to_utf8() Armin Wolf
2025-11-26 21:13 ` Andy Shevchenko
2025-11-26 21:14   ` Andy Shevchenko
2025-11-26 22:47     ` Armin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7eb63da-72c1-4716-b26d-e64b42c63064@gmx.de \
    --to=w_armin@gmx.de \
    --cc=andriy.shevchenko@intel.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox