From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755654AbdEEVCl (ORCPT ); Fri, 5 May 2017 17:02:41 -0400 Received: from mout.web.de ([212.227.15.4]:62904 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751651AbdEEVCj (ORCPT ); Fri, 5 May 2017 17:02:39 -0400 Subject: [PATCH 2/7] kernel-trace: Replace five seq_puts() calls by seq_putc() From: SF Markus Elfring To: Ingo Molnar , Steven Rostedt Cc: LKML , kernel-janitors@vger.kernel.org References: <3419381c-6a8f-f0f6-86e8-3ee7f9af0076@users.sourceforge.net> Message-ID: Date: Fri, 5 May 2017 23:02:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <3419381c-6a8f-f0f6-86e8-3ee7f9af0076@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:L5OzIJCDZtLi0IOcrWYnFWWiazZjWGWU6JOmpOwH9TbbB26FTz6 lVTBoFJyCM0BxTPyC0ugbewtKP7/QkpTWo0pMqZrIf+Kj9D5wNIQOKPRIITPjo9DqnovtbG IAfqdm1OBkBQBY4dToiS5eAKLqJRefuwsDmxCzWZjEK1APbai48rarneeurMaGzIxX6wzSX eIVD/qVE8QZj96LwMQ/Vg== X-UI-Out-Filterresults: notjunk:1;V01:K0:6OtG2YXpdb0=:DvHzN/+pq5IkZ4sSxbBn+R Ms8GuIslpx7oLDwyP6QpaPq+YOmU0Ko3j+ksiVd9o8dak3FHZeHf3Ke9r0mc3Uq/au+ScIDox IsS3YJoRACUm9mzK69il/ZHSqVKc/8uQXQ8wFhtsZ9aWq+spdG+j2sYs/ra4rnVzU6T3qKyxc CQu7q8k6zD9ggcQE8TpWav9IQLn9xOJg/YoQk0/2OaqsKsY34XCBygPGu+si//gmpks0srWGN +Wd7rwx2lYPonsXTBKByaFFYdwFrdd6zSH4eK1qU4f6Nyj1AOOZ1D120mX7wBHLMjhBcpHyDK OmMMQeE4l7PFG6k+wfIQY8DQAKMW+rJPMyShwpm6fwZITAyQNQ7/aQBHY+Kayx2K24JvsOwE9 fPNxzdQSFuXKMaSWymXgdCvaLFCQTXQusTAbSrgE+NGDiZQinllQdhDpaqcl9ZN6q8wei3NUO jr5ym1c9ydJDrJScRXz/je9LgHk9QmWwui0W2EgRFZslP9XzVZtt2ifeVd8cnr6qxXHJuTs03 xKpKRRnqdwlntw7JHXS1MUoY34O+s4TB8/pxiZSeyHGed2H7hXHxf8/bYrxPOzeQu6ENZeQPM x1nR6JMFGN5SCbLFlOfpUljphqEJEtPROcw++OHhEdo+kRTjVhjwlf9IuxMu5+X0i+jV4xjWz jpn92xlTKn/aW+jhB8qibrPQB+CeWKLaIT1NM+f+FtqxVjnMXkrpUsLu0s6zhb4AAgip8A6Sy g+FnIy5N9X2e4njSA2Lq72fH/Ez89XSONL23cj234+KoKajaWupWcdhdoCVtzJAI4/FZoVLif zS09JzE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 5 May 2017 19:45:12 +0200 Five single characters should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- kernel/trace/trace_events_hist.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c index 94999934ffd5..df566e21344d 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -1013,7 +1013,7 @@ hist_trigger_entry_print(struct seq_file *m, } if (!multiline) - seq_puts(m, " "); + seq_putc(m, ' '); seq_printf(m, "} hitcount: %10llu", tracing_map_read_sum(elt, HITCOUNT_IDX)); @@ -1030,7 +1030,7 @@ hist_trigger_entry_print(struct seq_file *m, } } - seq_puts(m, "\n"); + seq_putc(m, '\n'); } static int print_entries(struct seq_file *m, @@ -1168,7 +1168,7 @@ static int event_hist_trigger_print(struct seq_file *m, key_field = hist_data->fields[i]; if (i > hist_data->n_vals) - seq_puts(m, ","); + seq_putc(m, ','); if (key_field->flags & HIST_FIELD_FL_STACKTRACE) seq_puts(m, "stacktrace"); @@ -1182,7 +1182,7 @@ static int event_hist_trigger_print(struct seq_file *m, if (i == HITCOUNT_IDX) seq_puts(m, "hitcount"); else { - seq_puts(m, ","); + seq_putc(m, ','); hist_field_print(m, hist_data->fields[i]); } } @@ -1195,7 +1195,7 @@ static int event_hist_trigger_print(struct seq_file *m, sort_key = &hist_data->sort_keys[i]; if (i > 0) - seq_puts(m, ","); + seq_putc(m, ','); if (sort_key->field_idx == HITCOUNT_IDX) seq_puts(m, "hitcount"); -- 2.12.2