Re: [PATCH net-next v2 0/2] mptcp: add last time fields in mptcp_info

Jakub Kicinski
2024-04-10T18:34:53Z

On Wed, 10 Apr 2024 11:48:23 +0200 Matthieu Baerts (NGI0) wrote:
> These patches from Geliang add support for the "last time" field in
> MPTCP Info, and verify that the counters look valid.
>
> Patch 1 adds these counters: last_data_sent, last_data_recv and
> last_ack_recv. They are available in the MPTCP Info, so exposed via
> getsockopt(MPTCP_INFO) and the Netlink Diag interface.
>
> Patch 2 adds a test in diag.sh MPTCP selftest, to check that the
> counters have moved by at least 250ms, after having waited twice that
> time.

Hi Mat, is this causing skips in selftests by any chance?

# 07 ....chk last_data_sent [SKIP] Feature probably not supported
# 08 ....chk last_data_recv [SKIP] Feature probably not supported
# 09 ....chk last_ack_recv [SKIP] Feature probably not supported

I'll "hide it" from patchwork for now..
--
pw-bot: defer