From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FD01326951 for ; Tue, 5 May 2026 22:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778021005; cv=fail; b=a79UKOMtYchQ/ryatnNe8bgsb9vGK8XduqD0rN3SukEHmE5bTQImHjprqPTy5dsq19gunQY3uIjg3WjrCtWBzRZc4J6UZ7/wBq1orH698wkZ5JUX9I+zn1pmrwuI4ow6S3QBLGRJt6/xt1sj/MbRSvMkDYi896MkXPogZDol+wE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778021005; c=relaxed/simple; bh=sZYQomD8bx01WSQ+7rP9T5bA18DsZkQbAcYuK5SRfdo=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=UZ4JlrTYBMVXyN5N49n5ei8fFcUQKX0bfft8xFnYEc2JUzNywdRyAJbbnwIiyrTSSYiMHRdDtmrHriF+k2KAURrNn1KoQHsgLNCndGo/FKAqBJ9PsVKPc5wntPL3PS3ri3XEmDFreWtuOX/KtVk7ZOpBCsP3M20WLCfQ7byIpy4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=lSBy4wJP; arc=fail smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="lSBy4wJP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778021003; x=1809557003; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=sZYQomD8bx01WSQ+7rP9T5bA18DsZkQbAcYuK5SRfdo=; b=lSBy4wJPICRNSmWpaZTzGmdg4UF8LYd3YlLiXR/N8hac6r0SfDhWaL0W XkQCqMy9TzIMfrBAIS7EbNhbl5aNiOdHha7tHtUPuUlYkT/cv2eSClFjc h0olDpxR7N/bEfnO4ufFYJ3OLEYrXNE4PxVYbPVWMHUd6VQ/Y09xlSLTs zTjKt1+Tuj/JnOeEWmrljczbbtLJKF7MzbeXdsHSkRHs6UBpV+8ah8q+g IU18Gk7FATVtTjt1hwzqd/J5H0ajtYtyOHd1iZf5ezdY+/Hiz/5D7Qua8 6KHbs0yyeCVVijQFGIKNouBL2KZ9C8EL34cZFkzc0lgnuDZk2sKbQS+HA A==; X-CSE-ConnectionGUID: mnSMVJLlSviE7+E7mkS0SQ== X-CSE-MsgGUID: 1Xq7BvGuTCe8D3lPg3epww== X-IronPort-AV: E=McAfee;i="6800,10657,11777"; a="89212595" X-IronPort-AV: E=Sophos;i="6.23,218,1770624000"; d="scan'208";a="89212595" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2026 15:43:23 -0700 X-CSE-ConnectionGUID: d5TH2aUaRI2nRKT2wmhbbQ== X-CSE-MsgGUID: cK2N7KBbS6icZAgi3+zbBg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,218,1770624000"; d="scan'208";a="231556094" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by fmviesa010.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2026 15:43:22 -0700 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 5 May 2026 15:43:21 -0700 Received: from ORSEDG902.ED.cps.intel.com (10.7.248.12) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 5 May 2026 15:43:21 -0700 Received: from CH4PR04CU002.outbound.protection.outlook.com (40.107.201.10) by edgegateway.intel.com (134.134.137.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 5 May 2026 15:43:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=e7Y8K9dioYZUuuVB6tfyiuq2MLr4ekOYjCCKw9y8BXn/foUXZ/3GlImaAO9FCQpIwh63K/SAqVN4qbQRtJSGFwfyw4qVuYnaFmIOdIug7B7tSdpzuzN98J7eoTgqJSqmqyam7mfrFP2TJr/Z6fu1NqNkJ+npqON2LE4JVJ5TGVwxmbOebIjWN+cSxq91GjHi7YVamhKDhamYeMEG1tvAKNqzqdydq3A9+d8fT1IrpTjTAm+0MHxPipvPtbac+ALXDnOc1RK3OpzayI9Ux5zilkJ5I+sd5p8Sq7aj6VHoQVsbO9r4dtST2V4c+KT6qrlzg+V6kATdtgKXOquTzmXV6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m1fI1qKkophmQ+nDH0fdyLK+IgLEUQjdL39jGMgnJCg=; b=TfvCMzddfrjx0EyNySPCv/miTSTTutMpWE5gsk9coCxAkZXoUNWYhvcPWPGftzZ0LJA2L7mrJqNwIuEL3LiGcdlM4JCmFfBMhdTKL/c4kQ0eKxHp5RIS8kWcJpNX8KLqE90TEqK5efxuVcrP3cxif54SKfmuCmfJTKPpSvcSHNH3PLVFxaVOLkk+AmMpIROyzsGQwq3Uj7mMH39zB9eYh3llNA033bE0H6Gz4KWQEUtqDYitce+xYVDTK9VuWRuNs6f53nkQPoBEhOXabBs/eIP/lO31xsQTS/yT+T7H58qpBYRnCtizBu/r3XZ1+9liQa2ubPjcWCKPtQHQPWlfaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ2PR11MB7573.namprd11.prod.outlook.com (2603:10b6:a03:4d2::10) by IA1PR11MB7941.namprd11.prod.outlook.com (2603:10b6:208:3ff::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.25; Tue, 5 May 2026 22:43:18 +0000 Received: from SJ2PR11MB7573.namprd11.prod.outlook.com ([fe80::bfe:4ce1:556:4a9d]) by SJ2PR11MB7573.namprd11.prod.outlook.com ([fe80::bfe:4ce1:556:4a9d%5]) with mapi id 15.20.9870.023; Tue, 5 May 2026 22:43:18 +0000 Message-ID: Date: Tue, 5 May 2026 15:43:15 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/7] fs/resctrl: Tidy up the error path in resctrl_mkdir_event_configs() To: Ben Horgan , CC: , , , , , , , , , , , References: <20260505155741.3591201-1-ben.horgan@arm.com> <20260505155741.3591201-2-ben.horgan@arm.com> Content-Language: en-US From: Reinette Chatre In-Reply-To: <20260505155741.3591201-2-ben.horgan@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR04CA0364.namprd04.prod.outlook.com (2603:10b6:303:81::9) To SJ2PR11MB7573.namprd11.prod.outlook.com (2603:10b6:a03:4d2::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR11MB7573:EE_|IA1PR11MB7941:EE_ X-MS-Office365-Filtering-Correlation-Id: c2c3b3cd-5ab5-4aa7-8f25-08deaaf7b369 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|7416014|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: 8pFlgLiKvZJYW6U+taAdgrDt7ObJqtG/vqsJAFfmwvDAubMoT0i4NznQKnwwh8whGVDmSX+bCf9vMGYdnP+t3Y6Ewprv1NVDcjfk0yGnhzUeJ0mImSfGmtgHrST30hI7UGIoTsFCbj5j+uaeld86im/lOCJF/njMMDgmZH/KJK7vhzSfFGcHphki30XzWgveIJdTwIfY7RyPA+n+hgbt2Pykx5KlOD06vUHHbxsLk3+rL0ZL4TykQR9RoqolWLtDo+aT9Bp66UB2IFs2d1QZarXLBX9Oqtsj5LGnbFf7muMEeO2Dq2jcKYjHkF9Ro8CtvktEw+Bxmk6qcdiQ9/87r2qI1BBTn7iQayRSP+ZDBU245FXx20wHaSxrRqCmLmyB/Tr/29eFSOYQjcWwmK75zlcHS2gqWJpOfEJqkdomKUbkwSGs4svYrC24FbOEr9KnxbRgLgsG7xPRfDqNcMVY7Q2xaj0ElazfcpByRq8fNMyMi/3fS5+X6pb/2ZFfs4Lo3/+ENG6Vs4K8rVOwnGJCVbs92d9/FRl6ifzomEDfAMDUVNRe7canpbQZ5Bg4A5GPu6RpUmLyCO+irgmFrcKa8CxMMSNXdaGDqGi/jev3cS2WvWaMmI3naVYMTg2DnZPh6II0QUE/HIoOe/7J7nuwMSHuEHTeeFKPtUSnksgbs3TGi86dCip8F0pXI0HsvoMF X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB7573.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(7416014)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d1M0OFl2em8zT29rdHpiSVMwMlJPTjh3RmdoSlp0S2tVWFhZUC9JTGtwRllm?= =?utf-8?B?cnRyRXBnYkplck1XM1hjYnlpK1dkMTlVMUZEOGpMQ2l3YUVZdjBMaW5GL3Rh?= =?utf-8?B?Z05tU2g2dUtZdnhKYXdZSHZIV2xUZnh2dmpKaTIveDNkcGhuck9FWFBFL0R4?= =?utf-8?B?QkVlUHhaVE5Zb1Eza09TbXFzWC8ydWVEaGtvc3M1NGtjaXY3NnA1NTUwQzhh?= =?utf-8?B?bmdxNld1NFArdkNDSE5iR3RYRFdxcGg1QlFFWVJMY1Y5QlVVVVJhNU9oL0tW?= =?utf-8?B?WUMyY1ZkenA5TVZtMFRIaXhFVGFzS2ZVdXNycTcxTTFWYzNNTmNPOGF5Nm03?= =?utf-8?B?bmJPRktkY09hUHlwR3Y2STNJMHJNdGFTRDhBNzJlTDVqbTNhc0MxT0plUlMx?= =?utf-8?B?TmZUMk5hSDZBR3NJWmhrclZyc3dQelVYQVlOVDd3MXBDaHpEbmlYZmh4Si94?= =?utf-8?B?Y01LcjAyRlFZTkttNFJGKzFPcmFWSHJ6KzF2V1lqWmZaQmh5Z3RRMFliM2xZ?= =?utf-8?B?SGhHUktmeUNibW9IRlBSVW9WcmZ4OGl4bytaS2ZPOXdQUElrTmdFaXc0QkdG?= =?utf-8?B?V1JzK09MditvdXRvejhqNjMzU0ltOUR3eHJPU0dsSDYvWHBRSnRST3J2Z3Qz?= =?utf-8?B?bkxldE1iY0d3cnRYa1VXQUt0YmtUSHlaZzJMMVZuVWF0bFl4TW5yOGM0K25H?= =?utf-8?B?Y2FJb2lSZWMyQzhoZXpjb1lkNi9iZzJKZUZTdlRZNjBPKzJma214ZGlYb0s0?= =?utf-8?B?Y0VKZEZDQU1jS1A3ZUxnSyt6T01sT3E0d2xsUll6UjVmMWY4QzdVdFhOb3dF?= =?utf-8?B?U24rVy9ZRzBSUmpUYkMxUHdOYUhYYXduTERvcHE0R3lZazkzL2tHdGdQTDZD?= =?utf-8?B?QmNDNENhdTY0ZVYycmpocmRBYy9NbXBuMnhpWmxad3lscCtVMWRialFPbi9E?= =?utf-8?B?M0JENlBvRzhFQ21UMTZuYU1CYVhRWmhQZm9OMlNZVVBvcE9EcFpmRW85VnU4?= =?utf-8?B?QW1tQldrczBNc0NheW9jMWNBMExWYS82NmNSNWZUTGZTcEZIM2tqdHRJRitx?= =?utf-8?B?N2V6N3dtRFdrUWU5L0ptN0ZsQ0hkNGJWelhLV2dldTJZUXVjSWQ4NXJLbW9w?= =?utf-8?B?TUZpUU1ocTVxQjE3Smc2dU5XWVRSMVdKQ2lrL004dy9TcHRKOWJIbW83N01T?= =?utf-8?B?NHVmT0R2ZlpNUEFCdWJLNE8rRnVZb0VNV0NnaTg0VUx2Yy9wYzhtWkNJNy9j?= =?utf-8?B?WmEyd29obUlxVmZ3bFd5Wm4yc3lyZzE1VldteWx0WWR6TnpJaGsxa3N0NFkx?= =?utf-8?B?YWpYbkVQTkNvTUE4MUpnLzFMTy9wSFk0dCtleTlueDVhb245b0tTcTFPU2Zw?= =?utf-8?B?MjJkZkR5RzBYOWFOYk9acWFvVUJvcGp6WDhCMElxTU5MQU1pNXkyKy9RRzAv?= =?utf-8?B?c2ZGYWVQZTl3SDN5MWE4ekY5SlFQOG5ZOTlOY09IWHpibHErcFF1aTg4VnU4?= =?utf-8?B?QW9kWkd5VFd0anRqREhqeSs1aGVFaDg0cTZDUzMrWCtiUk1Cck10SzNrK0kv?= =?utf-8?B?b0E3L3d3MkNHL25ibEYyVGFHTkViWDJKVy8zdWd6ZjVlNUcxc0RmeDdudTBU?= =?utf-8?B?WW0rVVZiWS9JenYydW1zWDE2WXJ3UVZENkdxRVd3MGJ6QS91Tm9yUldYNk5y?= =?utf-8?B?TWxMNVdvYkQ1NzAxYml3S2dJTSt5TE02RVVrRTc0amhyVklwSU5lTEVTZ1ZT?= =?utf-8?B?UGdtUlYyaGxKaWdaMGs5bk9RZXhiS1hhWTBnRzV4a2dGZVAxbHliR3hUb1RC?= =?utf-8?B?NlU3TWlNUW4rbGxWRGltdHRSVmhFWFdCaisvSzBkNWdtZXF4Nk4zVWpHTFgr?= =?utf-8?B?aC9FQnpjZ3ZUQWpPOVJncE1Rb0lHSjUyUm1WVDk2THE5RG5zYlJDOEZUTENp?= =?utf-8?B?eEtmOTlJbUExVkR1YS9UNC9iM0J2bjFOdm00Mm1rQitaekRwelhVNm9TNWZI?= =?utf-8?B?cEZINUxYV3dsUGtyZUNmcTJuUGk1TGlSdWtIT2F2aGRkV2owM3hOYWdLV3c3?= =?utf-8?B?U1p5YWMrb0draHF1bEJkUSt3dks1UmpMZktPUTJvQlZHS1J2bGt0MkI0U29u?= =?utf-8?B?Z2VRWEtyNzl5cmh2MzdPNFdmUGNRUUswUEt1Tnd4dmdxVWIvc25WR0JORVFw?= =?utf-8?B?UndNck5hODJRcml0aHFsMlVhYnJwNEVCaXB4OHVjWVE0eXphSmZKQ1NVc2tw?= =?utf-8?B?eEY1ajVWVm8vM1ZjcmFjQ1pvREJIaURzOTFVSFZENWNlL0o5MTBTclNLOUlh?= =?utf-8?B?LzNKZnNYdy9rNHVYU0VpZTBFeC9LYVdnaXNaY1NDRnBtS3YwYnJjamFETEVL?= =?utf-8?Q?Go5l1y3oj3UHAJV8=3D?= X-Exchange-RoutingPolicyChecked: nD0BwOS6tgVYjlKYtpJppVHrQ6HuIL38htI3rRIaSaGhSa4aB4eFV5eYwKzWwi/Ye/p+ncbwIJYd7+p+6eus8gi6LKwVU7BnldwjJBrKTQ+GAUwwh8Gkz0UKUsKtD63q+GrNF7c51w10TNXjmNqIqAZ5lNjagd2YcYnWwqboURaajGRJdWMX1rmvs3aaEa2vSoh2T82B71I9BapuhKt3QY8LXwwf+K9PLBiX0ZbV0Z4aCAW5hZk7/AIUsOe6SmudK1sZcqv9P8Tw+xNkQ7+TkthTSkASIOLxNr0vFnZjD5zwjuapPAIU0k+Igt0smv6kMmmMpdCG7vISDpTfDXDMlg== X-MS-Exchange-CrossTenant-Network-Message-Id: c2c3b3cd-5ab5-4aa7-8f25-08deaaf7b369 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2026 22:43:17.9499 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jlEvSgdXyo9cdHFTAM14+c/P8LMOl0QrpWzNjd5xukXp0AT8qotDuajPrDsWounnhy4vuUHCt72Xzh19oLRUkkOJqJOVF00hkCotORCmFMQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7941 X-OriginatorOrg: intel.com Hi Ben, On 5/5/26 8:57 AM, Ben Horgan wrote: > The error path in resctrl_mkdir_event_configs() is unnecessarily > complicated. Simplify it to just return directly on error. > > Signed-off-by: Ben Horgan > Reviewed-by: Reinette Chatre > An unfortunate typo here. Without the "---" separator the list of changes below will stay with the changelog. I'm actually not sure what would be the best course of action here. Resubmitting whole series to address this seems like a lot but it may also be best to avoid any confusion. > Changes since v5: > Correct order of the tags > --- Reinette