From: Michael Walle <michael@walle.cc>
To: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Cc: greg.malysa@timesys.com, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com,
pratyush@kernel.org, richard@nod.at, tudor.ambarus@microchip.com,
vigneshr@ti.com
Subject: Re: [PATCH 0/2] These are the required patches I found while adding
Date: Thu, 24 Nov 2022 13:42:30 +0100 [thread overview]
Message-ID: <d812e89c0c8d00f0043463dda241ece5@walle.cc> (raw)
In-Reply-To: <20221124114713.132514-1-nathan.morrison@timesys.com>
Hi,
Am 2022-11-24 12:47, schrieb Nathan Barrett-Morrison:
> Ah yes, I just realized we're effectively using the device in 1S-1S-8S
> extended SPI mode, so the 0xC7 setting is probably not required. We
> were never able to get DTR mode working on the IS25LX256. I can fix
> this patch up so it's more explicit about what's going on here.
>
> The 8S-8S-8S support in core.c is still going to be used for another
> OSPI device I'm porting over from an older kernel.
Can you link a datasheet? The problem with 8s8s8s is that it needs
mode switching which can be footgun. And IMHO it doesn't provide
significant performance improvements over 1s8s8s.
> Would you like me to separate these patches, fix up the ISSI once, and
> resubmit?
Yes please. Also, I've seen that you use flags in the flash_info table.
Please have a look if that information can be deduced from the SFDP.
E.g.
does a flash describe if it supports 1s1s8s.
-michael
prev parent reply other threads:[~2022-11-24 12:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 21:13 [PATCH 0/2] These are the required patches I found while adding Nathan Barrett-Morrison
2022-11-23 21:13 ` [PATCH 1/2] mtd: spi-nore: core: Add in framework for 8S-8S-8S Octal STR mode Nathan Barrett-Morrison
2022-11-25 11:12 ` kernel test robot
2022-11-23 21:13 ` [PATCH 2/2] mtd: spi-nor: issi: Add in support for IS25LX256 chip, operating in " Nathan Barrett-Morrison
2022-11-23 21:24 ` [PATCH 0/2] These are the required patches I found while adding Nathan Barrett-Morrison
2022-11-25 15:55 ` [PATCH 2/2] mtd: spi-nor: issi: Add in support for IS25LX256 chip, operating in Octal STR mode kernel test robot
2022-11-24 8:07 ` [PATCH 0/2] These are the required patches I found while adding Michael Walle
2022-11-24 11:47 ` Nathan Barrett-Morrison
2022-11-24 12:42 ` Michael Walle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d812e89c0c8d00f0043463dda241ece5@walle.cc \
--to=michael@walle.cc \
--cc=greg.malysa@timesys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=nathan.morrison@timesys.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox