From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753588AbdK0Vsq (ORCPT <rfc822;w@1wt.eu>);
        Mon, 27 Nov 2017 16:48:46 -0500
Received: from mout.web.de ([212.227.15.4]:50220 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752422AbdK0Vso (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Nov 2017 16:48:44 -0500
Subject: Re: omapfb/dss: Delete an error message for a failed memory
 allocation in three functions
To: Joe Perches <joe@perches.com>, linux-omap@vger.kernel.org,
        linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: "Andrew F. Davis" <afd@ti.com>,
        Arvind Yadav <arvind.yadav.cs@gmail.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <c48a01db-c477-3bd3-5cb4-548e47810ccb@users.sourceforge.net>
 <d29a0bae-7b6f-b8f6-6809-5a097cd5a26a@ti.com>
 <1511809633.32426.70.camel@perches.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <d82fbab2-865f-3051-f487-d310ee819cf3@users.sourceforge.net>
Date: Mon, 27 Nov 2017 22:48:26 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <1511809633.32426.70.camel@perches.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:3iKg6FOY8wK7cDdkwPgXOVSR5d96HhlAetmdA0o9G45vK3+01di
 6e3Bg8ZFBnVCzrJZbleuCEICEgHbMsOeFo3R+LQbzcQpnONRMjRMayDuBIUBvbsg0QQLQ9G
 uo/Xk38VrTq02OcTxY6PwSx2bdwnMh7IFw/6v4sKZyW+qD1xgtvUBiaHP/yffjml5RfRFiK
 yk1G/5jT8WJ9ibt5asBJg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:AKCMFLQVW0A=:r2wPuKIsqBQDRekvjvf2T6
 sknMYQRxtHj2CRAARI3rE9qIyX6kbwqV+veL1+3KrCDRwwt6+WlphQ/AgNTpAe0NxZ+4vxPb1
 eiOXSuXgBh19iHrQdDNUJZmqcoCFmc9dle9u3vE7T4BVXKh4z/57XNZqurmFtChib5Hxyx+Wq
 97+6Du+n2nUNWfrmwPxVpQ6DGSrQ/iaYUEtcnOlOd6f47RNcr31CsLYV+c1vxHioFZ+BIJKQn
 nPzo/7MKbD1wkYmp2SIT9SffGmazE7RsPK5v+/Q8YGkE6vYYqA2iq1ygdhZ+Qx8Jq8YH8sl0u
 M76ULS4KohwiMpncCgKihabVIhn88boo+s8+KQeTmXHcGFIJf0p3SsGkJ348R4gt0MxA1QoOE
 JkJ9R8/CjFfxFR/Rim6r3zBCEgXeVLf2r57zeUB/wL7+hSudzDoWqWyfNNv7V+qJUE+cYBkBS
 0i3TOqvykIbH2y1fZHb8o8UZlZmQ3oVoIgImwQbHIqcJekHC5qe/3MbdpQIMpHFXNTi4i8PAo
 sfPk0VdTxMiOW2XhfVjp9HfAWGchEE8PYGADWtnWTkIAI5j2HC5uqHGe7VM1qDXr8cjIxDiqm
 VzM7CHe0XMg8JjJfL4MkCq7WW9nYBS5d8sC0XOEdkK3CqqMwvopUZ1wv9INVlvm6YDvky4XWQ
 +4Sb4QBtfEfHdnmRlE32vwZeJpC/Um3NqBi8DcUU7nivnOIzHfL33MMPDc6Xe90ryOlzbQ0/T
 A1w8Od7lzIzcqnsyMaQHnssMTYjkVoI90ZacvSKjfKSmyfUe+Wdt5lTdw0VcAzDpTacLDqx2Y
 OqdlQemyAAd2ppu1O9z/s6525gAO/ZO9Aqyoup/+kACE9R2JaU=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> There is the generic stack dump on OOM so the module/line
> is already known.

Can such an implementation detail become better documented
than in C source code?


> The existence of these messages increases code size which
> also make the OOM condition slightly more likely.

Interesting view …


> Markus' commit messages are always really poor descriptions
> of why these removals are somewhat useful and the commit
> could/should/might be applied.

I agree that they could be improved for this transformation
pattern if other information sources would become clearer
for corresponding references.
It seems that I got no responses so far for clarification requests
according to the documentation in a direction I hoped for.

Regards,
Markus