Re: [PATCH 1/2] dt-bindings: display: panel: Add BOE TD4320

[barnabas.czeman@mainlining.org]

On 2025-04-28 11:22, Krzysztof Kozlowski wrote:
> On Sun, Apr 27, 2025 at 11:11:11AM GMT, Barnabás Czémán wrote:
>> Document BOE TD4320 6.3" 2340x1080 panel
>> found in Xiaomi Redmi Note 7 smartphone.
>> 
>> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
>> ---
>>  .../bindings/display/panel/boe,td4320.yaml         | 55 
>> ++++++++++++++++++++++
>>  1 file changed, 55 insertions(+)
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/display/panel/boe,td4320.yaml 
>> b/Documentation/devicetree/bindings/display/panel/boe,td4320.yaml
>> new file mode 100644
>> index 
>> 0000000000000000000000000000000000000000..65da1c392cafbb7cd3ce32e347fba1b9244c1ad8
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/panel/boe,td4320.yaml
>> @@ -0,0 +1,55 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/panel/boe,td4320.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: BOE TD4320 MIPI-DSI panels
>> +
>> +maintainers:
>> +  - Barnabas Czeman <barnabas.czeman@mainlining.org>
>> +
>> +description:
>> +  BOE TD4320 6.3" 1080x2340 panel found in Xiaomi Redmi Note 7 
>> smartphone.
>> +
>> +allOf:
>> +  - $ref: panel-common.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    items:
>> +      - const: boe,td4320
>> +
>> +  reg:
>> +    maxItems: 1
> 
> No supplies?
> 
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - reset-gpios
> 
> No supplies? This looks really incomplete.
It works without supplies because BL is enabling them and there is no 
qpnp-lcdb driver yet.
I do not see worth to add them at them moment but I can if you want.
> 
> 
> Best regards,
> Krzysztof