From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2867C433E0 for ; Tue, 21 Jul 2020 23:11:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A546820771 for ; Tue, 21 Jul 2020 23:11:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731329AbgGUXLj (ORCPT ); Tue, 21 Jul 2020 19:11:39 -0400 Received: from mga17.intel.com ([192.55.52.151]:59890 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726148AbgGUXLi (ORCPT ); Tue, 21 Jul 2020 19:11:38 -0400 IronPort-SDR: e4DCA/0mtI3ZetSLuEHHreYeZVvBpvgfjguM4T44GKw7KRN2rWAgCIxibpXTc28Y6qCgD+svEN /7wm60dLVA6A== X-IronPort-AV: E=McAfee;i="6000,8403,9689"; a="130326368" X-IronPort-AV: E=Sophos;i="5.75,380,1589266800"; d="scan'208";a="130326368" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2020 16:11:37 -0700 IronPort-SDR: UkdvjQPsfhGCtfdh2igIhtlU+U1RScxgkXHZLfUkKlV9tZJ34r5zXMkIfBCKgKaTZzegujEIOO FFJGEm/aNdNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,380,1589266800"; d="scan'208";a="462248054" Received: from allen-box.sh.intel.com (HELO [10.239.159.139]) ([10.239.159.139]) by orsmga005.jf.intel.com with ESMTP; 21 Jul 2020 16:11:34 -0700 Cc: baolu.lu@linux.intel.com, Ashok Raj , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Koba Ko , "iommu@lists.linux-foundation.org" Subject: Re: [PATCH 1/1] iommu/vt-d: Skip TE disabling on quirky gfx dedicated iommu To: "Limonciello, Mario" , Joerg Roedel References: <20200721001713.24282-1-baolu.lu@linux.intel.com> From: Lu Baolu Message-ID: Date: Wed, 22 Jul 2020 07:06:52 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Limonciello, On 7/21/20 10:44 PM, Limonciello, Mario wrote: >> -----Original Message----- >> From: iommu On Behalf Of Lu >> Baolu >> Sent: Monday, July 20, 2020 7:17 PM >> To: Joerg Roedel >> Cc: Ashok Raj;linux-kernel@vger.kernel.org;stable@vger.kernel.org; Koba >> Ko;iommu@lists.linux-foundation.org >> Subject: [PATCH 1/1] iommu/vt-d: Skip TE disabling on quirky gfx dedicated >> iommu >> >> The VT-d spec requires (10.4.4 Global Command Register, TE field) that: >> >> Hardware implementations supporting DMA draining must drain any in-flight >> DMA read/write requests queued within the Root-Complex before completing >> the translation enable command and reflecting the status of the command >> through the TES field in the Global Status register. >> >> Unfortunately, some integrated graphic devices fail to do so after some >> kind of power state transition. As the result, the system might stuck in >> iommu_disable_translation(), waiting for the completion of TE transition. >> >> This provides a quirk list for those devices and skips TE disabling if >> the qurik hits. >> >> Fixes:https://bugzilla.kernel.org/show_bug.cgi?id=208363 > That one is for TGL. > > I think you also want to add this one for ICL: > Fixes:https://bugzilla.kernel.org/show_bug.cgi?id=206571 > Do you mean someone have tested that this patch also fixes the problem described in 206571? Best regards, baolu