From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D11C53F0ABC for ; Wed, 6 May 2026 15:23:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778081012; cv=none; b=txIh17uWenybmfW6VK8Do4MneDd79aeGBiFt9O9oYqMUU41UUEBheus8faAIBXQjrZKJ/4wsX4g883Nibf83jiNhf+9wIGmI3NfiEkjvgJDnmAbZ6dBfg2abAt0uodmwGc4yRgADo6q9Fjc5bwi4JTuBLgzzFyIzaMkqE7Tfr3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778081012; c=relaxed/simple; bh=CyYEcOtliJgXqRdAGp3zv5giNFV5frhcTWqdeRx2Ytw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZYtN0HAM3zo/dFS6u4j50xKM26M1LwlhDGpz1zhDG2MRPWwIzz/aUVcVlAt8cYitTxRlk5lTlS7BKHxrLdBnQ92UbP37yknK6mYWjL4ODzJwuhh3J05miGQXdWNSfDTQFJ19U1Pjjz35xWXnHp/S4WDfnldAfEIw3PYgVRbiCLg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jqVA68uH; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jqVA68uH" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-38e97e73234so63571661fa.1 for ; Wed, 06 May 2026 08:23:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778081005; x=1778685805; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=az24m6lFf/0S0zdSQIJvRICpQO+S19ShbYuWlJJ8fe0=; b=jqVA68uHv/yS4LMAVoWcO28+dwebUmisyW5l5veqxiApRHdWWtY4Fk0HywManLR2Aq Gsu5iJOW+MiICc01aSzSH6lIIo9crcKRExE3M5LQoE2mXwVWgALmcacH2ucWCZFxRkv7 X/cHNatu5t8SLThNkoqYY6jiFs1ICRvh/jl7RpaJaaOdORD2SBdMvoJBRSY4snlciWG4 CUPPos/rI2wKwTUCwYURGclFSKlvsqCC23uInCS5G0OMJ2bu97jPCi/CwmTg7hhzmqym gFMMKt11JMdq9xlDpB5nCiLCcE7AO1bvIqi1NB+kE4BFZBJ1dtS+O8ZftJqbkyJz9GwW Vcxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778081005; x=1778685805; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=az24m6lFf/0S0zdSQIJvRICpQO+S19ShbYuWlJJ8fe0=; b=XOiUQ9jbJ80UtK7KqHE0adycy0TKMgHjsMmfupiLKAgSjME/9uH47101N1Tb7NVpVB erynH7sBQJM3dCR/p6aZoBQSv3BADG8btLW0cSw095sA+3ZEUyN52Ygw/Jf2egl1Vue2 SM+Egs0YPhFPFWiaYTD0SW6K6RoBSzZ6pdLU5gUqOAOTapjaxgJokyuUSA6pBrOBctbu HF36VGVnjz0d8b18HbPnxwmHyCF7/GzwuLgwl0D+xmAM3OcRKiokJyquQRqxlwDzupi7 DOnfZmyYrDxbqdKUa/kGWxwuaAbjcUOxWHBkCUdPHUUiM4b6/A6dsDvth/wC5gKYUX0s Pq6g== X-Forwarded-Encrypted: i=1; AFNElJ8cL9m2XYhFc0tH8S8gKhtylTx483WNpCsOflKWnyfAy5K5DCe+vRHG6f+uH5HrdtqfwHv4rOqceBm6QeM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywg5ScKfIpi7rJ7IgnSHpGOEjc4+Dmt0pLi1NzqE04zAB93J7wH VmkoIYEcUH0tEbcG5T8g2JFhADumswXG9ZeMe7Atp6m28hmhm40QCxpK X-Gm-Gg: AeBDiev3tXJAJEUsag3CAz18SLqWTGBOpmSUAO/L628TLesuB1Y/PVX7twsFbA8zCAU BSPNok6srhI+7DVVjoGnmFgQ6plD4MrQ2HY3Uc6q/q2NN29argt23rB7ehRIa8d0ceC23CdQe4Q UM96rwZN8MViXl4Gu6Sl7k9kIzclvSAJMIdVhTyaFgKenX1KhnCReYZPHYktQMmd9KOsrukQTqv SVomxJekOugfwBrxvlGsv515AzvGFloj8VRuPi+ZRoKRixdQ+pdk+5w5fiS5aueHfgexdXvTnER 2Ye3mBHXEG5ajeGsXsJVpyLmEDMKeYiya2NI6vmEN46Z6TLD1Lhnvf1QykjlegKYUpvdmpGNiKb ptiKc/cdvoTcHvXzz4WkBRwRVUo7q/4wBOeEQM1j6lo7naWeDRVSxYY8fSo16r8kiyWakybkwut kNvw6t/aBiv38I5w2qlk0aRYG1zU7XxmdsKlyDuyZElVTbPfqP+/SMDm+lR0udRqYa8J4BlCKY6 A== X-Received: by 2002:a05:6512:63ca:b0:5a8:8891:d7e2 with SMTP id 2adb3069b0e04-5a88891d802mr1144127e87.14.1778081005119; Wed, 06 May 2026 08:23:25 -0700 (PDT) Received: from [192.168.2.20] (109-252-156-195.dynamic.spd-mgts.ru. [109.252.156.195]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a882e3589dsm1465348e87.30.2026.05.06.08.23.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 08:23:24 -0700 (PDT) Message-ID: Date: Wed, 6 May 2026 18:23:23 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/7] drm/bridge: tc358768: Support non-continuous clock To: Tomi Valkeinen , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Parth Pancholi , Francesco Dolcini Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= References: <20260311-tc358768-v2-0-e75a99131bd5@ideasonboard.com> <20260311-tc358768-v2-4-e75a99131bd5@ideasonboard.com> From: Dmitry Osipenko Content-Language: en-US In-Reply-To: <20260311-tc358768-v2-4-e75a99131bd5@ideasonboard.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 11.03.2026 10:48, Tomi Valkeinen пишет: > The driver prints a warning if MIPI_DSI_CLOCK_NON_CONTINUOUS is set, and > falls back to continuous clock mode. This was added in commit > fbc5a90e82c1 ("drm/bridge: tc358768: Disable non-continuous clock mode"). > > However, there have been multiple changes to the driver since then, and > at least in my setup, non-continuous clock mode works: I can see an > image on the panel, and I can see the clock lanes being non-continuous > with an oscilloscope. > > So, let's enable MIPI_DSI_CLOCK_NON_CONTINUOUS support. > > Cc: Dmitry Osipenko > Tested-by: João Paulo Gonçalves # Toradex Verdin AM62 > Reviewed-by: Francesco Dolcini > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/bridge/tc358768.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c > index 755ed6483b2e..a276fbc75dde 100644 > --- a/drivers/gpu/drm/bridge/tc358768.c > +++ b/drivers/gpu/drm/bridge/tc358768.c > @@ -722,7 +722,6 @@ static void tc358768_bridge_atomic_pre_enable(struct drm_bridge *bridge, > { > struct tc358768_priv *priv = bridge_to_tc358768(bridge); > struct mipi_dsi_device *dsi_dev = priv->output.dev; > - unsigned long mode_flags = dsi_dev->mode_flags; > u32 val, mask, val2, lptxcnt, hact, data_type; > s32 raw_val; > struct drm_crtc_state *crtc_state; > @@ -744,11 +743,6 @@ static void tc358768_bridge_atomic_pre_enable(struct drm_bridge *bridge, > u32 dsi_vsdly; > const u32 internal_dly = 40; > > - if (mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) { > - dev_warn_once(dev, "Non-continuous mode unimplemented, falling back to continuous\n"); > - mode_flags &= ~MIPI_DSI_CLOCK_NON_CONTINUOUS; > - } > - > tc358768_hw_enable(priv); > > ret = tc358768_sw_reset(priv); > @@ -1032,7 +1026,7 @@ static void tc358768_bridge_atomic_pre_enable(struct drm_bridge *bridge, > tc358768_write(priv, TC358768_HSTXVREGEN, val); > > tc358768_write(priv, TC358768_TXOPTIONCNTRL, > - (mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) ? 0 : BIT(0)); > + (dsi_dev->mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) ? 0 : BIT(0)); > > /* TXTAGOCNT[26:16] RXTASURECNT[10:0] */ > val = tc358768_ps_to_ns((lptxcnt + 1) * hsbyteclk_ps * 4); > @@ -1099,7 +1093,7 @@ static void tc358768_bridge_atomic_pre_enable(struct drm_bridge *bridge, > > val |= TC358768_DSI_CONTROL_TXMD; > > - if (!(mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS)) > + if (!(dsi_dev->mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS)) > val |= TC358768_DSI_CONTROL_HSCKMD; > > if (dsi_dev->mode_flags & MIPI_DSI_MODE_NO_EOT_PACKET) > Acked-by: Dmitry Osipenko