From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Masayoshi Mizuma <msys.mizuma@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org
Cc: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] perf/x86/intel/uncore: Use boot_cpu_data.logical_proc_id as the pkg id
Date: Fri, 21 Sep 2018 08:33:02 -0400 [thread overview]
Message-ID: <d858f681-2d37-524e-4ff4-c340f5e2ded1@linux.intel.com> (raw)
In-Reply-To: <20180921010746.32118-1-msys.mizuma@gmail.com>
On 9/20/2018 9:07 PM, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
>
> Physical package id 0 is not always exists. We should use
> boot_cpu_data.logical_proc_id directly as the pkg id here.
>
> Signed-off-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Thanks,
Kan
> ---
> arch/x86/events/intel/uncore_snbep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c
> index 51d7c11..edaadac 100644
> --- a/arch/x86/events/intel/uncore_snbep.c
> +++ b/arch/x86/events/intel/uncore_snbep.c
> @@ -3061,7 +3061,7 @@ static struct event_constraint bdx_uncore_pcu_constraints[] = {
>
> void bdx_uncore_cpu_init(void)
> {
> - int pkg = topology_phys_to_logical_pkg(0);
> + int pkg = boot_cpu_data.logical_proc_id;
>
> if (bdx_uncore_cbox.num_boxes > boot_cpu_data.x86_max_cores)
> bdx_uncore_cbox.num_boxes = boot_cpu_data.x86_max_cores;
>
prev parent reply other threads:[~2018-09-21 12:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 1:07 [PATCH v2] perf/x86/intel/uncore: Use boot_cpu_data.logical_proc_id as the pkg id Masayoshi Mizuma
2018-09-21 12:33 ` Liang, Kan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d858f681-2d37-524e-4ff4-c340f5e2ded1@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.mizuma@jp.fujitsu.com \
--cc=mingo@redhat.com \
--cc=msys.mizuma@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox